Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

wal: document, clean up fsync histogram

Browse Source 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
This commit is contained in:
Gyuho Lee 2018-05-23 13:48:29 -07:00
parent 1d91698268
commit b0b966c43c
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
wal/metrics.go
View File

@ -17,15 +17,18 @@ package wal
import "github.com/prometheus/client_golang/prometheus" import "github.com/prometheus/client_golang/prometheus"
var ( var (
syncDurations = prometheus.NewHistogram(prometheus.HistogramOpts{ walFsyncSec = prometheus.NewHistogram(prometheus.HistogramOpts{
Namespace: "etcd", Namespace: "etcd",
Subsystem: "disk", Subsystem: "disk",
Name: "wal_fsync_duration_seconds", Name: "wal_fsync_duration_seconds",
Help: "The latency distributions of fsync called by wal.", Help: "The latency distributions of fsync called by WAL.",
// lowest bucket start of upper bound 0.001 sec (1 ms) with factor 2
// highest bucket start of 0.001 sec * 2^13 == 8.192 sec
Buckets: prometheus.ExponentialBuckets(0.001, 2, 14), Buckets: prometheus.ExponentialBuckets(0.001, 2, 14),
}) })
) )
func init() { func init() {
prometheus.MustRegister(syncDurations) prometheus.MustRegister(walFsyncSec)
} }

2
wal/wal.go
View File

@ -590,7 +590,7 @@ func (w *WAL) sync() error {
plog.Warningf("sync duration of %v, expected less than %v", took, warnSyncDuration) plog.Warningf("sync duration of %v, expected less than %v", took, warnSyncDuration)
} }
} }
syncDurations.Observe(took.Seconds()) walFsyncSec.Observe(took.Seconds())
return err return err
} }