From b2a465e3545ef95b5db5429f5ef349464fb87256 Mon Sep 17 00:00:00 2001 From: Anthony Romano Date: Fri, 24 Mar 2017 13:18:31 -0700 Subject: [PATCH] grpcproxy/cache: only check compaction revision for historical revisions Since the current revision is 0, it'll always be less than the compaction revision. If the proxy sees a compaction, it would always reject the current revision requests since it's less than the compaction revision. Instead, check if the revision is historical before trying to reject on compaction revision. Fixes #7599 --- proxy/grpcproxy/cache/store.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxy/grpcproxy/cache/store.go b/proxy/grpcproxy/cache/store.go index 895fb1f97..9936ab3d2 100644 --- a/proxy/grpcproxy/cache/store.go +++ b/proxy/grpcproxy/cache/store.go @@ -111,7 +111,7 @@ func (c *cache) Get(req *pb.RangeRequest) (*pb.RangeResponse, error) { c.mu.Lock() defer c.mu.Unlock() - if req.Revision < c.compactedRev { + if req.Revision > 0 && req.Revision < c.compactedRev { c.lru.Remove(key) return nil, ErrCompacted }