Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

raft: Tiny refactor

Browse Source 
Rename i to id since i looks like index which is confusing.
This commit is contained in:
ngaut 2016-01-04 21:20:54 +08:00
parent acee23112a
commit b38dfda1c9
1 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
raft/raft.go
View File

@ -243,8 +243,8 @@ func (r *raft) q() int { return len(r.prs)/2 + 1 }
func (r *raft) nodes() []uint64 { func (r *raft) nodes() []uint64 {
nodes := make([]uint64, 0, len(r.prs)) nodes := make([]uint64, 0, len(r.prs))
for k := range r.prs { for id := range r.prs {
nodes = append(nodes, k) nodes = append(nodes, id)
} }
sort.Sort(uint64Slice(nodes)) sort.Sort(uint64Slice(nodes))
return nodes return nodes
@ -341,30 +341,30 @@ func (r *raft) sendHeartbeat(to uint64) {
// bcastAppend sends RPC, with entries to all peers that are not up-to-date // bcastAppend sends RPC, with entries to all peers that are not up-to-date
// according to the progress recorded in r.prs. // according to the progress recorded in r.prs.
func (r *raft) bcastAppend() { func (r *raft) bcastAppend() {
for i := range r.prs { for id := range r.prs {
if i == r.id { if id == r.id {
continue continue
} }
r.sendAppend(i) r.sendAppend(id)
} }
} }
// bcastHeartbeat sends RPC, without entries to all the peers. // bcastHeartbeat sends RPC, without entries to all the peers.
func (r *raft) bcastHeartbeat() { func (r *raft) bcastHeartbeat() {
for i := range r.prs { for id := range r.prs {
if i == r.id { if id == r.id {
continue continue
} }
r.sendHeartbeat(i) r.sendHeartbeat(id)
r.prs[i].resume() r.prs[id].resume()
} }
} }
func (r *raft) maybeCommit() bool { func (r *raft) maybeCommit() bool {
// TODO(bmizerany): optimize.. Currently naive // TODO(bmizerany): optimize.. Currently naive
mis := make(uint64Slice, 0, len(r.prs)) mis := make(uint64Slice, 0, len(r.prs))
for i := range r.prs { for id := range r.prs {
mis = append(mis, r.prs[i].Match) mis = append(mis, r.prs[id].Match)
} }
sort.Sort(sort.Reverse(mis)) sort.Sort(sort.Reverse(mis))
mci := mis[r.q()-1] mci := mis[r.q()-1]
@ -382,10 +382,10 @@ func (r *raft) reset(term uint64) {
r.heartbeatElapsed = 0 r.heartbeatElapsed = 0
r.votes = make(map[uint64]bool) r.votes = make(map[uint64]bool)
for i := range r.prs { for id := range r.prs {
r.prs[i] = &Progress{Next: r.raftLog.lastIndex() + 1, ins: newInflights(r.maxInflight)} r.prs[id] = &Progress{Next: r.raftLog.lastIndex() + 1, ins: newInflights(r.maxInflight)}
if i == r.id { if id == r.id {
r.prs[i].Match = r.raftLog.lastIndex() r.prs[id].Match = r.raftLog.lastIndex()
} }
} }
r.pendingConf = false r.pendingConf = false
@ -493,13 +493,13 @@ func (r *raft) campaign() {
r.becomeLeader() r.becomeLeader()
return return
} }
for i := range r.prs { for id := range r.prs {
if i == r.id { if id == r.id {
continue continue
} }
r.logger.Infof("%x [logterm: %d, index: %d] sent vote request to %x at term %d", r.logger.Infof("%x [logterm: %d, index: %d] sent vote request to %x at term %d",
r.id, r.raftLog.lastTerm(), r.raftLog.lastIndex(), i, r.Term) r.id, r.raftLog.lastTerm(), r.raftLog.lastIndex(), id, r.Term)
r.send(pb.Message{To: i, Type: pb.MsgVote, Index: r.raftLog.lastIndex(), LogTerm: r.raftLog.lastTerm()}) r.send(pb.Message{To: id, Type: pb.MsgVote, Index: r.raftLog.lastIndex(), LogTerm: r.raftLog.lastTerm()})
} }
} }