diff --git a/client/http_test.go b/client/http_test.go index 4ab68c5d9..c183c4e13 100644 --- a/client/http_test.go +++ b/client/http_test.go @@ -115,7 +115,7 @@ func TestGetAction(t *testing.T) { err := assertResponse(got, wantURL, wantHeader, nil) if err != nil { - t.Errorf("%#d: %v", i, err) + t.Errorf("#%d: %v", i, err) } } } @@ -164,7 +164,7 @@ func TestWaitAction(t *testing.T) { err := assertResponse(got, wantURL, wantHeader, nil) if err != nil { - t.Errorf("%#d: %v", i, err) + t.Errorf("#%d: %v", i, err) } } } @@ -208,7 +208,7 @@ func TestCreateAction(t *testing.T) { err := assertResponse(got, wantURL, wantHeader, []byte(tt.wantBody)) if err != nil { - t.Errorf("%#d: %v", i, err) + t.Errorf("#%d: %v", i, err) } } } diff --git a/discovery/discovery_test.go b/discovery/discovery_test.go index f45773896..2a816e89e 100644 --- a/discovery/discovery_test.go +++ b/discovery/discovery_test.go @@ -81,7 +81,7 @@ func TestProxyFuncFromEnv(t *testing.T) { t.Errorf("%s: unexpected non-nil err: %v", in, err) } if g.String() != w { - t.Errorf("%s: proxyURL=%q, want %q", g, w) + t.Errorf("%s: proxyURL=%q, want %q", in, g, w) } } diff --git a/etcdserver/cluster_store_test.go b/etcdserver/cluster_store_test.go index deb92a187..4b33de779 100644 --- a/etcdserver/cluster_store_test.go +++ b/etcdserver/cluster_store_test.go @@ -114,7 +114,7 @@ func TestClusterStoreDelete(t *testing.T) { wdeletes := []string{membersKVPrefix + "1"} if !reflect.DeepEqual(st.deletes, wdeletes) { - t.Error("deletes = %v, want %v", st.deletes, wdeletes) + t.Errorf("deletes = %v, want %v", st.deletes, wdeletes) } } diff --git a/etcdserver/etcdhttp/http.go b/etcdserver/etcdhttp/http.go index ea73fae01..44c08f4d5 100644 --- a/etcdserver/etcdhttp/http.go +++ b/etcdserver/etcdhttp/http.go @@ -469,7 +469,7 @@ func handleWatch(ctx context.Context, w http.ResponseWriter, wa store.Watcher, s } if err := json.NewEncoder(w).Encode(ev); err != nil { // Should never be reached - log.Println("error writing event: %v", err) + log.Printf("error writing event: %v\n", err) return } if !stream { diff --git a/etcdserver/etcdhttp/http_test.go b/etcdserver/etcdhttp/http_test.go index 3dd3c120b..a3a09c71e 100644 --- a/etcdserver/etcdhttp/http_test.go +++ b/etcdserver/etcdhttp/http_test.go @@ -695,7 +695,7 @@ func TestSelfServeStatsBad(t *testing.T) { }, ) if rw.Code != http.StatusMethodNotAllowed { - t.Errorf("method %s: code=%d, want %d", m, http.StatusMethodNotAllowed) + t.Errorf("method %s: code=%d, want %d", m, rw.Code, http.StatusMethodNotAllowed) } } } @@ -711,7 +711,7 @@ func TestLeaderServeStatsBad(t *testing.T) { }, ) if rw.Code != http.StatusMethodNotAllowed { - t.Errorf("method %s: code=%d, want %d", m, http.StatusMethodNotAllowed) + t.Errorf("method %s: code=%d, want %d", m, rw.Code, http.StatusMethodNotAllowed) } } } @@ -1226,7 +1226,7 @@ func TestHandleWatch(t *testing.T) { wrt := "5" if rr.Code != wcode { - t.Errorf("#%d: got code=%d, want %d", rr.Code, wcode) + t.Errorf("#%d: got code=%d, want %d", i, rr.Code, wcode) } h := rr.Header() if ct := h.Get("Content-Type"); ct != wct { diff --git a/etcdserver/server_test.go b/etcdserver/server_test.go index 9d94cee8f..fc272f885 100644 --- a/etcdserver/server_test.go +++ b/etcdserver/server_test.go @@ -988,8 +988,8 @@ func TestPublishRetry(t *testing.T) { action := n.Action() // multiple Proposes - if len(action) < 2 { - t.Errorf("len(action) = %d, want >= 2", action) + if n := len(action); n < 2 { + t.Errorf("len(action) = %d, want >= 2", n) } } diff --git a/pkg/flags/ipaddressport_test.go b/pkg/flags/ipaddressport_test.go index 3148746aa..ef034ca80 100644 --- a/pkg/flags/ipaddressport_test.go +++ b/pkg/flags/ipaddressport_test.go @@ -54,7 +54,7 @@ func TestIPAddressPortSet(t *testing.T) { for i, tt := range fail { f := &IPAddressPort{} if err := f.Set(tt); err == nil { - t.Errorf("#%d: expected error from IPAddressPort.Set(%q)", i, tt, err) + t.Errorf("#%d: expected error from IPAddressPort.Set(%q)", i, tt) } } } diff --git a/pkg/transport/listener_test.go b/pkg/transport/listener_test.go index 30b9294d6..9745b0900 100644 --- a/pkg/transport/listener_test.go +++ b/pkg/transport/listener_test.go @@ -85,7 +85,7 @@ func TestNewTransportTLSInfo(t *testing.T) { gotTLSClientConfig := trans.TLSClientConfig != nil if tt.wantTLSClientConfig != gotTLSClientConfig { - t.Fatalf("%#d: wantTLSClientConfig=%t but gotTLSClientConfig=%t", i, tt.wantTLSClientConfig, gotTLSClientConfig) + t.Fatalf("#%d: wantTLSClientConfig=%t but gotTLSClientConfig=%t", i, tt.wantTLSClientConfig, gotTLSClientConfig) } } } @@ -193,7 +193,7 @@ func TestTLSInfoConfigFuncs(t *testing.T) { } if tt.wantCAs != (sCfg.ClientCAs != nil) { - t.Errorf("%#d: wantCAs=%t but ClientCAs=%v", i, tt.wantCAs, sCfg.ClientCAs) + t.Errorf("#%d: wantCAs=%t but ClientCAs=%v", i, tt.wantCAs, sCfg.ClientCAs) } cCfg, err := tt.info.ClientConfig() @@ -202,7 +202,7 @@ func TestTLSInfoConfigFuncs(t *testing.T) { } if tt.wantCAs != (cCfg.RootCAs != nil) { - t.Errorf("%#d: wantCAs=%t but RootCAs=%v", i, tt.wantCAs, sCfg.RootCAs) + t.Errorf("#%d: wantCAs=%t but RootCAs=%v", i, tt.wantCAs, sCfg.RootCAs) } } }