fix a bug in set(update node need to create a new one, not get the pointer of the node)

command.go

@@ -90,7 +90,7 @@ func (c *WatchCommand) Apply(server *raft.Server) ([]byte, error) {
 	ch := make(chan store.Response)
 
 	// add to the watchers list
-	store.AddWatcher(c.Key, ch)
+	store.AddWatcher(c.Key, ch, 0)
 
 	// wait for the notification for any changing
 	res := <-ch

handlers.go

@@ -100,7 +100,7 @@ func SetHttpHandler(w http.ResponseWriter, req *http.Request) {
 
 	command := &SetCommand{}
 	command.Key = key
-	values := strings.Split(string(content), " ")
+	values := strings.Split(string(content), ",")
 
 	command.Value = values[0]
 

store/store.go

@@ -109,10 +109,9 @@ func Set(key string, value string, expireTime time.Time) ([]byte, error) {
 				go expire(key, node.update, expireTime)
 			}
 		}
-
+		
 		// update the information of the node
-		node.ExpireTime = expireTime
+		s.Nodes[key] = Node{value, expireTime, node.update}
-		node.Value = value
 
 		resp := Response{SET, key, node.Value, value, true, expireTime}
 
@@ -192,6 +191,7 @@ func expire(key string, update chan time.Time, expireTime time.Time) {
 			// if the node become a permanent one, the go routine is
 			// not needed
 			if updateTime.Equal(PERMANENT) {
+				fmt.Println("permanent")
 				return
 			}
 			// update duration

store/watcher.go

@@ -3,44 +3,60 @@ package store
 import (
 	"path"
 	"strings"
-
-//"fmt"
 )
 
-type Watchers struct {
+const (
-	chanMap map[string][]chan Response
+	SHORT = iota
+	LONG
+)
+
+type WatcherHub struct {
+	watchers map[string][]Watcher
+}
+
+type Watcher struct {
+	c chan Response 
+	wType int
 }
 
 // global watcher
-var w *Watchers
+var w *WatcherHub
 
 // init the global watcher
 func init() {
-	w = createWatcher()
+	w = createWatcherHub()
 }
 
 // create a new watcher
-func createWatcher() *Watchers {
+func createWatcherHub() *WatcherHub {
-	w := new(Watchers)
+	w := new(WatcherHub)
-	w.chanMap = make(map[string][]chan Response)
+	w.watchers = make(map[string][]Watcher)
 	return w
 }
 
-func Watcher() *Watchers {
+func GetWatcherHub() *WatcherHub {
 	return w
 }
 
 // register a function with channel and prefix to the watcher
-func AddWatcher(prefix string, c chan Response) error {
+func AddWatcher(prefix string, c chan Response, wType int) error {
 
 	prefix = "/" + path.Clean(prefix)
 
-	_, ok := w.chanMap[prefix]
+	_, ok := w.watchers[prefix]
+
 	if !ok {
-		w.chanMap[prefix] = make([]chan Response, 0)
+		
-		w.chanMap[prefix] = append(w.chanMap[prefix], c)
+		w.watchers[prefix] = make([]Watcher, 0)
+
+		watcher := Watcher{c, wType}
+
+		w.watchers[prefix] = append(w.watchers[prefix], watcher)
 	} else {
-		w.chanMap[prefix] = append(w.chanMap[prefix], c)
+
+		watcher := Watcher{c, wType}
+
+		w.watchers[prefix] = append(w.watchers[prefix], watcher)
 	}
 
 	return nil
@@ -57,18 +73,26 @@ func notify(resp Response) error {
 	for _, segment := range segments {
 		currPath = path.Join(currPath, segment)
 
-		chans, ok := w.chanMap[currPath]
+		watchers, ok := w.watchers[currPath]
 
 		if ok {
 
+			newWatchers := make([]Watcher, 0)
 			// notify all the watchers
-			for _, c := range chans {
+			for _, watcher := range watchers {
-				c <- resp
+				 watcher.c <- resp
+				 if watcher.wType == LONG {
+				 	newWatchers = append(newWatchers, watcher)
+				 }
 			}
 
-			// we have notified all the watchers at this path
+			if len(newWatchers) == 0 {
-			// delete the map
+				// we have notified all the watchers at this path
-			delete(w.chanMap, currPath)
+				// delete the map
+				delete(w.watchers, currPath)
+			} else {
+				w.watchers[currPath] = newWatchers
+			}
 		}
 
 	}