Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

snap: add save latency metrics

Browse Source
This commit is contained in:
Xiang Li 2015-02-17 14:39:05 -08:00 committed by Yicheng Qin
parent 95bba154d6
commit c3d3ad931b
2 changed files with 38 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
snap/metrics.go Normal file
View File

@ -0,0 +1,30 @@
// Copyright 2015 CoreOS, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package snap
import "github.com/coreos/etcd/Godeps/_workspace/src/github.com/prometheus/client_golang/prometheus"
var (
// TODO: save_fsync latency?
// TODO: save_encoding latency?
saveDurations = prometheus.NewSummary(prometheus.SummaryOpts{
Name: "snapshot_save_total_durations_microseconds",
Help: "The total latency distributions of save called by snapshot.",
})
)
func init() {
prometheus.MustRegister(saveDurations)
}

9
snap/snapshotter.go
View File

@ -24,6 +24,7 @@ import (
"path" "path"
"sort" "sort"
"strings" "strings"
"time"
"github.com/coreos/etcd/pkg/pbutil" "github.com/coreos/etcd/pkg/pbutil"
"github.com/coreos/etcd/raft" "github.com/coreos/etcd/raft"
@ -60,6 +61,8 @@ func (s *Snapshotter) SaveSnap(snapshot raftpb.Snapshot) error {
} }
func (s *Snapshotter) save(snapshot *raftpb.Snapshot) error { func (s *Snapshotter) save(snapshot *raftpb.Snapshot) error {
start := time.Now()
fname := fmt.Sprintf("%016x-%016x%s", snapshot.Metadata.Term, snapshot.Metadata.Index, snapSuffix) fname := fmt.Sprintf("%016x-%016x%s", snapshot.Metadata.Term, snapshot.Metadata.Index, snapSuffix)
b := pbutil.MustMarshal(snapshot) b := pbutil.MustMarshal(snapshot)
crc := crc32.Update(0, crcTable, b) crc := crc32.Update(0, crcTable, b)
@ -68,7 +71,11 @@ func (s *Snapshotter) save(snapshot *raftpb.Snapshot) error {
if err != nil { if err != nil {
return err return err
} }
return ioutil.WriteFile(path.Join(s.dir, fname), d, 0666) err = ioutil.WriteFile(path.Join(s.dir, fname), d, 0666)
if err != nil {
saveDurations.Observe(float64(time.Since(start).Nanoseconds() / int64(time.Microsecond)))
}
return err
} }
func (s *Snapshotter) Load() (*raftpb.Snapshot, error) { func (s *Snapshotter) Load() (*raftpb.Snapshot, error) {