diff --git a/etcdmain/etcd.go b/etcdmain/etcd.go index 907f7540c..8a58768d5 100644 --- a/etcdmain/etcd.go +++ b/etcdmain/etcd.go @@ -249,7 +249,7 @@ func startProxy(cfg *config) error { } uf := func() []string { - gcls, err := etcdserver.GetClusterFromPeers(peerURLs, tr) + gcls, err := etcdserver.GetClusterFromRemotePeers(peerURLs, tr) // TODO: remove the 2nd check when we fix GetClusterFromPeers // GetClusterFromPeers should not return nil error with an invaild empty cluster if err != nil { diff --git a/etcdserver/cluster_util.go b/etcdserver/cluster_util.go index 8381c3e23..9cc0a72e2 100644 --- a/etcdserver/cluster_util.go +++ b/etcdserver/cluster_util.go @@ -29,8 +29,7 @@ import ( // isMemberBootstrapped tries to check if the given member has been bootstrapped // in the given cluster. func isMemberBootstrapped(cl *Cluster, member string, tr *http.Transport) bool { - us := getRemotePeerURLs(cl, member) - rcl, err := getClusterFromPeers(us, false, tr) + rcl, err := getClusterFromRemotePeers(getRemotePeerURLs(cl, member), false, tr) if err != nil { return false } @@ -45,17 +44,17 @@ func isMemberBootstrapped(cl *Cluster, member string, tr *http.Transport) bool { return false } -// GetClusterFromPeers takes a set of URLs representing etcd peers, and +// GetClusterFromRemotePeers takes a set of URLs representing etcd peers, and // attempts to construct a Cluster by accessing the members endpoint on one of // these URLs. The first URL to provide a response is used. If no URLs provide // a response, or a Cluster cannot be successfully created from a received // response, an error is returned. -func GetClusterFromPeers(urls []string, tr *http.Transport) (*Cluster, error) { - return getClusterFromPeers(urls, true, tr) +func GetClusterFromRemotePeers(urls []string, tr *http.Transport) (*Cluster, error) { + return getClusterFromRemotePeers(urls, true, tr) } // If logerr is true, it prints out more error messages. -func getClusterFromPeers(urls []string, logerr bool, tr *http.Transport) (*Cluster, error) { +func getClusterFromRemotePeers(urls []string, logerr bool, tr *http.Transport) (*Cluster, error) { cc := &http.Client{ Transport: tr, Timeout: time.Second, diff --git a/etcdserver/server.go b/etcdserver/server.go index 8324bc553..38e42a530 100644 --- a/etcdserver/server.go +++ b/etcdserver/server.go @@ -157,8 +157,7 @@ func NewServer(cfg *ServerConfig) (*EtcdServer, error) { switch { case !haveWAL && !cfg.NewCluster: - us := getRemotePeerURLs(cfg.Cluster, cfg.Name) - existingCluster, err := GetClusterFromPeers(us, cfg.Transport) + existingCluster, err := GetClusterFromRemotePeers(getRemotePeerURLs(cfg.Cluster, cfg.Name), cfg.Transport) if err != nil { return nil, fmt.Errorf("cannot fetch cluster info from peer urls: %v", err) } diff --git a/etcdserver/server_test.go b/etcdserver/server_test.go index c7a8308ac..b0c3e0f40 100644 --- a/etcdserver/server_test.go +++ b/etcdserver/server_test.go @@ -1135,7 +1135,7 @@ func TestGetOtherPeerURLs(t *testing.T) { } for i, tt := range tests { cl := NewClusterFromMembers("", types.ID(0), tt.membs) - urls := getOtherPeerURLs(cl, tt.self) + urls := getRemotePeerURLs(cl, tt.self) if !reflect.DeepEqual(urls, tt.wurls) { t.Errorf("#%d: urls = %+v, want %+v", i, urls, tt.wurls) }