Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15318 from serathius/linearizability-duplicate-revision

Browse Source 
Allow multiple operations with same mod revisions, but forbid …
This commit is contained in:
Marek Siarkowicz
2023-02-14 17:03:47 +01:00
committed by GitHub
parent 6c439aa9e2 b4f9bb45fc
commit c60e5954b3
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/linearizability/watch.go
View File

@@ -99,10 +99,13 @@ func validateMemberWatchResponses(t *testing.T, responses []watchResponse, expec
if resp.Header.Revision == lastHeadRevision && len(resp.Events) != 0 { if resp.Header.Revision == lastHeadRevision && len(resp.Events) != 0 {
t.Errorf("Got two non-empty responses about same revision") t.Errorf("Got two non-empty responses about same revision")
} }
if len(resp.Events) > 0 && resp.Events[0].Kv.ModRevision <= lastEventModRevision {
t.Errorf("Events with same revision should not be split between multiple responses, lastResponseModRevision: %d, firstEventModRevision: %d", lastEventModRevision, resp.Events[0].Kv.ModRevision)
}
for _, event := range resp.Events { for _, event := range resp.Events {
if event.Kv.ModRevision != lastEventModRevision+1 { if event.Kv.ModRevision != lastEventModRevision && event.Kv.ModRevision != lastEventModRevision+1 {
t.Errorf("Expect event revision to grow by 1, last: %d, mod: %d", lastEventModRevision, event.Kv.ModRevision) t.Errorf("Event mod revision should stay the same or increment by one, last: %d, current: %d", lastEventModRevision, event.Kv.ModRevision)
} }
lastEventModRevision = event.Kv.ModRevision lastEventModRevision = event.Kv.ModRevision
} }