Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15789 from ahrtr/save_data_20230427

Browse Source 
test: forcibly save data on panicking
This commit is contained in:
Marek Siarkowicz 2023-04-27 16:23:49 +02:00 committed by GitHub
commit cd24847086
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/robustness/linearizability_test.go
View File

@ -211,8 +211,12 @@ func testRobustness(ctx context.Context, t *testing.T, lg *zap.Logger, config e2
}
defer r.clus.Close()
// t.Failed() returns false during panicking. We need to forcibly
// save data on panicking.
// Refer to: https://github.com/golang/go/issues/49929
panicked := true
defer func() {
r.Report(t)
r.Report(t, panicked)
}()
r.operations, r.responses = runScenario(ctx, t, lg, r.clus, *traffic, failpoint)
forcestopCluster(r.clus)
@ -225,6 +229,8 @@ func testRobustness(ctx context.Context, t *testing.T, lg *zap.Logger, config e2
r.patchedOperations = patchOperationBasedOnWatchEvents(r.operations, longestHistory(r.events))
r.visualizeHistory = model.ValidateOperationHistoryAndReturnVisualize(t, lg, r.patchedOperations)
panicked = false
}
func runScenario(ctx context.Context, t *testing.T, lg *zap.Logger, clus *e2e.EtcdProcessCluster, traffic trafficConfig, failpoint FailpointConfig) (operations []porcupine.Operation, responses [][]watchResponse) {

4
tests/robustness/report.go
View File

@ -61,9 +61,9 @@ func testResultsDirectory(t *testing.T) string {
return path
}
func (r *report) Report(t *testing.T) {
func (r *report) Report(t *testing.T, force bool) {
path := testResultsDirectory(t)
if t.Failed() {
if t.Failed() || force {
for i, member := range r.clus.Procs {
memberDataDir := filepath.Join(path, member.Config().Name)
persistMemberDataDir(t, r.lg, member, memberDataDir)