From cf7be488a947a744019dc3b4071dcfd724305bbf Mon Sep 17 00:00:00 2001 From: yura Date: Fri, 5 Oct 2018 12:47:00 +0300 Subject: [PATCH] clientv3: concurrency.Mutex.Lock() - preserve invariant Convenient invariant: - if werr == nil then lock is supposed to be locked at the moment. While we could not be confident in stronger invariant ('is exactly locked'), it were inconvenient that previous code could return `werr == nil` after Mutex.Unlock. It could happen when ctx is canceled/timeouted exactly after waitDeletes successfully returned werr == nil and before `<-ctx.Done()` checked. While such situation is very rare, it is still possible. fixes #10111 --- clientv3/concurrency/mutex.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/clientv3/concurrency/mutex.go b/clientv3/concurrency/mutex.go index 1e9e36a35..9d3a23c1d 100644 --- a/clientv3/concurrency/mutex.go +++ b/clientv3/concurrency/mutex.go @@ -58,11 +58,9 @@ func (m *Mutex) Lock(ctx context.Context) error { // wait for deletion revisions prior to myKey err = waitDeletes(ctx, client, m.pfx, m.myRev-1) - // release lock key if cancelled - select { - case <-ctx.Done(): + // release lock key if wait failed + if err != nil { m.Unlock(client.Ctx()) - default: } return err }