diff --git a/test b/test index ffc9f32b3..eecbc8ed3 100755 --- a/test +++ b/test @@ -38,13 +38,13 @@ IGNORE_PKGS="(cmd/|etcdserverpb|rafttest|gopath.proto|v3lockpb|v3electionpb)" INTEGRATION_PKGS="(integration|e2e|contrib|functional-tester)" # all github.com/coreos/etcd/whatever pkgs that are not auto-generated / tools -PKGS=`find . -name \*.go | while read a; do dirname $a; done | sort | uniq | egrep -v "$IGNORE_PKGS" | egrep -v "(tools/|contrib/|e2e|pb)" | sed "s|\.|${REPO_PATH}|g" | xargs echo` +PKGS=$(find . -name \*.go | while read -r a; do dirname "$a"; done | sort | uniq | grep -vE "$IGNORE_PKGS" | grep -vE "(tools/|contrib/|e2e|pb)" | sed "s|\.|${REPO_PATH}|g" | xargs echo) # pkg1,pkg2,pkg3 PKGS_COMMA=${PKGS// /,} -TEST_PKGS=`find . -name \*_test.go | while read a; do dirname $a; done | sort | uniq | egrep -v "$IGNORE_PKGS" | sed "s|\./||g"` -FORMATTABLE=`find . -name \*.go | while read a; do echo "$(dirname $a)/*.go"; done | sort | uniq | egrep -v "$IGNORE_PKGS" | sed "s|\./||g"` -TESTABLE_AND_FORMATTABLE=`echo "$TEST_PKGS" | egrep -v "$INTEGRATION_PKGS"` +TEST_PKGS=$(find . -name \*_test.go | while read -r a; do dirname "$a"; done | sort | uniq | grep -vE "$IGNORE_PKGS" | sed "s|\./||g") +FORMATTABLE=$(find . -name \*.go | while read -r a; do echo "$(dirname "$a")/*.go"; done | sort | uniq | grep -vE "$IGNORE_PKGS" | sed "s|\./||g") +TESTABLE_AND_FORMATTABLE=$(echo "$TEST_PKGS" | grep -vE "$INTEGRATION_PKGS") # check if user provided PKG override if [ -z "${USERPKG}" ]; then @@ -58,20 +58,23 @@ else # only run gofmt on packages provided by user FMT="$TEST" fi +FMT=($FMT) -# split TEST into an array and prepend REPO_PATH to each local package -split=(${TEST// / }) -TEST=${split/#/${REPO_PATH}/} +# prepend REPO_PATH to each local package +split=$TEST +TEST="" +for a in $split; do TEST="$TEST ${REPO_PATH}/${a}"; done +TEST=($TEST) # TODO: 'client' pkg fails with gosimple from generated files # TODO: 'rafttest' is failing with unused -STATIC_ANALYSIS_PATHS=`find . -name \*.go | while read a; do dirname $a; done | sort | uniq | egrep -v "$IGNORE_PKGS" | grep -v 'client'` +STATIC_ANALYSIS_PATHS=$(find . -name \*.go | while read -r a; do dirname "$a"; done | sort | uniq | grep -vE "$IGNORE_PKGS" | grep -v 'client') +STATIC_ANALYSIS_PATHS=($STATIC_ANALYSIS_PATHS) if [ -z "$GOARCH" ]; then GOARCH=$(go env GOARCH); fi - # determine whether target supports race detection if [ "$GOARCH" == "amd64" ]; then RACE="--race" @@ -79,8 +82,16 @@ fi function unit_pass { echo "Running unit tests..." + GO_TEST_FLAG="" + if [ "${VERBOSE}" == "1" ]; then + GO_TEST_FLAG="-v" + fi + if [ "${VERBOSE}" == "2" ]; then + GO_TEST_FLAG="-v" + export CLIENT_DEBUG=1 + fi # only -run=Test so examples can run in integration tests - go test -timeout 3m ${COVER} ${RACE} -cpu 1,2,4 -run=Test $@ ${TEST} + go test ${GO_TEST_FLAG} -timeout 5m "${COVER}" ${RACE} -cpu 1,2,4 -run=Test "$@" "${TEST[@]}" } function integration_pass { @@ -131,79 +142,26 @@ function functional_pass { fi } -function cov_pass { - echo "Running code coverage..." - # install gocovmerge before running code coverage from github.com/wadey/gocovmerge - # gocovmerge merges coverage files - if ! which gocovmerge >/dev/null; then - echo "gocovmerge not installed" - exit 255 - fi - - if [ -z "$COVERDIR" ]; then - echo "COVERDIR undeclared" - exit 255 - fi - - if [ ! -f "bin/etcd_test" ]; then - echo "etcd_test binary not found" - exit 255 - fi - - mkdir -p "$COVERDIR" - - # run code coverage for unit and integration tests - GOCOVFLAGS="-covermode=set -coverpkg $PKGS_COMMA -v -timeout 15m" - failed="" - for t in `echo "${TEST_PKGS}" | egrep -v "(e2e|functional-tester)"`; do - tf=`echo $t | tr / _` - # cache package compilation data for faster repeated builds - go test $GOCOVFLAGS -i ${REPO_PATH}/$t || true - # uses -run=Test to skip examples because clientv3/ example tests will leak goroutines - go test $GOCOVFLAGS -run=Test -coverprofile "$COVERDIR/${tf}.coverprofile" ${REPO_PATH}/$t || failed="$failed $t" - done - - # proxy tests - go test -tags cluster_proxy $GOCOVFLAGS -coverprofile "$COVERDIR/proxy_integration.coverprofile" ${REPO_PATH}/integration || failed="$failed proxy-integration" - go test -tags cluster_proxy $GOCOVFLAGS -coverprofile "$COVERDIR/proxy_clientv3.coverprofile" ${REPO_PATH}/clientv3/integration || failed="$failed proxy-clientv3/integration" - - # run code coverage for e2e tests - # use 30m timeout because e2e coverage takes longer - # due to many tests cause etcd process to wait - # on leadership transfer timeout during gracefully shutdown - go test -tags cov -timeout 30m -v ${REPO_PATH}"/e2e" || failed="$failed e2e" - - gocovmerge "$COVERDIR"/*.coverprofile >"$COVERDIR"/cover.out - # strip out generated files (using GNU-style sed) - sed --in-place '/generated.go/d' "$COVERDIR"/cover.out || true - - # held failures to generate the full coverage file, now fail - if [ -n "$failed" ]; then - for f in $failed; do - echo "--- FAIL:" "$f" - done - exit 255 - fi -} - function e2e_pass { echo "Running e2e tests..." go test -timeout 15m -v -cpu 1,2,4 $@ ${REPO_PATH}/e2e } +function integration_extra { + go test -timeout 15m -v ${RACE} -cpu 1,2,4 "$@" "${REPO_PATH}/client/integration" + go test -timeout 15m -v ${RACE} -cpu 1,2,4 "$@" "${REPO_PATH}/clientv3/integration" +} + function integration_e2e_pass { echo "Running integration and e2e tests..." - go test -timeout 15m -v -cpu 1,2,4 $@ ${REPO_PATH}/e2e & + go test -timeout 15m -v -cpu 1,2,4 "$@" "${REPO_PATH}/e2e" & e2epid="$!" - go test -timeout 15m -v -cpu 1,2,4 $@ ${REPO_PATH}/integration & + go test -timeout 15m -v -cpu 1,2,4 "$@" "${REPO_PATH}/integration" & intpid="$!" wait $e2epid wait $intpid - go test -timeout 1m -v ${RACE} -cpu 1,2,4 $@ ${REPO_PATH}/client/integration - go test -timeout 10m -v ${RACE} -cpu 1,2,4 $@ ${REPO_PATH}/clientv3/integration - go test -timeout 1m -v -cpu 1,2,4 $@ ${REPO_PATH}/contrib/raftexample - go test -timeout 1m -v ${RACE} -cpu 1,2,4 -run=Example $@ ${TEST} + integration_extra "$@" } function grpcproxy_pass { @@ -260,30 +218,6 @@ function fmt_pass { exit 255 fi - echo "Checking 'go tool vet -all -shadow'..." - fmtpkgs=$(echo $FMT | xargs dirname | sort | uniq | sed '/\./d') - vetRes=$(go tool vet -all -shadow ${fmtpkgs} 2>&1 | grep -v '/gw/' || true) - if [ -n "${vetRes}" ]; then - echo -e "govet -all -shadow checking failed:\n${vetRes}" - exit 255 - fi - - if which shellcheck >/dev/null; then - echo "Checking shellcheck..." - shellcheckResult=$(shellcheck -fgcc build test scripts/* 2>&1 || true) - if [ -n "${shellcheckResult}" ]; then - # mask the most common ones; fix later - SHELLCHECK_MASK="SC(2086|2006|2068|2196|2035|2162|2076)" - errs=$(echo "${shellcheckResult}" | egrep -v "${SHELLCHECK_MASK}" || true) - if [ -n "${errs}" ]; then - echo -e "shellcheck checking failed:\n${shellcheckResult}\n===\nFailed:\n${errs}" - exit 255 - fi - suppressed=$(echo "${shellcheckResult}" | cut -f4- -d':' | sort | uniq -c | sort -n) - echo -e "shellcheck suppressed warnings:\n${suppressed}" - fi - fi - echo "Checking documentation style..." # eschew you yous=`find . -name \*.md -exec egrep --color "[Yy]ou[r]?[ '.,;]" {} + | grep -v /v2/ || true` @@ -304,22 +238,6 @@ function fmt_pass { echo "Skipping marker..." fi - if which goword >/dev/null; then - echo "Checking goword..." - # get all go files to process - gofiles=`find $FMT -iname '*.go' 2>/dev/null` - # ignore tests and protobuf files - gofiles=`echo ${gofiles} | sort | uniq | sed "s/ /\n/g" | egrep -v "(\\_test.go|\\.pb\\.go)"` - # only check for broken exported godocs - gowordRes=`goword -use-spell=false ${gofiles} | grep godoc-export | sort` - if [ ! -z "$gowordRes" ]; then - echo -e "goword checking failed:\n${gowordRes}" - exit 255 - fi - else - echo "Skipping goword..." - fi - if which gosimple >/dev/null; then echo "Checking gosimple..." gosimpleResult=`gosimple ${STATIC_ANALYSIS_PATHS} 2>&1 || true`