From c7c0e1eb7a6d4b112d55a5bef1e9b75e0ad7fc68 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Fri, 13 May 2016 11:42:13 -0700 Subject: [PATCH] integration: remove parallel testing We cannot do testing in parallel since leak testing will detect the goroutines in other tests running in parallel. --- clientv3/integration/kv_test.go | 4 ---- integration/v3_grpc_test.go | 7 ------- 2 files changed, 11 deletions(-) diff --git a/clientv3/integration/kv_test.go b/clientv3/integration/kv_test.go index 1303c93ab..817d1efc2 100644 --- a/clientv3/integration/kv_test.go +++ b/clientv3/integration/kv_test.go @@ -111,9 +111,6 @@ func TestKVPut(t *testing.T) { } func TestKVPutWithRequireLeader(t *testing.T) { - // this test might block for a few seconds, make it parallel to speed up the test. - t.Parallel() - defer testutil.AfterTest(t) clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3}) @@ -576,7 +573,6 @@ func TestKVGetCancel(t *testing.T) { // TestKVPutStoppedServerAndClose ensures closing after a failed Put works. func TestKVPutStoppedServerAndClose(t *testing.T) { - t.Parallel() defer testutil.AfterTest(t) clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 1}) defer clus.Terminate(t) diff --git a/integration/v3_grpc_test.go b/integration/v3_grpc_test.go index a9596e8ff..d90d592b0 100644 --- a/integration/v3_grpc_test.go +++ b/integration/v3_grpc_test.go @@ -78,9 +78,6 @@ func TestV3PutOverwrite(t *testing.T) { // TestPutRestart checks if a put after an unrelated member restart succeeds func TestV3PutRestart(t *testing.T) { - // this test might block for 5 seconds, make it parallel to speed up the test. - t.Parallel() - defer testutil.AfterTest(t) clus := NewClusterV3(t, &ClusterConfig{Size: 3}) defer clus.Terminate(t) @@ -979,8 +976,6 @@ func TestTLSGRPCAcceptSecureAll(t *testing.T) { } func TestGRPCRequireLeader(t *testing.T) { - t.Parallel() - defer testutil.AfterTest(t) cfg := ClusterConfig{Size: 3} @@ -1008,8 +1003,6 @@ func TestGRPCRequireLeader(t *testing.T) { } func TestGRPCStreamRequireLeader(t *testing.T) { - t.Parallel() - defer testutil.AfterTest(t) cfg := ClusterConfig{Size: 3}