Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #17634 from callthingsoff/httpresponse_close_after_read

Browse Source 
all: call Close() after reading http.Response.Body
This commit is contained in:
Benjamin Wang 2024-03-25 07:03:54 +00:00 committed by GitHub
commit e4448c4744
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
contrib/lock/client/client.go
View File

@ -69,6 +69,7 @@ func write(key string, value string, version int64) error {
if err != nil { if err != nil {
log.Fatalf("failed to read request body: %s", err) log.Fatalf("failed to read request body: %s", err)
} }
httpResp.Body.Close()
resp := new(response) resp := new(response)
err = json.Unmarshal(respBytes, resp) err = json.Unmarshal(respBytes, resp)

1
server/etcdserver/api/etcdhttp/peer_test.go
View File

@ -103,6 +103,7 @@ func TestNewPeerHandlerOnRaftPrefix(t *testing.T) {
if err != nil { if err != nil {
t.Fatalf("unexpected io.ReadAll error: %v", err) t.Fatalf("unexpected io.ReadAll error: %v", err)
} }
resp.Body.Close()
if w := "test data"; string(body) != w { if w := "test data"; string(body) != w {
t.Errorf("#%d: body = %s, want %s", i, body, w) t.Errorf("#%d: body = %s, want %s", i, body, w)
} }