From eac75c28ae2aad5df898058d1d7bb0ceb1944e3d Mon Sep 17 00:00:00 2001 From: Sergey Kacheev <S.Kacheev@gmail.com> Date: Sun, 1 Aug 2021 00:20:50 +0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Lili Cosic <cosiclili@gmail.com> --- pkg/netutil/netutil.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/netutil/netutil.go b/pkg/netutil/netutil.go index cda090034..5b1e17966 100644 --- a/pkg/netutil/netutil.go +++ b/pkg/netutil/netutil.go @@ -192,7 +192,7 @@ func URLStringsEqual(ctx context.Context, lg *zap.Logger, a []string, b []string sort.Sort(types.URLs(urlsB)) for i := range urlsA { if !reflect.DeepEqual(urlsA[i], urlsB[i]) { - // If urls are not equal, try to resolve it and compare again. + // If URLs are not equal, try to resolve it and compare again. return urlsEqual(ctx, lg, urlsA, urlsB) } } @@ -212,7 +212,7 @@ func stringsToURLs(us []string) ([]url.URL, error) { for _, str := range us { u, err := url.Parse(str) if err != nil { - return nil, fmt.Errorf("failed to parse %q", str) + return nil, fmt.Errorf("failed to parse string to URL: %q", str) } urls = append(urls, *u) }