From eef8636f352dfa76d20742bdfb55038aa25b5a4f Mon Sep 17 00:00:00 2001 From: Jes Cok Date: Wed, 27 Sep 2023 22:41:16 +0800 Subject: [PATCH] pkg/stringutil: sort 'ss' in TestUniqueStrings From the algorithm below, 'ss' should be sorted. Also removes 'fmt.Println', because the idiomatic tests would not print. Signed-off-by: Jes Cok --- pkg/stringutil/rand_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/stringutil/rand_test.go b/pkg/stringutil/rand_test.go index 1b4a9dfd2..ab51ef263 100644 --- a/pkg/stringutil/rand_test.go +++ b/pkg/stringutil/rand_test.go @@ -15,16 +15,16 @@ package stringutil import ( - "fmt" + "sort" "testing" ) func TestUniqueStrings(t *testing.T) { ss := UniqueStrings(10, 50) + sort.Strings(ss) for i := 1; i < len(ss); i++ { if ss[i-1] == ss[i] { t.Fatalf("ss[i-1] %q == ss[i] %q", ss[i-1], ss[i]) } } - fmt.Println(ss) }