Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18373 from redwrasse/redwrasse/wait-time-leq

Browse Source 
Fix wait time docs, tests to indicate trigger deadline geq to wait deadline.
This commit is contained in:
Benjamin Wang 2024-07-30 08:30:48 +01:00 committed by GitHub
commit f181ced1ca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/wait/wait_time.go
View File

@ -19,9 +19,9 @@ import "sync"
type WaitTime interface { type WaitTime interface {
// Wait returns a chan that waits on the given logical deadline. // Wait returns a chan that waits on the given logical deadline.
// The chan will be triggered when Trigger is called with a // The chan will be triggered when Trigger is called with a
// deadline that is later than the one it is waiting for. // deadline that is later than or equal to the one it is waiting for.
Wait(deadline uint64) <-chan struct{} Wait(deadline uint64) <-chan struct{}
// Trigger triggers all the waiting chans with an earlier logical deadline. // Trigger triggers all the waiting chans with an equal or earlier logical deadline.
Trigger(deadline uint64) Trigger(deadline uint64)
} }

8
pkg/wait/wait_time_test.go
View File

@ -54,10 +54,10 @@ func TestWaitTime(t *testing.T) {
func TestWaitTestStress(t *testing.T) { func TestWaitTestStress(t *testing.T) {
chs := make([]<-chan struct{}, 0) chs := make([]<-chan struct{}, 0)
wt := NewTimeList() wt := NewTimeList()
for i := 0; i < 10000; i++ { for i := 0; i <= 10000; i++ {
chs = append(chs, wt.Wait(uint64(i))) chs = append(chs, wt.Wait(uint64(i)))
} }
wt.Trigger(10000 + 1) wt.Trigger(10000)
for _, ch := range chs { for _, ch := range chs {
select { select {
@ -78,9 +78,9 @@ func BenchmarkWaitTime(b *testing.B) {
func BenchmarkTriggerAnd10KWaitTime(b *testing.B) { func BenchmarkTriggerAnd10KWaitTime(b *testing.B) {
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
wt := NewTimeList() wt := NewTimeList()
for j := 0; j < 10000; j++ { for j := 0; j <= 10000; j++ {
wt.Wait(uint64(j)) wt.Wait(uint64(j))
} }
wt.Trigger(10000 + 1) wt.Trigger(10000)
} }
} }