*: only print out major.minor version for cluster version

This commit is contained in:
Xiang Li 2015-08-15 08:30:06 -07:00
parent bbcb38189c
commit f199a484af
3 changed files with 17 additions and 5 deletions

View File

@ -31,6 +31,7 @@ import (
"github.com/coreos/etcd/raft" "github.com/coreos/etcd/raft"
"github.com/coreos/etcd/raft/raftpb" "github.com/coreos/etcd/raft/raftpb"
"github.com/coreos/etcd/store" "github.com/coreos/etcd/store"
"github.com/coreos/etcd/version"
) )
const ( const (
@ -358,9 +359,9 @@ func (c *cluster) SetVersion(ver *semver.Version) {
c.Lock() c.Lock()
defer c.Unlock() defer c.Unlock()
if c.version != nil { if c.version != nil {
plog.Noticef("updated the cluster version from %v to %v", c.version.String(), ver.String()) plog.Noticef("updated the cluster version from %v to %v", version.Cluster(c.version.String()), version.Cluster(ver.String()))
} else { } else {
plog.Noticef("set the initial cluster version to %v", ver.String()) plog.Noticef("set the initial cluster version to %v", version.Cluster(ver.String()))
} }
c.version = ver c.version = ver
} }

View File

@ -361,7 +361,7 @@ func (s *EtcdServer) start() {
s.done = make(chan struct{}) s.done = make(chan struct{})
s.stop = make(chan struct{}) s.stop = make(chan struct{})
if s.ClusterVersion() != nil { if s.ClusterVersion() != nil {
plog.Infof("starting server... [version: %v, cluster version: %v]", version.Version, s.ClusterVersion()) plog.Infof("starting server... [version: %v, cluster version: %v]", version.Version, version.Cluster(s.ClusterVersion().String()))
} else { } else {
plog.Infof("starting server... [version: %v, cluster version: to_be_decided]", version.Version) plog.Infof("starting server... [version: %v, cluster version: to_be_decided]", version.Version)
} }
@ -991,9 +991,9 @@ func (s *EtcdServer) monitorVersions() {
func (s *EtcdServer) updateClusterVersion(ver string) { func (s *EtcdServer) updateClusterVersion(ver string) {
if s.cluster.Version() == nil { if s.cluster.Version() == nil {
plog.Infof("setting up the initial cluster version to %v", ver) plog.Infof("setting up the initial cluster version to %s", version.Cluster(ver))
} else { } else {
plog.Infof("updating the cluster version from %v to %v", s.cluster.Version(), ver) plog.Infof("updating the cluster version from %s to %s", version.Cluster(s.cluster.Version().String()), version.Cluster(ver))
} }
req := pb.Request{ req := pb.Request{
Method: "PUT", Method: "PUT",

View File

@ -15,8 +15,10 @@
package version package version
import ( import (
"fmt"
"os" "os"
"path" "path"
"strings"
"github.com/coreos/etcd/pkg/fileutil" "github.com/coreos/etcd/pkg/fileutil"
"github.com/coreos/etcd/pkg/types" "github.com/coreos/etcd/pkg/types"
@ -76,3 +78,12 @@ func DetectDataDir(dirpath string) (DataDirVersion, error) {
} }
return DataDirUnknown, nil return DataDirUnknown, nil
} }
// Cluster only keeps the major.minor.
func Cluster(v string) string {
vs := strings.Split(v, ".")
if len(vs) <= 2 {
return v
}
return fmt.Sprintf("%s.%s", vs[0], vs[1])
}