Merge pull request #17675 from callthingsoff/simplify_testutil_assert

client/pkg/testutil: eliminate copyToInterface function
This commit is contained in:
Marek Siarkowicz 2024-04-02 09:44:01 +02:00 committed by GitHub
commit f611da66d8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -20,14 +20,6 @@ import (
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
) )
func copyToInterface(msg ...string) []any {
newMsg := make([]any, len(msg))
for i, v := range msg {
newMsg[i] = v
}
return newMsg
}
func AssertNil(t *testing.T, v any) { func AssertNil(t *testing.T, v any) {
t.Helper() t.Helper()
assert.Nil(t, v) assert.Nil(t, v)
@ -42,12 +34,10 @@ func AssertNotNil(t *testing.T, v any) {
func AssertTrue(t *testing.T, v bool, msg ...string) { func AssertTrue(t *testing.T, v bool, msg ...string) {
t.Helper() t.Helper()
newMsg := copyToInterface(msg...) assert.Equal(t, true, v, msg)
assert.Equal(t, true, v, newMsg)
} }
func AssertFalse(t *testing.T, v bool, msg ...string) { func AssertFalse(t *testing.T, v bool, msg ...string) {
t.Helper() t.Helper()
newMsg := copyToInterface(msg...) assert.Equal(t, false, v, msg)
assert.Equal(t, false, v, newMsg)
} }