From f8b98d3925d4d96d26aee9b87f1b5aa7263ccc10 Mon Sep 17 00:00:00 2001 From: Xiang Li Date: Fri, 25 Sep 2015 15:06:51 -0700 Subject: [PATCH] etcdhttp: add Content-Type: application/json header to version handler --- etcdserver/etcdhttp/client.go | 1 + etcdserver/etcdhttp/client_test.go | 3 +++ 2 files changed, 4 insertions(+) diff --git a/etcdserver/etcdhttp/client.go b/etcdserver/etcdhttp/client.go index 64963798f..314a9fb41 100644 --- a/etcdserver/etcdhttp/client.go +++ b/etcdserver/etcdhttp/client.go @@ -381,6 +381,7 @@ func serveVersion(w http.ResponseWriter, r *http.Request, clusterV string) { Cluster: clusterV, } + w.Header().Set("Content-Type", "application/json") b, err := json.Marshal(&vs) if err != nil { plog.Panicf("cannot marshal versions to json (%v)", err) diff --git a/etcdserver/etcdhttp/client_test.go b/etcdserver/etcdhttp/client_test.go index c048bb42b..2d3e2c1b6 100644 --- a/etcdserver/etcdhttp/client_test.go +++ b/etcdserver/etcdhttp/client_test.go @@ -1341,6 +1341,9 @@ func TestServeVersion(t *testing.T) { if g := rw.Body.String(); g != string(w) { t.Fatalf("body = %q, want %q", g, string(w)) } + if ct := rw.HeaderMap.Get("Content-Type"); ct != "application/json" { + t.Errorf("contet-type header = %s, want %s", ct, "application/json") + } } func TestServeVersionFails(t *testing.T) {