177 Commits

Author SHA1 Message Date
redwrasse
ecc2c5e471 client modules: remaining errors.Is conversions for error equality and inequality checks.
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-09-22 17:43:01 -07:00
Benjamin Wang
2f9532bfca
Merge pull request #18608 from srivastav-abhishek/periodic-compaction-flake-fix
Fixed periodic compaction tests
2024-09-22 09:17:13 +01:00
Marek Siarkowicz
1820d3b7d5
Merge pull request #18510 from redwrasse/redwrasse/errors-is
Use errors.Is for error equality checks
2024-09-20 09:02:40 +02:00
Joshua Zhang
b8cb654be6 Use strict synchronization for revision getter to minimize flaky result caused by time racing.
Signed-off-by: Joshua Zhang <joshuazh@microsoft.com>

Addressed review comments

Co-authored-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
Signed-off-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com>
2024-09-19 17:34:24 +05:30
Chun-Hung Tseng
14d54893e0 dependency: bump golang.org/x/crypto from 0.26.0 to 0.27.0
golang.org/x/sys and golang.org/x/text version inconsistency are also
addressed:
- bump golang.org/x/sys from 0.24.0 to 0.25.0
- bump golang.org/x/text from 0.17.0 to 0.18.0

Reference:
- https://github.com/etcd-io/etcd/pull/18563
- https://github.com/etcd-io/etcd/pull/18558
- https://github.com/etcd-io/etcd/pull/18566
- https://github.com/etcd-io/etcd/pull/18565

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-14 22:29:31 +02:00
Chun-Hung Tseng
29f3bc2222
Bump go toolchain to 1.22.7
Reference:
- https://github.com/etcd-io/etcd/issues/18443
- https://github.com/etcd-io/etcd/issues/18548#issuecomment-2343061825

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-09-11 15:32:52 +02:00
redwrasse
d4df7a902e Replaces a number of error equality checks with errors.Is
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-09-03 16:02:24 -07:00
Chun-Hung Tseng
6208673ebf
dependency: bump golang.org/x/sys from 0.23.0 to 0.24.0
Reference:
- https://github.com/etcd-io/etcd/pull/18426
- https://github.com/etcd-io/etcd/pull/18425

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-09 10:17:01 +02:00
Benjamin Wang
9c187ef337
Merge pull request #18420 from henrybear327/go/1.22.6
go version bump from 1.22.5 to 1.22.6
2024-08-08 22:02:17 +01:00
Chun-Hung Tseng
794d1b64f7
go version bump from 1.22.5 to 1.22.6
Reference: https://github.com/etcd-io/etcd/issues/18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-08 21:30:09 +02:00
Chun-Hung Tseng
f071fde896
dependency: bump golang.org/x/sys from 0.22.0 to 0.23.0
Reference:
- https://github.com/etcd-io/etcd/pull/18406

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-08-08 21:24:07 +02:00
ArkaSaha30
984100b3a6
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.20.0 to 2.21.0
This commit will bump dependency bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.20.0 to 2.21.0 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-07-31 14:16:18 +05:30
James Blair
b433760ca7
Merge pull request #17564 from redwrasse/redwrasse/purge-fnames-logic
fileutil: improve control flow readability of purgeFile function
2024-07-15 20:47:58 +12:00
ArkaSaha30
3dda3b849b
dependency: bump golang.org/x/sys from 0.21.0 to 0.22.0
This commit will bump dependency golang.org/x/sys from 0.21.0 to 0.22.0 raised by dependabot.

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-07-10 23:46:20 +05:30
Wei Fu
ccaea7edae client/pkg/testutil: update interestingGoroutines
The Go runtime uses runtime Finalizer to delete cert [[1]]. The
interestingGoroutines is able to collect stack like,

```plain
leak.go:103: Found leaked goroutined BEFORE test appears to have leaked :
        sync.(*Map).LoadAndDelete(0xc00031e180, {0xe07320, 0xc00009fde0})
                /usr/local/go/src/sync/map.go:272 +0x192
        sync.(*Map).Delete(...)
                /usr/local/go/src/sync/map.go:297
        crypto/tls.(*certCache).evict(...)
                /usr/local/go/src/crypto/tls/cache.go:73
        crypto/tls.(*certCache).active.func1(0x0?)
                /usr/local/go/src/crypto/tls/cache.go:65 +0x67
```

It's caused by GC instead of leaky goroutine. interestingGoroutines
should skip it.

[1]: 8e1fdea831/src/crypto/tls/cache.go (L63)

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-07-05 22:24:37 +08:00
D Tripp
8f974669c5 Bump Go version to 1.22.5: GO-2024-2963 fix.
Signed-off-by: D Tripp <38776199+thedtripp@users.noreply.github.com>
2024-07-03 05:07:03 +00:00
redwrasse
c26156d080 move fileutil.readDirWithSuffix to normal function
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-06-29 22:16:13 -07:00
redwrasse
854010f412 fileutil: improve control flow readability of purgeFile function
Signed-off-by: redwrasse <mail@redwrasse.io>
2024-06-29 22:16:13 -07:00
Mason Chen
7dec366acd etcdclient: Clena up unnecessary nil Logger check
Clean up unnecessary nil Logger for listener.go as pointed out in issue
#18084

Signed-off-by: Mason Chen <mason.yunchen@gmail.com>
2024-06-28 20:11:44 +12:00
Ivan Valdes
4f13e7c2b7
dependency(client): bump golang.org/x/sys from v0.19.0 to v0.21.0
Ensure that golang.org/x/sys is at the same version across the modules
from the project.

Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-06-19 09:02:17 -07:00
Marek Siarkowicz
75ad7a82f2
Merge pull request #18108 from chaochn47/fix-ts-with-no-trailing-zeros
fix ts with no trailing zeros
2024-06-07 10:12:31 +02:00
Chao Chen
7211d9fb94 fix ts with no trailing zeros
Signed-off-by: Chao Chen <chaochn@amazon.com>
2024-06-06 17:20:37 -07:00
lhy1024
acc9d7c9fe Support multiple values for allowed client and peer TLS identities
Signed-off-by: lhy1024 <admin@liudos.us>
2024-06-06 21:25:17 +08:00
ArkaSaha30
2089857ab8
Bump Go version to 1.22.4: CVE 2024-24790 fix
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-06-05 14:12:52 +05:30
Edwin Xie
4c77726914 Implement flag --experimental-set-member-localaddr
Which sets the LocalAddr to an IP address from --initial-advertise-peer-urls.

Also adds e2e test that requires this flag to succeed.

Co-authored-by: HighPon <s.shiraki.business@gmail.com>
Signed-off-by: Edwin Xie <edwin.xie@broadcom.com>
2024-05-24 18:17:37 +00:00
Lavish pal
6038f391f1 Upgrade go to 1.22.3.
Signed-off-by: Lavish pal <lvishpal408@gmail.com>
2024-05-10 03:27:35 +05:30
Madhav Jivrajani
f6a35f8786 .*: sync go toolchain version and add ability to verify versions
This commit adds a script to sync the version present in .go-version
across all go.mod files as the toolchain directive. As part of that,
this commit also modifies go.mod files that did not have synced toolchain
directives.

Additionally, this also adds a script to verify all toolchain and go
directives against the version present in .go-version as follows:
(1) The go directive <= version in .go-version
(2) The toolchain directive == version in .go-version

This script runs as part of the `make verify` target, making it run
as a presbumit by default.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-05-07 17:52:56 +05:30
Jes Cok
dafadd13c1 all: don't convert byte slice to string when using verb %s
This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2024-04-25 23:34:52 +08:00
Sharath Sivakumar
9e938abd91
dependency: bump golang.org/x/net from 0.23.0 to 0.24.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-04-21 23:14:29 +02:00
Marek Siarkowicz
f611da66d8
Merge pull request #17675 from callthingsoff/simplify_testutil_assert
client/pkg/testutil: eliminate copyToInterface function
2024-04-02 09:44:01 +02:00
Jes Cok
06b50370fa client/pkg/testutil: add shouldSkip func for interestingGoroutines
interestingGoroutines uses so many strings.Contains checks to determine
whether to continue, I think it can be avoided.

This patch introduces shouldSkip func to do the checks in a loop
to make the logic clearer.

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2024-03-31 23:37:30 +08:00
Jes Cok
229ceb3a73 client/pkg/testutil: eliminate copyToInterface function
AssertTrue and AssertFalse use copyToInterface to copy msg. This is
unnecessary, cause we know the msgAndArgs param of assert.Equal is
variadic:
func Equal(t TestingT, expected, actual interface{}, msgAndArgs ...interface{}) bool

This patch removes copyToInterface function, and use msg directly.

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2024-03-30 23:59:07 +08:00
Jes Cok
f3daf5e041 all: make regexp.Regexp variables global when not using configuration methods
As the doc of regexp.Regex is saying:

"A Regexp is safe for concurrent use by multiple goroutines, except for configuration
methods, such as Regexp.Longest."

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2024-03-26 18:49:50 +08:00
James Blair
7b7e2e29da
dependency: bump go.uber.org/zap from 1.26.0 to 1.27.0.
Signed-off-by: James Blair <mail@jamesblair.net>
2024-03-22 01:41:57 +13:00
Benjamin Wang
d639abe1aa
Merge pull request #17582 from ivanvc/address-client-var-naming-lint-rule
client: address golangci var-naming issues
2024-03-15 09:03:15 +00:00
Ivan Valdes
578b784dcd
client: address golangci var-naming issues
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-14 20:47:32 -07:00
Ivan Valdes
0024569c7c
dependency: bump github.com/stretchr/testify from 1.8.4 to 1.9.0
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-11 11:50:27 -07:00
Ivan Valdes
9f5671d113
dependency: bump golang.org/x/sys from 0.17.0 to 0.18.0
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-03-11 11:48:03 -07:00
Allen Ray
bb4b70bbb2 Migrate to go1.22
Signed-off-by: Allen Ray <alray@redhat.com>
2024-03-06 17:15:36 -05:00
Benjamin Wang
5c1b43c079 Dependency: bump golang.org/x/sys from 0.16.0 to 0.17.0
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-02-13 09:32:55 +00:00
Benjamin Wang
cf7043391c
Merge pull request #15812 from tangruize/main
etcd: ignore SetKeepAlivePeriod errors on OpenBSD
2024-02-06 13:05:56 +00:00
Sharath Sivakumar
98646057d6
dependency: bump golang.org/x/sys from 0.15.0 to 0.16.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-01-09 16:04:19 +01:00
Marek Siarkowicz
a2eb17c809
Merge pull request #17199 from serathius/dont-flock
Don't flock snapshot files
2024-01-08 15:03:29 +01:00
Marek Siarkowicz
7f8346b3f2 Don't flock snapshot files
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-01-04 14:53:44 +01:00
Ivan Valdes
e9434c9455
client: implement TLS CRL tests
Signed-off-by: Ivan Valdes <ivan@vald.es>
2023-12-23 09:23:17 -08:00
Benjamin Wang
16d1ef949c
replace the deprecated x509.ParseCRL with x509.ParseRevocationList
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-12-12 14:47:49 -08:00
vivekpatani
2afd2ddee5 *: bump golang.org/x/sys to 0.15.0
- https://github.com/etcd-io/etcd/pull/17029

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-30 10:13:29 -08:00
Benjamin Wang
f64689f4e2
Update copyright header in sockopt_wasm.go
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-11-21 16:27:22 +00:00
Icemap
c48738e33f fix: add js platform
Signed-off-by: Icemap <qizhi.wang@pingcap.com>

Signed-off-by: Icemap <qizhi.wang@pingcap.com>
2023-11-11 10:18:34 +08:00
Icemap
1cecf35b24 feat: add wasm for client transport
Signed-off-by: Icemap <qizhi.wang@pingcap.com>
2023-11-11 10:18:34 +08:00