Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
18,615 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

354 Commits

Author SHA1 Message Date
Marek Siarkowicz
f215cd89d2
Merge pull request #14612 from spacewander/azq 
chore: commit the change generated by scripts/genproto.sh
 2022-10-24 20:00:52 +02:00
spacewander
3a63a0d5e3 chore: commit the change generated by scripts/genproto.sh 
TODO: ensure the generated code is up-to-date in the CI.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
 2022-10-23 21:13:55 +08:00
Samuele Resca
b58f9c27e4 Refactoring code to remove duplicate code test. 
Signed-off-by: Samuele Resca <sr7@ad.datcon.co.uk>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
 2022-10-23 13:46:10 +01:00
Samuele Resca
3d9c5c6166 Adding fuzz test on v3rpc interfaces. 
Signed-off-by: Samuele Resca <sr7@ad.datcon.co.uk>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
 2022-10-23 13:46:10 +01:00
Marek Siarkowicz
2b178fdd96 server: Handle cluster version equal downgrade version 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-10-17 12:05:57 +02:00
Benjamin Wang
1ccdb3762d Test: fix all corruption detection related unit test cases 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-30 06:06:41 +08:00
Benjamin Wang
d116d02e04 etcdserver: update corrupt hash detection's logic 
get peer's hash using the same revision as the value used by leader

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-30 06:03:50 +08:00
Benjamin Wang
1c20ed2cc5
Merge pull request #14521 from lovehhf/remove_pick_peer_url 
membership: Remove PickPeerURL Method
 2022-09-27 02:10:35 +08:00
Hongfei Huang
f6d808736c membership: Remove PickPeerURL Method 
PickPeerURL only used by unit test

Signed-off-by: Hongfei Huang <853885165@qq.com>
 2022-09-26 23:21:10 +08:00
Kafuu Chino
f1d4935e91 *: avoid closing a watch with ID 0 incorrectly 
Signed-off-by: Kafuu Chino <KafuuChinoQ@gmail.com>

add test
 2022-09-26 20:30:33 +08:00
Benjamin Wang
9097e61b40 etcdserve: revert the etcdserver side change for the data loss on one node cluster 
Since the raft side change has been merged, so we need to revert the etcdserver
side change.
Refer to
  https://github.com/etcd-io/etcd/pull/14413
  https://github.com/etcd-io/etcd/pull/14400

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-22 15:19:20 +08:00
Benjamin Wang
7f10dccbaf Bump go 1.19: update all the dependencies and go.sum files 
1. run ./scripts/fix.sh;
2. cd tools/mod; gofmt -w . & go mod tidy;

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-22 08:47:46 +08:00
Marek Siarkowicz
026794495f
Merge pull request #14494 from demoManito/remove/redundant-type-conversion 
etcd: remove redundant type conversion
 2022-09-21 11:34:19 +02:00
Benjamin Wang
2441a24cee
Merge pull request #14493 from demoManito/style/format-import-order 
etcd: format import order
 2022-09-21 06:03:31 +08:00
demoManito
f67ec10779 etcd: format import order 
golang CodeReviewComments:
https://github.com/golang/go/wiki/CodeReviewComments#imports

Signed-off-by: demoManito <1430482733@qq.com>
 2022-09-20 18:41:39 +08:00
demoManito
a9c3d56508 etcd: remove redundant type conversion 
Signed-off-by: demoManito <1430482733@qq.com>
 2022-09-20 11:26:02 +08:00
Benjamin Wang
159ed15afc
Merge pull request #14479 from demoManito/fix/declaring-empty-slice 
etcd: modify declaring empty slices
 2022-09-20 05:22:59 +08:00
Hitoshi Mitake
2dcfa83094 *: handle auth invalid token and old revision errors in watch 
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
 2022-09-17 21:51:36 +09:00
demoManito
72cf0cc04a etcd: modify declaring empty slices 
declare an empty slice to var s []int replace  s :=[]int{}, https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices

Signed-off-by: demoManito <1430482733@qq.com>
 2022-09-16 14:41:14 +08:00
Benjamin Wang
3dc5348d94
Merge pull request #14419 from ahrtr/alarm_list_ci 
Move consistent_index forward when executing alarmList operation
 2022-09-06 03:50:58 +08:00
Benjamin Wang
cc840336f0 move consistent_index forward when executing alarmList operation 
The alarm list is the only exception that doesn't move consistent_index
forward. The reproduction steps are as simple as,

```
etcd --snapshot-count=5 &
for i in {1..6}; do etcdctl  alarm list; done
kill -9 <etcd_pid>
etcd
```

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-05 10:05:55 +08:00
Benjamin Wang
2a10049e47 fix the potential data loss for clusters with only one member 
For a cluster with only one member, the raft always send identical
unstable entries and committed entries to etcdserver, and etcd
responds to the client once it finishes (actually partially) the
applying workflow.

When the client receives the response, it doesn't mean etcd has already
successfully saved the data, including BoltDB and WAL, because:
   1. etcd commits the boltDB transaction periodically instead of on each request;
   2. etcd saves WAL entries in parallel with applying the committed entries.
Accordingly, it may run into a situation of data loss when the etcd crashes
immediately after responding to the client and before the boltDB and WAL
successfully save the data to disk.
Note that this issue can only happen for clusters with only one member.

For clusters with multiple members, it isn't an issue, because etcd will
not commit & apply the data before it being replicated to majority members.
When the client receives the response, it means the data must have been applied.
It further means the data must have been committed.
Note: for clusters with multiple members, the raft will never send identical
unstable entries and committed entries to etcdserver.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-08-30 15:29:20 +08:00
spacewander
508ce517e0 update according to the review 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
 2022-08-17 09:25:37 +08:00
spacewander
bebefd8b80 chore: log when an invalid watch request is received 
As protobuf doesn't have required field, user may send an empty
WatchRequest by mistake. Currently, etcd will ignore the invalid request
and keep the stream opening. If we don't reject the invalid request by
closing the stream, it would be better to leave a log there.

This commit also fixes a typo in the comment.

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
 2022-08-16 11:33:01 +08:00
Benjamin Wang
fff5d00ccf
Merge pull request #14149 from lavacat/main-txn-panic 
server: don't panic in readonly serializable txn
 2022-08-14 05:41:57 +08:00
Bogdan Kanivets
43bb9d5c22 server: don't panic in readonly serializable txn 
Problem: We pass grpc context down to applier in readonly serializable txn.
This context can be cancelled for example due to timeout.
This will trigger panic inside applyTxn

Solution: Only panic for transactions with write operations

fixes https://github.com/etcd-io/etcd/issues/14110

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
 2022-08-09 00:46:50 -07:00
Benjamin Wang
649babaf4a
Merge pull request #14276 from yuzhiquan/add-alarm-metrics 
Add alarms metrics for server
 2022-08-09 05:06:35 +08:00
yuzhiquanlong
4c13767881 etcdserver: add alarms metrics for server 
Signed-off-by: yuzhiquanlong <yuzhiquanlong@gmail.com>
 2022-08-03 09:33:02 +08:00
Benjamin Wang
ae36a577d7
Merge pull request #14286 from VladSaioc/bugfix-goroutine-leak 
Fixed goroutine leak in server/etcdserver/raft_test.go
 2022-08-03 06:02:54 +08:00
VladSaioc
6cded3d94c Fixed goroutine leak in server/etcdserver/raft_test.go 
Signed-off-by: VladSaioc <vladsaioc10@gmail.com>
 2022-08-02 23:22:55 +02:00
Benjamin Wang
4f0e92d94c
Merge pull request #14262 from mind1949/update-server-etcdserver-raft 
server/etcdserver: check whether raftNode has stopped
 2022-08-02 05:58:30 +08:00
Austin Benoit
ff56da7745 rafthttp: test transport multiple transport removes 
Unit test to verify multiple transport removes does not create an
  issue.

Signed-off-by: Austin Benoit <22805659+AustinBenoit@users.noreply.github.com>
 2022-07-28 18:23:17 -04:00
Marek Siarkowicz
bb7e4653c8 tests: Fix member id in CORRUPT alarm 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-07-26 15:55:22 +02:00
Marek Siarkowicz
d44bbff278 server: Make corrtuption check optional and period configurable 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-07-26 09:31:15 +02:00
Marek Siarkowicz
6697fca97d server: Implement compaction hash checking 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-07-26 09:31:14 +02:00
mind1949
f3bd535747 server/etcdserver: fix test 
Signed-off-by: mind1949 <lianjie1949@gmail.com>
 2022-07-25 23:20:21 +08:00
Marek Siarkowicz
c58ec9fe13 server: Refactor compaction checker 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-07-25 13:59:30 +02:00
mind1949
2b0596f859 server/etcdserver: check if raftNode has been stopped 
Signed-off-by: mind1949 <lianjie1949@gmail.com>
 2022-07-23 08:49:07 +08:00
杨金珏
6220174687 support custom grpc.MaxConcurrentStreams 
There is no update on the original PR (see below) for more then 2
weeks. So Benjamin(@ahrtr) continues to work on the PR. The first
step is to rebase the PR, because there are lots of conflicts with
the main branch.

The change to go.mod and go.sum reverted, because they are not needed.
The e2e test cases are also reverted, because they are not correct.

```
https://github.com/etcd-io/etcd/pull/14081
```

Signed-off-by: nic-chen <chenjunxu6@gmail.com>
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-07-06 03:43:46 +08:00
SimFG
107b7c06ab sanp: Delete the nil judgment of the log object 
Move some methods into the `Snapshotter` object for removing the `lg == nil` judgment

Signed-off-by: SimFG <1142838399@qq.com>
 2022-06-28 19:35:33 +08:00
chavacava
756d77663b removes empty option in JSON tag 
option can not be empty in JSON tag

Signed-off-by: chavacava <salvadorcavadini+github@gmail.com>
 2022-06-26 12:13:20 +02:00
Tsonglew
e5a80f5049
fix: typo gouroutine 
fix: typo gouroutine
 2022-06-16 16:35:06 +08:00
Piotr Tabor
e61d431792
Merge pull request #14109 from SimFG/fifo_panic 
schedule: Provide logs when the fifo job panic happens
 2022-06-15 22:24:42 +02:00
L2ncE
637afd359b Fix a syntax error in a code comment 
Signed-off-by: L2ncE <llance_24@foxmail.com>
 2022-06-15 23:19:12 +08:00
SimFG
d83925e357 schedule: Provide logs when the fifo job panic happens 
To make the fifo scheduler better debuggability.

Signed-off-by: SimFG <1142838399@qq.com>
 2022-06-15 20:58:17 +08:00
Marek Siarkowicz
2c12954158
Merge pull request #14049 from serathius/compact-hash 
Calculate hash during compaction
 2022-06-14 11:10:19 +02:00
Marek Siarkowicz
f5eadf5452 tests: Add tests for HashByRev HTTP API 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-06-13 18:20:19 +02:00
Marek Siarkowicz
0e739da9a4 server: Cache compaction hash for HashByRev API 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-06-13 18:20:18 +02:00
Marek Siarkowicz
2b090e86a6 server: Extract hasher to separate interface 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-06-13 18:20:18 +02:00
Marek Siarkowicz
80828b593a server: Remove duplicated compaction revision 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-06-13 18:20:18 +02:00