Piotr Tabor
1c401581e3
Close channel of started servers even if embed server fails to start.
...
Before this change:
```
gwmux, err = sctx.registerGateway([]grpc.DialOption{grpc.WithInsecure()})
if err != nil { return err; }
```
caused the Etcd.Serve() method finish without sctx.serversC channel being closed.
The code closing Etcd got stuck waiting for all the servers to be running.
Signed-off-by: Piotr Tabor <ptab@google.com >
2022-06-15 13:50:17 +02:00
Piotr Tabor
fcc8fce4d2
Expand logging in case of embed server not being able to successfully start.
...
So far the errors were directed to Etcd.Errc (channel) that is not being consumed in practice.
Signed-off-by: Piotr Tabor <ptab@google.com >
2022-06-15 13:50:17 +02:00
Dirc
ba405f64c1
Update link to tuning page
2022-06-08 10:16:04 +02:00
Piotr Tabor
651de5a057
Rename EtcdServer.Id with EtcdServer.MemberId.
...
It was misleading and error prone vs. ClusterId.
2022-05-20 14:32:04 +02:00
Marek Siarkowicz
26f42e7a9e
server: Apply review comments and split basic handler
2022-05-05 09:52:14 +02:00
Marek Siarkowicz
722ec487df
server: Split metrics and health code
2022-05-05 09:52:14 +02:00
Marek Siarkowicz
600ee13ac0
server: Cover V3 health with tests
2022-05-05 09:52:14 +02:00
Tony Abboud
1d13e0733c
Fix logger spelling in NewZapLoggerBuilder godoc
...
Just a small docs fix that I happened to notice when setting up a new zap logger for etcd
2022-04-22 12:08:54 -04:00
ahrtr
1a3822f2c3
Rename ClientConfig to ConfigSpec
...
The ClientConfig is a fully declarive configuration, so it makes more
sense to rename it to ConfigSpec. It can also mitigate the confusion
between Config and ClientConfig.
2022-03-13 05:41:49 +08:00
ahrtr
3dcbbf62d9
Move clientconfig into clientv3 so that it can be reused by both etcdctl and v3 discovery
2022-03-12 06:38:41 +08:00
ahrtr
d578a86a59
fix some log format typos
2022-03-10 03:26:34 +08:00
Piotr Tabor
088807c08e
Merge pull request #13565 from ahrtr/remove_peer_serve_client_requests
...
Updated servePeers to remove the grpc server
2022-03-01 16:24:42 +01:00
ahrtr
2f36e0c62b
Change discovery url to endpoints
...
Currently the discovery url is just one endpoint. But actually it
should be the same as the etcdctl, which means that it should be
a list of endpoints. When one endpoint is down, the clientv3 can
fail over to the next endpoint automatically.
2022-02-24 09:11:41 +08:00
Marek Siarkowicz
b5e224db7d
Merge pull request #13635 from ahrtr/v3_discovery
...
support v3 discovery to bootstrap a new etcd cluster
2022-02-21 21:50:40 +01:00
Piotr Tabor
f80f477073
Merge pull request #13644 from Juneezee/refactor/t.TempDir
...
*: use `T.TempDir` to create temporary test directory
2022-02-21 19:52:37 +01:00
ahrtr
ebc86d12c0
support v3 discovery to bootstrap a new etcd cluster
2022-02-21 23:22:49 +08:00
ahrtr
a879ccf152
updated servePeers to remvoe the grpc server
2022-01-27 16:22:01 +08:00
ahrtr
1713dc67b5
etcd server shouldn't wait for the ready notification infinitely on startup
2022-01-27 16:19:20 +08:00
Eng Zer Jun
e9edc5432c
*: use T.TempDir to create temporary test directory
...
The directory created by `T.TempDir()` and is automatically removed when
the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2022-01-25 00:00:46 +08:00
Marek Siarkowicz
ee5ef42c5c
server: --enable-v2 and --enable-v2v3 is decomissioned
2022-01-14 13:19:30 +01:00
Marek Siarkowicz
7d10899d7f
server: Require either cluster version v3.6 or --experimental-enable-lease-checkpoint-persist to persist lease remainingTTL
...
To avoid inconsistant behavior during cluster upgrade we are feature
gating persistance behind cluster version. This should ensure that
all cluster members are upgraded to v3.6 before changing behavior.
To allow backporting this fix to v3.5 we are also introducing flag
--experimental-enable-lease-checkpoint-persist that will allow for
smooth upgrade in v3.5 clusters with this feature enabled.
2021-12-02 12:26:47 +01:00
Sam Batschelet
63a1cc3fe4
add --experimental-max-learner flag
...
Signed-off-by: Sam Batschelet <sbatsche@redhat.com >
2021-11-09 09:52:00 -05:00
Eng Zer Jun
2a151c8982
*: move from io/ioutil to io and os packages
...
The io/ioutil package has been deprecated as of Go 1.16, see
https://golang.org/doc/go1.16#ioutil . This commit replaces the existing
io/ioutil functions with their new definitions in io and os packages.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2021-10-28 00:05:28 +08:00
Piotr Tabor
8aa6ae9bbb
Merge pull request #13361 from vooon/otel-1.0.0
...
server: update OpenTelemetry to 1.0.1
2021-10-20 14:14:00 +02:00
Vladimir Ermakov
4f4b12d521
server: update OpenTelemetry to 1.0.1
...
Update API of the OpenTelemetry library and updates gRPC to 1.41.0.
Fixes #13141
Signed-off-by: Vladimir Ermakov <vooon341@gmail.com >
2021-10-13 13:51:58 +03:00
Arda Güçlü
d7fa8022e6
Merge branch 'main' into support-zap-console-encoding
2021-10-08 11:00:57 +03:00
Marek Siarkowicz
90932324b1
client: Add grpc authority header integration tests
2021-09-29 12:42:16 +02:00
Arda Güçlü
ec252d06c9
Return error when log-format is invalid
2021-09-22 19:45:08 +03:00
Arda Güçlü
e647995a38
Add zap encoding configurable
...
Json encoding is the default zap encoding value and can not be changeable.
This PR enables configuring zap encoding to console via new flag `log-format`.
2021-09-22 15:48:47 +03:00
Sam Batschelet
a4a82cc982
Merge pull request #13248 from lilic/add-sampling-rate
...
server: Add sampling rate to distributed tracing
2021-08-30 08:31:00 -04:00
Lili Cosic
810f489017
server: Add sampling rate to distributed tracing
...
ExperimentalDistributedTracingSamplingRatePerMillion is the
number of samples to collect per million spans.
Defaults to 0.
2021-08-30 13:55:35 +02:00
Marek Siarkowicz
83a325ac46
server: Move all functions needed for storage bootstrap to storage package
...
This is prerequestite to move storage bootstrap, splitted to separate PR
to make it easier to review.
2021-08-03 13:09:15 +02:00
Marek Siarkowicz
44b8ae145b
etcdserver: Move datadir and wal to storage package
2021-08-03 12:47:37 +02:00
Sahdev Zala
2526463e44
Merge pull request #13236 from roytman/expensiveRequest
...
etcdserver: configure "expensive" requests duration
2021-08-02 09:33:43 -04:00
tangcong
8a3c43827b
fix self-signed-cert-validity parameter cannot be specified in the config file
2021-07-29 00:13:13 +08:00
Alexey Roytman
2a26f7ae4c
etcdserver: configure "expensive" requests duration
...
When a unary request takes more than predefined duration, this request
is defined as "expensive" and a warning is printed. The expensive request
duration is hard-coded to 300 ms. It can be not enough for example
for transactions with a lot of operations. The warnings just blow up
the log files and reduce throughput.
This fix allows user to configure the "expensive" request duration.
Signed-off-by: Alexey Roytman <roytman@il.ibm.com >
2021-07-27 08:33:44 +03:00
Gyuho Lee
56678038b5
Merge pull request #13077 from spacewander/grpc-gateway
...
embed: unlimit the recv msg size of grpc-gateway
2021-06-10 10:25:15 -07:00
spacewander
576861e617
embed: unlimit the recv msg size of grpc-gateway
...
Ensure the client which access etcd via grpc-gateway won't
be limited by the MaxCallRecvMsgSize. Here we choose the same
default value of etcdcli as grpc-gateway's MaxCallRecvMsgSize.
Fix https://github.com/etcd-io/etcd/issues/12576
2021-06-03 16:36:19 +08:00
Mr-Mu
0e496ca212
TestLogRotation add log output relative path
...
TestLogRotation add test log output relative path test
2021-05-27 22:49:41 +08:00
Mr-Mu
24d8e90dbc
[Fix]滚动日志路径解析不正确
...
例如 rotate:test.log 路径解析不正确
2021-05-27 16:44:12 +08:00
Sahdev Zala
05674c87fb
Merge pull request #13018 from ipixiu/feature/bolt-compaction-sleep-interval
...
add bolt compaction sleep interval
2021-05-25 10:06:47 -04:00
AlexStocks
184b0e5d49
add sleep interval
2021-05-24 16:22:00 +08:00
Pavan BG
d9c5e1f0a2
*: Replace internal testutil AssertEqual function in favour of github.com/stretchr/testify/assert.Equals
...
To maintain uniformity in testing methodology, assert.Equals has been used everywhere while replacing testutil.AssertEqual
Fixes #13015
2021-05-20 19:55:45 +05:30
Lili Cosic
7957f4461d
server/embed/config_test.go: Add unit test for socket options
2021-05-20 10:00:27 +02:00
Lili Cosic
73c530de83
client,server: Expose reuse-port and reuse-address so they can be
...
configured via a config file.
2021-05-19 18:41:21 +02:00
Piotr Tabor
f82b5cb776
Bring back original NewZapCoreLoggerBuilder api. ( #12973 )
...
The funcion signature has been changed in:
eafbc8c57e .
Instead we should have added new method `NewZapLoggerBuilder()`.
2021-05-16 10:26:10 -07:00
Piotr Tabor
85341e08f2
Merge pull request #12968 from serathius/logger-simplify
...
server: Simplify passing logger setup by passing only logger
2021-05-15 15:58:00 +02:00
Marek Siarkowicz
41ed74824e
server: Simplify passing logger setup by passing only logger
2021-05-14 13:14:48 +02:00
Piotr Tabor
ead81df948
Disallow -v2-deprecation>'not-yet' combined with --enable-v2
2021-05-12 18:09:34 +02:00
Piotr Tabor
7c508741b3
Adding --v2-deprecation flag.
2021-05-12 18:09:34 +02:00