Chao Chen
2c46b2b299
externalize snapshot catchup entries to etcd flag
...
Signed-off-by: Chao Chen <chaochn@amazon.com >
2023-01-04 19:01:07 -08:00
Piotr Tabor
9abc895122
Goimports: Apply automated fixing to test files as well.
...
Signed-off-by: Piotr Tabor <ptab@google.com >
2022-12-29 13:04:45 +01:00
Piotr Tabor
6f899a7b40
Merge pull request #15052 from ptabor/20221228-goimports-fix
...
./scripts/fix.sh: Takes care of goimports across the whole project.
2022-12-29 11:31:22 +01:00
Piotr Tabor
9e1abbab6e
Fix goimports in all existing files. Execution of ./scripts/fix.sh
...
Signed-off-by: Piotr Tabor <ptab@google.com >
2022-12-29 09:41:31 +01:00
Wei Fu
4d0b91947e
chore: delete // +build buildtag by go fix
...
Signed-off-by: Wei Fu <fuweid89@gmail.com >
2022-12-29 14:17:05 +08:00
Bogdan Kanivets
7e8ebf7727
server: added duplicate warning-unary-request-duration flag
...
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.
fixes https://github.com/etcd-io/etcd/issues/13783
Signed-off-by: Bogdan Kanivets <bkanivets@apple.com >
2022-11-18 18:06:00 +08:00
nic-chen
6f6275e1ab
chore: update the warn message on startup when the server name is default
...
Signed-off-by: nic-chen <chenjunxu6@gmail.com >
2022-10-28 20:56:45 +08:00
nic-chen
191fb306ef
fix: apply review suggestion
...
Signed-off-by: nic-chen <chenjunxu6@gmail.com >
2022-10-27 08:23:22 +08:00
Benjamin Wang
b48641e5f2
Merge pull request #14348 from VinozzZ/add-integration-test-for-tracing
...
embed: add integration test for distributed tracing
2022-10-13 02:11:59 +08:00
Benjamin Wang
5746d6eb86
etcdserver: added more debug log for the purgeFile goroutine
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-10-12 17:32:33 +08:00
demoManito
a9c3d56508
etcd: remove redundant type conversion
...
Signed-off-by: demoManito <1430482733@qq.com >
2022-09-20 11:26:02 +08:00
Benjamin Wang
159ed15afc
Merge pull request #14479 from demoManito/fix/declaring-empty-slice
...
etcd: modify declaring empty slices
2022-09-20 05:22:59 +08:00
demoManito
72cf0cc04a
etcd: modify declaring empty slices
...
declare an empty slice to var s []int replace s :=[]int{}, https://github.com/golang/go/wiki/CodeReviewComments#declaring-empty-slices
Signed-off-by: demoManito <1430482733@qq.com >
2022-09-16 14:41:14 +08:00
Yingrong Zhao
57206f9dfb
shutdown tracer provider first
...
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com >
2022-09-06 11:26:31 -04:00
Allen Ray
c52108942b
Merge branch 'main' into main
2022-08-29 12:07:27 -04:00
Yingrong Zhao
1869fa9db2
have the tracingExporter to own resources it initializes
...
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com >
2022-08-19 11:31:52 -04:00
Benjamin Wang
74506738b8
Refactor the keepAliveListener and keepAliveConn
...
Only `net.TCPConn` supports `SetKeepAlive` and `SetKeepAlivePeriod`
by default, so if you want to warp multiple layers of net.Listener,
the `keepaliveListener` should be the one which is closest to the
original `net.Listener` implementation, namely `TCPListener`.
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-08-18 04:24:05 +08:00
Sam Batschelet
76a5902efa
server/etcdmain: add configurable cipher list to gRPC proxy listener
...
Signed-off-by: Allen Ray <alray@redhat.com >
2022-08-17 10:56:27 -04:00
Yingrong Zhao
ea2f299ba0
embed: add integration test for distributed tracing
...
To verify distributed tracing feature is correctly setup, this PR adds
an integration test for this feature.
In the process of writing the test, I discovered a goroutine leak due to
the TraceProvider not being closed. This PR fixs this issue as well.
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com >
2022-08-15 11:19:10 -04:00
Benjamin Wang
fae4650834
Merge pull request #14280 from falser101/fix/zjf
...
fix: code cleanup
2022-07-27 07:20:43 +08:00
jianfei.zhang
c26d7f5389
fix: code cleanup
...
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io >
2022-07-26 22:07:22 +08:00
Marek Siarkowicz
d44bbff278
server: Make corrtuption check optional and period configurable
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2022-07-26 09:31:15 +02:00
Marek Siarkowicz
c58ec9fe13
server: Refactor compaction checker
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2022-07-25 13:59:30 +02:00
Benjamin Wang
1a6fe4dbc6
update the comment for MaxConcurrentStreams to clearly state it's the max value for each client.
...
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-07-07 04:51:20 +08:00
Benjamin Wang
053ba95ed5
set max concurrent streams to the http2 server
...
The default max stream is 250 in http2. When there are more then
250 streams, the client side may be blocked until some previous
streams are released. So we need to support configuring a larger
`MaxConcurrentStreams`.
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-07-06 03:43:46 +08:00
杨金珏
6220174687
support custom grpc.MaxConcurrentStreams
...
There is no update on the original PR (see below) for more then 2
weeks. So Benjamin(@ahrtr) continues to work on the PR. The first
step is to rebase the PR, because there are lots of conflicts with
the main branch.
The change to go.mod and go.sum reverted, because they are not needed.
The e2e test cases are also reverted, because they are not correct.
```
https://github.com/etcd-io/etcd/pull/14081
```
Signed-off-by: nic-chen <chenjunxu6@gmail.com >
Signed-off-by: Benjamin Wang <wachao@vmware.com >
2022-07-06 03:43:46 +08:00
SimFG
1dcd75f8a2
config: Add the default case when failing to parse the log rotate config json
...
Make sure that the `setupLogRotation` function must return the error when failing parse json.
Signed-off-by: SimFG <1142838399@qq.com >
2022-06-23 19:41:30 +08:00
Piotr Tabor
cbf54a0421
Use proper grpc schema (unix:file) for unix sockets.
...
Signed-off-by: Piotr Tabor <ptab@google.com >
2022-06-17 08:57:23 +02:00
Piotr Tabor
a1fe0b8ea3
Merge pull request #14116 from ptabor/20220613-embed-errors
...
Embed server should log errors (and not get stuck)
2022-06-15 22:37:40 +02:00
Piotr Tabor
1c401581e3
Close channel of started servers even if embed server fails to start.
...
Before this change:
```
gwmux, err = sctx.registerGateway([]grpc.DialOption{grpc.WithInsecure()})
if err != nil { return err; }
```
caused the Etcd.Serve() method finish without sctx.serversC channel being closed.
The code closing Etcd got stuck waiting for all the servers to be running.
Signed-off-by: Piotr Tabor <ptab@google.com >
2022-06-15 13:50:17 +02:00
Piotr Tabor
fcc8fce4d2
Expand logging in case of embed server not being able to successfully start.
...
So far the errors were directed to Etcd.Errc (channel) that is not being consumed in practice.
Signed-off-by: Piotr Tabor <ptab@google.com >
2022-06-15 13:50:17 +02:00
Marek Siarkowicz
7c35dadc25
server: Extract corruption detection to dedicated struct
...
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com >
2022-06-13 18:19:24 +02:00
Dirc
ba405f64c1
Update link to tuning page
2022-06-08 10:16:04 +02:00
Piotr Tabor
651de5a057
Rename EtcdServer.Id with EtcdServer.MemberId.
...
It was misleading and error prone vs. ClusterId.
2022-05-20 14:32:04 +02:00
Marek Siarkowicz
26f42e7a9e
server: Apply review comments and split basic handler
2022-05-05 09:52:14 +02:00
Marek Siarkowicz
722ec487df
server: Split metrics and health code
2022-05-05 09:52:14 +02:00
Marek Siarkowicz
600ee13ac0
server: Cover V3 health with tests
2022-05-05 09:52:14 +02:00
Tony Abboud
1d13e0733c
Fix logger spelling in NewZapLoggerBuilder godoc
...
Just a small docs fix that I happened to notice when setting up a new zap logger for etcd
2022-04-22 12:08:54 -04:00
ahrtr
1a3822f2c3
Rename ClientConfig to ConfigSpec
...
The ClientConfig is a fully declarive configuration, so it makes more
sense to rename it to ConfigSpec. It can also mitigate the confusion
between Config and ClientConfig.
2022-03-13 05:41:49 +08:00
ahrtr
3dcbbf62d9
Move clientconfig into clientv3 so that it can be reused by both etcdctl and v3 discovery
2022-03-12 06:38:41 +08:00
ahrtr
d578a86a59
fix some log format typos
2022-03-10 03:26:34 +08:00
Piotr Tabor
088807c08e
Merge pull request #13565 from ahrtr/remove_peer_serve_client_requests
...
Updated servePeers to remove the grpc server
2022-03-01 16:24:42 +01:00
ahrtr
2f36e0c62b
Change discovery url to endpoints
...
Currently the discovery url is just one endpoint. But actually it
should be the same as the etcdctl, which means that it should be
a list of endpoints. When one endpoint is down, the clientv3 can
fail over to the next endpoint automatically.
2022-02-24 09:11:41 +08:00
Marek Siarkowicz
b5e224db7d
Merge pull request #13635 from ahrtr/v3_discovery
...
support v3 discovery to bootstrap a new etcd cluster
2022-02-21 21:50:40 +01:00
Piotr Tabor
f80f477073
Merge pull request #13644 from Juneezee/refactor/t.TempDir
...
*: use `T.TempDir` to create temporary test directory
2022-02-21 19:52:37 +01:00
ahrtr
ebc86d12c0
support v3 discovery to bootstrap a new etcd cluster
2022-02-21 23:22:49 +08:00
ahrtr
a879ccf152
updated servePeers to remvoe the grpc server
2022-01-27 16:22:01 +08:00
ahrtr
1713dc67b5
etcd server shouldn't wait for the ready notification infinitely on startup
2022-01-27 16:19:20 +08:00
Eng Zer Jun
e9edc5432c
*: use T.TempDir to create temporary test directory
...
The directory created by `T.TempDir()` and is automatically removed when
the test and all its subtests complete.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2022-01-25 00:00:46 +08:00
Marek Siarkowicz
ee5ef42c5c
server: --enable-v2 and --enable-v2v3 is decomissioned
2022-01-14 13:19:30 +01:00