1455 Commits

Author SHA1 Message Date
Marek Siarkowicz
7fdb33065d Move duplicated shouldApplyV3 logic up into apply method
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-24 10:21:14 +01:00
Marek Siarkowicz
093666f450 Cleanup v2 applier
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-23 15:41:13 +01:00
Marek Siarkowicz
c72ff1e69c Remove syncing the v2 store TTLs
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-23 14:55:01 +01:00
Marek Siarkowicz
ed3375e076 Remove v2 apply logic
v2 store is no longer available in v3.6.
We can remove apply logic for it as they will never be used.

Only v2 PUT is neeeded as it applies to v3 storage and etcd v3.5 uses it for setting member
attributes and cluster version.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-23 14:13:07 +01:00
Marek Siarkowicz
28d9564962
Merge pull request #16994 from serathius/tests-v2-cluster-version
Add tests for setting cluster version using v2 request
2023-11-22 21:11:18 +01:00
Marek Siarkowicz
2f30760b37 Add tests for setting cluster version using v2 request
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-22 18:05:19 +01:00
Marek Siarkowicz
29dd025b84 Stop using v2 requests in server tests
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-22 14:41:53 +01:00
Benjamin Wang
fd0882b67e
Merge pull request #16984 from siyuanfoundation/lin-read
etcdserver: add linearizable_read check to readyz.
2023-11-21 19:51:12 +00:00
Siyuan Zhang
12b640523a etcdserver: add linearizable_read check to readyz.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2023-11-21 11:13:20 -08:00
Benjamin Wang
ec6147cd04
Merge pull request #16967 from serathius/remove-v2-proposals
Remove v2 proposals code
2023-11-21 15:35:51 +00:00
Benjamin Wang
bccd56ae48
Merge pull request #16985 from jmhbnz/update-dependencies
[2023-11-21] Bump dependencies identified by dependabot
2023-11-21 15:06:57 +00:00
James Blair
3a9a7483b7
depdendency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.46.0 to 0.46.1.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-11-21 20:03:48 +13:00
James Blair
3b37afec7b
Don't follow redirects when checking peer urls.
It's possible that etcd server may run into SSRF situation when adding a new member. If users provide a malicious peer URL, the existing etcd members may be redirected to other unexpected internal URL when getting the new member's version.

Signed-off-by: James Blair <mail@jamesblair.net>
2023-11-21 10:25:20 +13:00
James Blair
08aabfea02
depdendency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.20.0 to 1.21.0.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-11-21 10:06:15 +13:00
James Blair
5449f0fb99
depdendency: bump go.opentelemetry.io/otel/sdk from 1.20.0 to 1.21.0.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-11-21 10:04:28 +13:00
Marek Siarkowicz
dd7a4d28a8 Remove code used to make v2 proposals
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-19 22:39:33 +01:00
Marek Siarkowicz
b4fd31f254 Remove code for setting cluster version via V2 API
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-11-19 15:28:52 +01:00
Sharath Sivakumar
33b526f58d
dependency: bump golang.org/x/net from 0.17.0 to 0.18.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-16 11:03:00 +01:00
Sharath Sivakumar
4907fedbc3
dependency: bump golang.org/x/crypto from 0.14.0 to 0.15.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-16 10:50:17 +01:00
Sharath Sivakumar
7586098f78
dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.18.0 to 2.18.1
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-16 10:44:50 +01:00
Siyuan Zhang
3897103b77 etcdserver: add metric counters for livez/readyz health checks.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2023-11-14 09:26:00 -08:00
Sharath Sivakumar
acd5724689
dependency: bump go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.19.0 to 1.20.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-13 12:18:48 +01:00
Sharath Sivakumar
8066e8116b
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.45.0 to 0.46.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-11-13 11:53:02 +01:00
vivekpatani
8da89177a9 etcdctl,etcdutl,pkg,server,tests,tools: bump github.com/spf13/cobra from 1.7.0 to 1.8.0
- https://github.com/etcd-io/etcd/pull/16878/

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-09 11:02:36 -06:00
vivekpatani
ed30fb1226 *: bump golang.org/x/sys from 0.13.0 to 0.14.0
- https://github.com/etcd-io/etcd/pull/16875

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-09 11:02:36 -06:00
Tessa Pham
2b7e1c6f82 fix scripts
Signed-off-by: Tessa Pham <hpham111@bloomberg.net>
2023-11-08 00:27:13 -06:00
vivekpatani
d2ada92830 etcdctl,etcdutl,server,tests: update golang.org/x/time to v0.4.0
- https://github.com/etcd-io/etcd/pull/16880

Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-07 11:01:51 -06:00
vivekpatani
8264b4e9ae clientv3,server,tests: bump dependencies identified by dependabot
Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
2023-11-05 09:27:37 -06:00
Chao Chen
8a6c1335e2 v3rpc: run health notifier to listen on online defrag state change
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-10-28 17:49:24 -07:00
Benjamin Wang
1101655b9f bump bbolt to 1.3.8 for main branch
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-10-26 16:34:15 +01:00
Chao Chen
ea035471ce online defrag notifies gRPC health server to expose NOT_SERVING status
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-10-25 08:58:33 -07:00
Benjamin Wang
34382006db test: implement method ForgetLeader for struct nodeRecorder
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-10-24 10:19:13 +01:00
Benjamin Wang
ae60b5567a bump raft to latest commit
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-10-24 10:17:57 +01:00
James Blair
d2af596a98
depdendency: bump github.com/prometheus/common from 0.44.0 to 0.45.0.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-10-24 17:44:01 +13:00
James Blair
e6e740fb80
depdendency: bump google.golang.org/grpc from 1.58.3 to 1.59.0.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-10-24 17:39:39 +13:00
Chao Chen
1324f03254 add existing http health check handler e2e test
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-10-18 12:42:23 -07:00
Marek Siarkowicz
11edde9204
Merge pull request #16622 from fuweid/fix-unparam-lint
*: enable and fix unparam lint
2023-10-18 09:21:22 +02:00
Wei Fu
f96000e15d *: cleanup main_test.go
The #15544 has removed the `build_cov` build. And after go1.20, we use
`-cover` buildflag to enable coverage exporter. We don't need to
maintain main_test.go anymore.

```bash
➜  pwd
/home/fuwei/go/src/go.etcd.io/etcd/etcdctl

➜  go build -o /tmp/etcdctl -cover ./

➜  mkdir /tmp/etcdctl-covdata

➜  GOCOVERDIR=/tmp/etcdctl-covdata /tmp/etcdctl get /health

➜  go tool covdata percent -i=/tmp/etcdctl-covdata
        go.etcd.io/etcd/etcdctl/v3      coverage: 66.7% of statements
        go.etcd.io/etcd/etcdctl/v3/ctlv3        coverage: 83.3% of statements
        go.etcd.io/etcd/etcdctl/v3/ctlv3/command        coverage: 15.4% of statements
```

REF: https://go.dev/testing/coverage/

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-10-17 21:47:23 +08:00
Wei Fu
aea1cd0077 feat: enable unparam lint
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-10-17 21:24:13 +08:00
Siyuan Zhang
7a57e06eca etcdserver: add livez and ready http endpoints for etcd.
Add two separate probes, one for liveness and one for readiness. The liveness probe would check that the local individual node is up and running, or else restart the node, while the readiness probe would check that the cluster is ready to serve traffic. This would make etcd health-check fully Kubernetes API complient.

Signed-off-by: Siyuan Zhang <sizhang@google.com>
2023-10-14 22:32:16 -07:00
Eng Zer Jun
867faa1924
etcdserver: remove redundant len check in health check
From the Go specification [1]:

  "1. For a nil slice, the number of iterations is 0."

`len` returns 0 if the slice or map is nil [2]. Therefore, checking
`len(v) > 0` around a loop is unnecessary.

[1]: https://go.dev/ref/spec#For_range
[2]: https://pkg.go.dev/builtin#len

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2023-10-13 18:39:38 +08:00
Chao Chen
c25f1dff82 http health check bug fixes
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-10-12 16:59:34 -07:00
Allen Ray
e4c0eb7712 bump google.golang.org/grpc to v1.58.3
Signed-off-by: Allen Ray <alray@redhat.com>
2023-10-11 10:39:05 -04:00
Allen Ray
3a61187ce3 bump golang.org/x/net to v0.17.0
Address CVE-2023-39325 and CVE-2023-44487

Signed-off-by: Allen Ray <alray@redhat.com>
2023-10-11 10:09:14 -04:00
Marek Siarkowicz
9f40116fa0 Return to default write scheduler since golang.org/x/net@v0.11.0 started using round robin
Introduction of round robin 120fc906b3
Added in v0.10.0 https://github.com/golang/net/compare/v0.10.0...v0.11.0

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-10-10 16:31:42 +02:00
Marek Siarkowicz
4540db9a7c
Merge pull request #16731 from sharathsivakumar/shsi/bump_dependencies_6
Bump dependencies generated by the bot manually
2023-10-10 13:51:48 +02:00
Sharath Sivakumar
d884580432
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 to 0.45.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-10-10 11:50:54 +02:00
Sharath Sivakumar
c94deb9511
dependency: bump github.com/prometheus/client_model from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-10-10 11:49:36 +02:00
Sharath Sivakumar
1b1c42a7aa
dependency: bump golang.org/x/net from 0.15.0 to 0.16.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2023-10-10 11:49:35 +02:00
Marek Siarkowicz
16e19a9547
Merge pull request #16269 from dusk125/refactor-revision
Refactor common revision code to pkg
2023-10-10 10:16:58 +02:00