Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,879 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

12879 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Gyu-Ho Lee
81ca10f991 client/keys.generated.go: remove ineffassign yynn2 = 0 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-20 08:52:48 -07:00
Gyu-Ho Lee
1b2a62d9d0 client/keys.generated.go: remove redundant and: x.Expiration != nil 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-20 08:47:01 -07:00
Andrew Meissner
cd859cfaa3 scripts: update 
ran the updatedep.sh
 2017-10-20 09:39:37 -06:00
Andrew Meissner
12a6efb74b update: client 
Updating the codec required codecgen to be reran on the client/keys.go file.  This is the result of that run.
 2017-10-20 09:23:23 -06:00
Andrew Meissner
b896e985b6 glide: update github.com/ugorji/go/codec 
Updating github.com/ugorji/go/codec to the latest commit/version
 2017-10-20 09:22:27 -06:00
Gyu-Ho Lee
40b6fcd761 Merge pull request #8717 from gyuho/retry-cleanup 
clientv3: clean up retry wrapper, remove all FailFast=false
 2017-10-19 16:08:59 -07:00
Gyu-Ho Lee
54ef60d033 clientv3: remove redundant retries in Auth, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 16:03:12 -07:00
Gyu-Ho Lee
1fa60c9882 clientv3: add TODO for watch retry 
Later we can do:

```diff
+// RetryWatchClient implements a WatchClient.
+func RetryWatchClient(c *Client) pb.WatchClient {
+	readRetry := c.newRetryWrapper(isReadStopError)
+	wc := pb.NewWatchClient(c.conn)
+	return &retryWatchClient{wc, readRetry}
+}
+
+type retryWatchClient struct {
+	pb.WatchClient
+	readRetry retryRPCFunc
+}
+
+func (rwc *retryWatchClient) Watch(ctx context.Context, opts ...grpc.CallOption) (stream pb.Watch_WatchClient, err error) {
+	err = rwc.readRetry(ctx, func(rctx context.Context) error {
+		stream, err = rwc.WatchClient.Watch(rctx, opts...)
+		return err
+	})
+	return stream, err
+}

-	return NewWatchFromWatchClient(pb.NewWatchClient(c.conn))
+	return NewWatchFromWatchClient(RetryWatchClient(c))
```

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 16:02:01 -07:00
Gyu-Ho Lee
141170c1d4 clientv3: remove redundant retries in Maintenance, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 16:01:50 -07:00
Gyu-Ho Lee
c09a89d834 clientv3: remove redundant retries in Cluster, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 16:00:45 -07:00
Gyu-Ho Lee
fecd26f141 clientv3: rename to isRepeatableStopError, isNonRepeatableStopError 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 15:58:12 -07:00
Gyu-Ho Lee
b46ab2c36e clientv3: remove redundant retries in KV, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 15:57:10 -07:00
Gyu-Ho Lee
ad7882590c Merge pull request #8718 from gyuho/qqq 
clientv3: remove redundant retries in Lease, set FailFast=true
 2017-10-19 15:04:46 -07:00
Gyu-Ho Lee
f95f865060 clientv3: unexport pb.LeaseClient in lease client 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 15:02:19 -07:00
Gyu-Ho Lee
87fe8c12ae clientv3: rename to repeatableRetry in lease client 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 14:58:54 -07:00
Gyu-Ho Lee
29aa4ce2a1 clientv3: remove redundant retries in Lease, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 14:53:01 -07:00
Gyu-Ho Lee
a2c61cf04f Merge pull request #8716 from gyuho/ready-wait 
clientv3: separate readyWait for ConnectNotify
 2017-10-19 13:10:17 -07:00
Gyu-Ho Lee
2540859ee7 clientv3: separate readyWait for ConnectNotify 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 13:07:22 -07:00
Gyu-Ho Lee
c945b7b44a Merge pull request #8714 from gyuho/aaa 
clientv3: handle stale endpoints, clean up logging
 2017-10-19 12:35:30 -07:00
Gyu-Ho Lee
1549403dd2 clientv3: clean up logging, clarify var/field names 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 12:33:25 -07:00
Gyu-Ho Lee
ad24700252 clientv3: handle stale endpoint in health balancer 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 12:02:31 -07:00
Gyu-Ho Lee
a8f9de2abf Merge pull request #8704 from gyuho/typo 
*: fix typo in Makefile, add *.log, release directory to gitignore
 2017-10-17 09:06:34 -07:00
Gyu-Ho Lee
5790ffde7c gitignore: ignore *.log, release directory 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-17 09:05:10 -07:00
Gyu-Ho Lee
39fe293649 Makefile: fix typo in 'docker-test-proxy' 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-17 09:05:01 -07:00
Hitoshi Mitake
b989e1992f Merge pull request #8695 from jpbetz/fix-disabled-simple-token-assign 
auth: Fix simpleToken to respect disabled state for assign
 2017-10-14 15:49:36 +09:00
Joe Betz
d3c9643761 auth: Fix simpleToken to respect disabled state for assign 2017-10-13 21:44:07 -07:00
Gyu-Ho Lee
d392debf82 Merge pull request #8693 from gyuho/makefile 
Makefile: fix 'test', add 'test-all' commands with docker
 2017-10-13 12:42:07 -07:00
Gyu-Ho Lee
f0a78eb516 Makefile: fix 'test', add 'test-all' commands with docker 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-13 12:14:26 -07:00
Gyu-Ho Lee
764a0f79b2 Merge pull request #8683 from gyuho/ctl 
etcdctl/ctlv3: inherit/update flags only once in 'check' command
 2017-10-11 10:51:40 -07:00
Gyu-Ho Lee
e80b2474fa etcdctl/ctlv3: inherit/update flags only once in 'check' command 
When creating multiple clients, 'mustClientFromCmd' overwrites
inherited flags with environment variables, so later clients
were printing warnings on duplicate key updates.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-11 10:37:15 -07:00
Gyu-Ho Lee
0ef0abf9bf Merge pull request #8676 from gyuho/aaa 
clientv3: fix typo in 'testNetworkPartitionBalancer'
 2017-10-10 19:17:32 -07:00
Gyu-Ho Lee
7f2b6a19d6 clientv3: fix typo in 'testNetworkPartitionBalancer' 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-10 16:07:03 -07:00
Gyu-Ho Lee
bc03ce9cab Merge pull request #8674 from gyuho/set-endpoints 
clientv3: reset unhealthy on updateAddrs
 2017-10-10 13:29:01 -07:00
Gyu-Ho Lee
500c2499f4 clientv3: reset unhealthy on updateAddrs 
Otherwise, 'mayPin' incorrectly decides if an address
should be pinned or not.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-10 12:28:57 -07:00
Gyu-Ho Lee
8329963d69 Merge pull request #8669 from gyuho/balancer 
clientv3/balancer: handle network partition in health check
 2017-10-09 16:54:31 -07:00
Gyu-Ho Lee
e9e17e3fe5 clientv3: pin any endpoint when all unhealthy 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 16:02:18 -07:00
Gyu-Ho Lee
826de3c07a words: whitelist more words 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 14:54:53 -07:00
Gyu-Ho Lee
8224c748c9 clientv3/integration: add balancer network partition tests 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 14:54:47 -07:00
Gyu-Ho Lee
fbed568b6a clientv3/balancer: mark partitioned member as unhealthy 
Previous behavior is when server returns errors, retry
wrapper does not do anything, while passively expecting
balancer to gray-list the isolated endpoint. This is
problematic when multiple endpoints are passed, and
network partition happens.

This patch adds 'endpointError' method to 'balancer' interface
to actively(possibly even before health-check API gets called)
handle RPC errors and gray-list endpoints for the time being,
thus speeding up the endpoint switch.

This is safe in a single-endpoint case, because balancer will
retry no matter what in such case.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 13:40:03 -07:00
Gyu-Ho Lee
1704443c6d clientv3: only health-check when timeout elapses since last failure 
Otherwise network-partitioned member with active health-check
server would not be gray-listed, making health-balancer stuck
with isolated endpoint.

Also clarifies some log messages.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 13:40:03 -07:00
Gyu-Ho Lee
e47be1f325 Merge pull request #8672 from gyuho/require-leader 
etcdctl/ctlv3: enable 'require-leader' for 'watch' command
 2017-10-09 13:38:52 -07:00
Gyu-Ho Lee
d44f7d5f67 etcdctl/ctlv3: enable 'require-leader' for 'watch' command 
To help with network partition cases.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 13:19:30 -07:00
Xiang Li
ed92420950 Merge pull request #8666 from lorneli/ordering 
clientv3/ordering: compare and update prevRev atomically
 2017-10-09 11:14:40 -07:00
Gyu-Ho Lee
09a38a7953 Merge pull request #8671 from gyuho/ddd 
Dockerfile-test: add 'ineffassign' to image
 2017-10-09 10:38:45 -07:00
Gyu-Ho Lee
2bbd26e8e0 README: update badges 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 09:48:23 -07:00
Xiang Li
6571829f16 Merge pull request #8663 from YuleiXiao/add_keepalive_for_ctlv3 
etcdctl/v3: add keep alive time/timeout
 2017-10-09 09:45:59 -07:00
Gyu-Ho Lee
66f2a65f6b Dockerfile-test: add 'ineffassign' to image 
Was missing for 'fmt' tests.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 09:36:30 -07:00
Gyu-Ho Lee
71197ab2a5 Merge pull request #8670 from gyuho/rrr 
README: update 'goreman' guide with 'grpc-proxy'
 2017-10-09 09:35:47 -07:00
Gyu-Ho Lee
90c3f91f29 README: update 'goreman' guide with 'grpc-proxy' 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-09 09:28:22 -07:00
lorneli
5096b4ed5d clientv3/ordering: compare and update prevRev atomically 
Several goroutines may call setPrevRev concurrently with different
revisions, all higher than prevRev. Previously all of these goroutines
could set prevRev, so prevRev may be replaced by older one.

If response's revision equals to prevRev, there's no need to call
setPrevRev.
 2017-10-09 20:06:19 +08:00