1710 Commits

Author SHA1 Message Date
Marek Siarkowicz
7181c7532f Relax assumptions about all client request persisted in WAL to only require first and last request to be persisted
This assumption is not true during durability issues like #14370.
In reality we want to avoid situations where WAL is was truncated, for
that it's enough that we ensure that first and last operations are
present.

Found it when running `make test-robustness-issue14370` and instead of
getting `Model is not linearizable` I got that assumptions were broken.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-05-08 10:40:38 +02:00
Marek Siarkowicz
126e0d511f
Merge pull request #17933 from siyuanfoundation/log
robustness: add 2 more log lines when persistClientReports
2024-05-07 09:17:22 +02:00
Siyuan Zhang
dd79332cf6 robustness: add 2 more log lines when persistClientReports
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-05-06 09:53:39 -07:00
ArkaSaha30
7a383beba3
dependency: bump go.etcd.io/bbolt from v1.4.0-alpha.0 to v1.4.0-alpha.1
This commit will bump go.etcd.io/bbolt from
v1.4.0-alpha.0 to v1.4.0-alpha.1 for etcd 3.6

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-05-06 19:53:29 +05:30
Sharath Sivakumar
813e0865fe
bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.25.0 to 1.26.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-05-03 21:43:03 +02:00
Sharath Sivakumar
82113ab066
dependency: bump go.opentelemetry.io/otel/trace from 1.25.0 to 1.26.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-05-03 18:27:52 +02:00
Benjamin Wang
13c0f75b7d
Merge pull request #17877 from tjungblu/17872_status
add quota to endpoint status response
2024-05-03 13:03:23 +01:00
Benjamin Wang
d31caaec4a
Merge pull request #17793 from mneverov/fix-quorum-check
Fix remove member failed.
2024-04-30 19:52:14 +01:00
Marek Siarkowicz
6a1e28a519
Merge pull request #17890 from serathius/robustness-lease-revoke
Add LeaseRevoke request to WAL parsing
2024-04-29 13:33:32 +02:00
Chun-Hung Tseng
133576899c
gofail: show error messages returned by gofail HTTP endpoints
Upon HTTP request error from fetchFailpointsBody, PUT and DELETE,
all of them will return an error message, which would be nice for
debugging if displayed.

Simplify `Enabled()` logic (linter suggestion)

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-04-28 05:49:24 +08:00
Marek Siarkowicz
1e7dd97e3b Add LeaseRevoke request to WAL parsing
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-27 12:04:27 +02:00
Marek Siarkowicz
0bd7008eea
Merge pull request #17878 from callthingsoff/omit_conversion_using_verb_s
all: don't convert byte slice to string when using verb %s
2024-04-26 16:43:54 +02:00
Marek Siarkowicz
b36d9b2156
Merge pull request #17731 from serathius/robustness-wal-validate-watch
Robustness wal validate watch
2024-04-26 08:37:33 +02:00
Marek Siarkowicz
2de719dea4 Use WAL persisted request to validate watch
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-25 21:11:37 +02:00
Jes Cok
dafadd13c1 all: don't convert byte slice to string when using verb %s
This is unnecessary, as the documentation for 'go doc fmt' says:
%s the uninterpreted bytes of the string or slice

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
2024-04-25 23:34:52 +08:00
Thomas Jungblut
bdcff246cb add quota to endpoint status response
This adds the configured backend quota bytes to the endpoint status response.
related discussion in #17821

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
2024-04-25 16:44:20 +02:00
Marek Siarkowicz
9027014adb
Merge pull request #17827 from siyuanfoundation/flaky
robustness: Add option to not overwrite results dir.
2024-04-24 22:48:02 +02:00
Siyuan Zhang
3c3b76cea1 robustness: not overwrite results dir by giving each dir a unique name.
Signed-off-by: Siyuan Zhang <sizhang@google.com>
2024-04-24 12:36:55 -07:00
Benjamin Wang
a601652b5d
Merge pull request #17863 from ivanvc/address-remaining-var-naming-linter-warnings
Address remaining var naming linter warnings
2024-04-24 10:09:39 +01:00
Marek Siarkowicz
96d619459b
Merge pull request #17734 from MadhavJivrajani/toolchain-directive
tests: set GOTOOLCHAIN var for report validation
2024-04-24 09:25:07 +02:00
Marek Siarkowicz
5cbc8c950e
Merge pull request #17841 from henrybear327/dependencies/04_22_2024
[2024-04-22] Bump dependency updates identified by dependabot
2024-04-24 09:24:00 +02:00
Ivan Valdes
7300abc552
tests/common: address var-naming lint warnings
Signed-off-by: Ivan Valdes <ivan@vald.es>
2024-04-23 20:09:06 -07:00
Madhav Jivrajani
856847d89b tests: set GOTOOLCHAIN var for report validation
Set GOTOOLCHAIN directive in order to successfully run tests
from root. Else, go will try and download a family of releases
(of the form 1.x), which are not published binaries.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-04-23 14:44:51 +05:30
Marek Siarkowicz
9fcde37447 Persist member data with lazyfs enabled
Discovered turning off LazyFS before creating the report might result in
empty server directory. This PR moves cluster shutdown to defer executed
after we generate report and copies the data from lazyfs directory.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-23 10:19:05 +02:00
Chun-Hung Tseng
45eb0110b6
dependency: bump golang.org/x/sync from 0.6.0 to 0.7.0
Reference:
- https://github.com/etcd-io/etcd/pull/17848

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-04-22 19:44:58 +02:00
Chun-Hung Tseng
f696c4c749
dependency: bump github.com/prometheus/common from 0.52.3 to 0.53.0
References:
- https://github.com/etcd-io/etcd/pull/17839
- https://github.com/etcd-io/etcd/pull/17840

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-04-22 19:44:58 +02:00
Benjamin Wang
dd4e35a585
Merge pull request #17815 from fuweid/repro-17780
[RFC] fix revision loss issue caused by compaction - 17780
2024-04-22 18:15:44 +01:00
Marek Siarkowicz
062a0ea057
Merge pull request #17825 from serathius/robustness-qps
Don't require minimal for failpoint injection period
2024-04-22 19:03:42 +02:00
Marek Siarkowicz
7d1d4cb3a9
Merge pull request #17835 from serathius/robustness-watch-error
Handle watch responses with error
2024-04-22 14:44:00 +02:00
Benjamin Wang
3469254e26
Merge pull request #17836 from sharathsivakumar/shsi/deps_1
Manually bump dependencies
2024-04-22 12:26:27 +01:00
Sharath Sivakumar
9e938abd91
dependency: bump golang.org/x/net from 0.23.0 to 0.24.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-04-21 23:14:29 +02:00
Sharath Sivakumar
80c5690bb9
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.49.0 to 0.50.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-04-21 22:58:17 +02:00
Sharath Sivakumar
a392758755
dependency: bump github.com/prometheus/client_model from 0.6.0 to 0.6.1
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-04-21 22:54:47 +02:00
Sharath Sivakumar
81d7b2cb3d
dependency: bump github.com/prometheus/common from 0.51.1 to 0.52.3
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-04-21 22:46:41 +02:00
Marek Siarkowicz
fa9e9504ad Handle watch responses with error
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-21 20:49:49 +02:00
Marek Siarkowicz
a097a3b39d
Merge pull request #17810 from serathius/robustness-revisions-between-progress
Validate revisions between progress notify
2024-04-21 20:04:25 +02:00
Wei Fu
7173391154 tests/e2e: reproduce #17780
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2024-04-21 18:12:00 +08:00
Marek Siarkowicz
f285330d46 Don't require minimal for failpoint injection period
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-20 10:34:51 +02:00
Marek Siarkowicz
964680c8d0 Validate delivery of events between progress notifies
Simplifying bookmarkable to just validate revision order between events
and progress notifies.

Use reliable to validate if events are missing, but still report
broken resumable if first event after revision is missing. It's easier
to have one place that validates event slices.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-19 10:42:54 +02:00
Max Neverov
6b0b4ce2b3 Increase test timeout (twice of sleep interval).
Signed-off-by: Max Neverov <neverov.max@gmail.com>
2024-04-18 14:47:11 +02:00
Max Neverov
3b16aae947 Fix remove member failed.
Signed-off-by: Max Neverov <neverov.max@gmail.com>
2024-04-17 07:55:24 +02:00
Marek Siarkowicz
5a8c8b703b
Merge pull request #17807 from serathius/robustness-resumable-revision-zero
Resumable handles watch with revision zero
2024-04-16 19:41:53 +02:00
Marek Siarkowicz
dc187ce6e8 Validate bookmarkable checks the last event before progress notify
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-16 09:17:40 +02:00
Marek Siarkowicz
6f6647271f
Merge pull request #17806 from serathius/robustness-watch-filter
Add filter validation to ensure watch only includes events within selector
2024-04-16 08:52:25 +02:00
coderwander
842a0f3a35 tests: fix some typos in comments
Signed-off-by: coderwander <770732124@qq.com>
2024-04-16 13:59:41 +08:00
Marek Siarkowicz
94a47a7cbd Resumable handles watch with revision zero
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-15 20:23:51 +02:00
Marek Siarkowicz
042e7d1a0c Add filter validation to ensure watch only includes events within selector
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-15 20:05:08 +02:00
Marek Siarkowicz
a95a307698 Add tests to watch validation
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-14 21:38:03 +02:00
Marek Siarkowicz
569693be8d Utilize WAL to patch operation history
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2024-04-14 12:09:38 +02:00
Marek Siarkowicz
452445e2d8
Merge pull request #17781 from serathius/robustness-read-limit
Remove limit from read requests after a failed write
2024-04-14 12:05:23 +02:00