1683 Commits

Author SHA1 Message Date
Chun-Hung Tseng
5be397a6a8
Fix a linter issue
golangci-lint reports the following issue:
storage/mvcc/kvstore.go:312:27: (*store).restore - result 0 (error) is always nil (unparam)

It's due to the fact that both Attach() and compactLockfree() within the
function restore() are able to return an error, but we only log them in
the current implementation. Thus, the return value restore() is always
nil, hence the linter warning.

We have agreed to suppress the linter warning for now [1].

Reference:
[1] https://github.com/etcd-io/etcd/pull/18228#issuecomment-2187309957

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-25 11:45:53 +02:00
James Blair
16ed0fe86e
Merge pull request #18212 from Willhow-Gao/main
mvcc: fix typo
2024-06-22 20:10:26 +12:00
MR_G
c0076a788e mvcc: fix typo
Signed-off-by: MR_G <2044783677@qq.com>
2024-06-22 00:17:13 +08:00
Benjamin Wang
1d13fc58ff
Merge pull request #14066 from rleungx/add-config
embed: add `GRPCAdditionalServerOptions` config
2024-06-21 06:40:32 +01:00
Benjamin Wang
a043da50fe
Merge pull request #18062 from stackbaek/main
featuregate: adds EtcdServer.FeatureEnabled interface.
2024-06-19 09:35:54 +01:00
Benjamin Wang
692e44a80b Update the error message when client certificate isn't provided for secure metrics url
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
2024-06-18 14:03:39 +01:00
Benjamin Wang
9c59b28086
Merge pull request #18186 from gyuho/enforce-non-empty-client-tls-if-metrics-url-scheme-is-https
fix(server): enforce listen-metrics-urls client TLS info when its scheme is https/unixs
2024-06-18 13:59:21 +01:00
Gyuho Lee
497f1a45a3
license
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-18 07:28:43 +08:00
Chun-Hung Tseng
166d26b4e4 dependency: bump github.com/spf13/cobra from 1.8.0 to 1.8.1
Reference:
- https://github.com/etcd-io/etcd/pull/18190

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-17 22:09:15 +02:00
Chun-Hung Tseng
a947aa0d3f dependency: bump go.opentelemetry.io/proto/otlp from 1.2.0 to 1.3.1
Reference:
- https://github.com/etcd-io/etcd/pull/18191

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-17 22:09:15 +02:00
Chun-Hung Tseng
fa835658e3 dependency: bump google.golang.org/protobuf from 1.34.1 to 1.34.2
Reference:
- https://github.com/etcd-io/etcd/pull/18196

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-17 21:49:52 +02:00
Gyuho Lee
22f20a827b
test(e2e): add a case where client tls is missing for https metrics url
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-17 21:09:24 +08:00
Gyuho Lee
a657f069a1
fix(server/embed): enforce non-empty client TLS if scheme is https/unixs
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
2024-06-17 18:21:38 +08:00
Cenk Alti
ea46253b42
Improve snapshot status
Signed-off-by: Cenk Alti <cenkalti@gmail.com>
2024-06-15 10:11:34 -04:00
Baek
60e3f45469 Adds all feature_gate from component-base.
We'll likely use most of the feature_gate package from component-base.
Also this commit moves the pkg from server/internal/pkg to pkg/.

Signed-off-by: Baek <seungtackbaek@google.com>
2024-06-15 05:34:58 +00:00
Baek
69ebaaebca featuregate: adds EtcdServer.FeatureEnabled interface.
The interface can be used throughout the etcd server binary to check if
the feature is enabled or not.

Note that this commit also copies necessary FeatureGate interface from
k8s component-base.

Signed-off-by: Baek <seungtackbaek@google.com>
2024-06-15 05:34:58 +00:00
Benjamin Wang
45f14539e0
Merge pull request #18164 from andyxning/bugfix_register_of_walWriteSec
bugfix: register of walWriteSec
2024-06-14 18:32:15 +01:00
lubronzhan
0b6529c462 mvcc: fix typo
Signed-off-by: lubronzhan <lubronzhan@gmail.com>
2024-06-13 00:15:37 -07:00
Andy Xie
4a555fead3 bugfix: register of walWriteSec
Signed-off-by: Andy Xie <andy.xning@gmail.com>
2024-06-13 15:12:58 +08:00
Chun-Hung Tseng
293d979759 dependency: bump golang.org/x/net from 0.25.0 to 0.26.0
Reference:
- https://github.com/etcd-io/etcd/pull/18150
- https://github.com/etcd-io/etcd/pull/18146

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-12 09:45:04 +02:00
Chun-Hung Tseng
e1d7af5a0c dependency: bump golang.org/x/crypto from 0.23.0 to 0.24.0
Reference:
- https://github.com/etcd-io/etcd/pull/18149

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-12 09:37:07 +02:00
Ryan Leung
d9cb8b80f5 address the comment
Signed-off-by: Ryan Leung <rleungx@gmail.com>
2024-06-12 11:38:41 +08:00
Ryan Leung
29abd62338 introduce GRPCAdditionalServerOptions
Signed-off-by: Ryan Leung <rleungx@gmail.com>
2024-06-07 16:39:35 +08:00
lhy1024
acc9d7c9fe Support multiple values for allowed client and peer TLS identities
Signed-off-by: lhy1024 <admin@liudos.us>
2024-06-06 21:25:17 +08:00
ArkaSaha30
2089857ab8
Bump Go version to 1.22.4: CVE 2024-24790 fix
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-06-05 14:12:52 +05:30
James Blair
2f083a5733
Merge pull request #18120 from henrybear327/dependency_update/6_3_24
[2024-06-03] Bump dependency updates identified by dependabot
2024-06-04 12:41:06 +12:00
Chun-Hung Tseng
f77f422812 dependency: bump github.com/prometheus/common from 0.53.0 to 0.54.0
References:
- https://github.com/etcd-io/etcd/pull/18111
- https://github.com/etcd-io/etcd/pull/18118

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-06-03 22:15:31 +02:00
Cenk Alti
b107d2437f
cli: Add etcdutl snapshot hashkv command
Signed-off-by: Cenk Alti <cenkalti@gmail.com>

Apply suggestions from code review

Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
2024-06-02 00:07:50 -04:00
Stephen Kitt
c1f5a445fc
Use Go 1.20 error joining instead of multierr
This still allows the errors to be unwrapped, and drops the direct
dependency on multierr.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2024-05-31 09:22:52 +02:00
Chun-Hung Tseng
287a3a1a39 dependency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.26.0 to 1.27.0
Reference:
- https://github.com/etcd-io/etcd/pull/18072

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-30 15:19:23 +02:00
Chun-Hung Tseng
a3f7d2a5db dependency: bump go.opentelemetry.io/otel/sdk from 1.26.0 to 1.27.0
Reference:
- https://github.com/etcd-io/etcd/pull/18073

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-30 15:19:23 +02:00
Chun-Hung Tseng
1ec63aa93a dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.51.0 to 0.52.0 and go.opentelemetry.io/otel from 1.26.0 to 1.27.0
When doing `go get go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc@v0.52.0`,
go.opentelemetry.io/otel is automatically bumped, too.

References:
- https://github.com/etcd-io/etcd/pull/18075
- https://github.com/etcd-io/etcd/pull/18074

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-30 15:19:23 +02:00
Edwin Xie
4c77726914 Implement flag --experimental-set-member-localaddr
Which sets the LocalAddr to an IP address from --initial-advertise-peer-urls.

Also adds e2e test that requires this flag to succeed.

Co-authored-by: HighPon <s.shiraki.business@gmail.com>
Signed-off-by: Edwin Xie <edwin.xie@broadcom.com>
2024-05-24 18:17:37 +00:00
Chun-Hung Tseng
9431e3a952 dependency: bump google.golang.org/grpc from 1.63.2 to 1.64.0
Reference:
- https://github.com/etcd-io/etcd/pull/18034

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-20 22:45:14 +02:00
Chun-Hung Tseng
e79a11f789 dependency: bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.19.1 to 2.20.0
Reference:
- https://github.com/etcd-io/etcd/pull/18035

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-20 22:30:41 +02:00
Shim Myeongseob
769500124f embed: fix typo in comment
Signed-off-by: Shim Myeongseob <Mangsby716@gmail.com>
2024-05-19 13:59:25 +00:00
James Blair
52fb28c1a8
Merge pull request #17983 from thedtripp/feature/addServerRangeDurationMetrics
etcdserver: add server range duration metrics
2024-05-19 10:04:29 +12:00
Daniel Tripp
0232686cac etcdserver: add server range duration metrics
Signed-off-by: Daniel Tripp <38776199+thedtripp@users.noreply.github.com>
Co-authored-by: Ravi Hari <RaviHari@users.noreply.github.com>
2024-05-18 19:01:09 +00:00
Chun-Hung Tseng
a66cf56661 dependency: bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1
Reference:
- https://github.com/etcd-io/etcd/pull/17999
- https://github.com/etcd-io/etcd/pull/17994

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-17 23:53:06 +02:00
Lavish pal
6038f391f1 Upgrade go to 1.22.3.
Signed-off-by: Lavish pal <lvishpal408@gmail.com>
2024-05-10 03:27:35 +05:30
Chun-Hung Tseng
69ca6e96fa dependency: bump golang.org/x/net from 0.24.0 to 0.25.0
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-09 11:48:14 +02:00
Chun-Hung Tseng
1a1820562d dependency: bump golang.org/x/crypto from 0.22.0 to 0.23.0
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-09 11:48:14 +02:00
Chun-Hung Tseng
41ba741db1 dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.50.0 to 0.51.0
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-09 11:48:14 +02:00
Chun-Hung Tseng
ee9af3c566 dependency: bump google.golang.org/protobuf from 1.33.0 to 1.34.1
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
2024-05-09 11:48:14 +02:00
Benjamin Wang
570370f6e7
Merge pull request #17876 from MadhavJivrajani/go-directive-periodic
[RFC] Setup a way to consistently manage go versions across scripts and go.mods
2024-05-08 09:47:13 +01:00
Seena Fallah
b31f23e113 config: support AllowedCN and AllowedHostname through config file
Allow setting AllowedCN and AllowedHostname tls fields through config file for peer transport security.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
2024-05-07 22:39:16 +02:00
Madhav Jivrajani
f6a35f8786 .*: sync go toolchain version and add ability to verify versions
This commit adds a script to sync the version present in .go-version
across all go.mod files as the toolchain directive. As part of that,
this commit also modifies go.mod files that did not have synced toolchain
directives.

Additionally, this also adds a script to verify all toolchain and go
directives against the version present in .go-version as follows:
(1) The go directive <= version in .go-version
(2) The toolchain directive == version in .go-version

This script runs as part of the `make verify` target, making it run
as a presbumit by default.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
2024-05-07 17:52:56 +05:30
ArkaSaha30
7a383beba3
dependency: bump go.etcd.io/bbolt from v1.4.0-alpha.0 to v1.4.0-alpha.1
This commit will bump go.etcd.io/bbolt from
v1.4.0-alpha.0 to v1.4.0-alpha.1 for etcd 3.6

Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
2024-05-06 19:53:29 +05:30
Benjamin Wang
301c74c688
Merge pull request #17932 from sharathsivakumar/shsi/dep_2
Manually bump dependencies
2024-05-04 20:09:12 +01:00
Sharath Sivakumar
813e0865fe
bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.25.0 to 1.26.0
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
2024-05-03 21:43:03 +02:00