19898 Commits

Author SHA1 Message Date
Wei Fu
1ba577e499 server/etcdserver: togRPCError for maintenance API
It's to deflake TestAuthMemberRemove.

When the client has multiple endpoints, the client might send a request
with valid token to the follower member which hasn't received token
replicated log yet. The member will reject the request.

For instance, the maintenance.Status API will return "auth: invalid auth
token". But the client doesn't identify the error. The client won't retry to
refresh auth token. The maintenance.Status should togRPCError before return
so that the client can reflesh token. It's align with existing API.

Since the maintenance client always creates one connection to target
member, the member will have the token after refresh auth.

Maybe we can introduce a sync to wait for member is ready with token,
instead of refreshing.

Fixes: #15758

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-22 18:35:53 +08:00
Benjamin Wang
63c9fe1d00
Merge pull request #15751 from owayss/auth_store_unit_test_coverage
tests: increases unit test coverage for etcd/server/auth isRangeOpPermitted
2023-04-21 07:29:35 +08:00
Benjamin Wang
4a8817bfb0
Merge pull request #15737 from jmhbnz/update-dependencies
Bump dependencies identified by dependabot
2023-04-21 06:35:08 +08:00
James Blair
aad63a1efe
dependency: bump github.com/mikefarah/yq/v4 from 4.33.1 to 4.33.3
Signed-off-by: James Blair <mail@jamesblair.net>
2023-04-21 05:40:03 +12:00
James Blair
04f3e9cb9a
dependency: bump golang.org/x/crypto from 0.7.0 to 0.8.0
Signed-off-by: James Blair <mail@jamesblair.net>
2023-04-21 05:34:21 +12:00
James Blair
042e2e9a57
dependency: bump github.com/prometheus/client_golang from 1.14.0 to 1.15.0
Signed-off-by: James Blair <mail@jamesblair.net>
2023-04-21 05:14:40 +12:00
Marek Siarkowicz
ee6fde70dc
Merge pull request #15748 from judavi/15674
Adds a reusable workflow to setup the GoVersion
2023-04-20 15:34:20 +02:00
Juan
0df7c48ddd Centralizing workflow go-version variable
Signed-off-by: Juan <1766933+judavi@users.noreply.github.com>
2023-04-20 11:42:28 +00:00
Owayss Kabtoul
1c18c86e18 tests: increases unit test coverage for etcd/server/auth isRangeOpPermitted
Signed-off-by: Owayss Kabtoul <owayssk@gmail.com>
2023-04-20 13:39:08 +02:00
Benjamin Wang
0ac617059f
Merge pull request #15745 from catandcoder/main
fix some comments
2023-04-20 15:07:07 +08:00
cui fliter
57908723f4 fix some comments
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-04-20 14:26:17 +08:00
Benjamin Wang
b27dec8b94
Merge pull request #15721 from vianamjr/txn-auth-unit-test
tests: cover txn.CheckTxnAuth logic with unit tests
2023-04-19 05:54:55 +08:00
Marcondes Viana
9d14ae43c2 fix review: remove if on error check
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-04-18 10:43:13 -03:00
Marcondes Viana
ecc7441ba1 fix review: use assert lib
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-04-18 10:02:03 -03:00
Marek Siarkowicz
b526cdcbe8
Merge pull request #15718 from fuweid/followup-15667
tests: make log monitor as common helper (followup #15667
2023-04-18 07:59:19 +02:00
Wei Fu
50aa00b203 tests: make log monitor as common helper
It's followup of #15667.

This patch is to use zaptest/observer as base to provide a similar
function to pkg/expect.Expect.

The test env

```bash
11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
mkdir /sys/fs/cgroup/etcd-followup-15667
echo 0-2 | tee /sys/fs/cgroup/etcd-followup-15667/cpuset.cpus # three cores
```

Before change:

* memory.peak: ~ 681 MiB
* Elapsed (wall clock) time (h:mm:ss or m:ss): 6:14.04

After change:

* memory.peak: ~ 671 MiB
* Elapsed (wall clock) time (h:mm:ss or m:ss): 6:13.07

Based on the test result, I think it's safe to be enabled by default.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-18 09:00:24 +08:00
Benjamin Wang
a9c1c217a2
Merge pull request #15736 from etcd-io/dependabot/github_actions/github/codeql-action-2.2.12
build(deps): bump github/codeql-action from 2.2.11 to 2.2.12
2023-04-18 05:11:44 +08:00
Benjamin Wang
4c79aecd0c
Merge pull request #15735 from etcd-io/dependabot/github_actions/actions/checkout-3.5.2
build(deps): bump actions/checkout from 3.5.0 to 3.5.2
2023-04-18 05:04:46 +08:00
dependabot[bot]
64c9a5c70a
build(deps): bump github/codeql-action from 2.2.11 to 2.2.12
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.11 to 2.2.12.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](d186a2a36c...7df0ce3489)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-17 18:01:44 +00:00
dependabot[bot]
b1e14c7d0a
build(deps): bump actions/checkout from 3.5.0 to 3.5.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.0 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](8f4b7f8486...8e5e7e5ab8)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-17 18:01:42 +00:00
Marcondes Viana
3654552fe8 fix review: move setup and vars
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-04-17 08:19:10 -03:00
Marcondes Viana
7a7e09d3a5 fix review: group calls
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-04-16 19:59:47 -03:00
Marcondes Viana
41b1d36bd9 fix review
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-04-16 17:44:46 -03:00
Marcondes Viana
a1a2f43f2f fix review
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-04-16 17:41:59 -03:00
Marcondes Viana
8fb839eac1 Update server/etcdserver/txn/txn_test.go
Signed-off-by: Marcondes Viana <marju10@gmail.com>
Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>
2023-04-16 17:09:02 -03:00
Marcondes Viana
4c63611768 tests: cover txn.CheckTxnAuth logic with unit tests
Signed-off-by: Marcondes Viana <marju10@gmail.com>
2023-04-16 13:24:12 -03:00
Benjamin Wang
53b48bbd57
Merge pull request #15716 from ahrtr/3.4.25_date
change v3.4.25's release date
2023-04-14 16:33:05 +08:00
Marek Siarkowicz
7261f6a39d
Merge pull request #15713 from jmhbnz/create-membership-issue-template
Add issue template for new membership nominations.
2023-04-14 10:29:36 +02:00
James Blair
8aa00159d6
Add issue template for new membership nominations.
Signed-off-by: James Blair <mail@jamesblair.net>
2023-04-14 20:08:56 +12:00
Benjamin Wang
003ae7a5a2 change v3.4.25's release date
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-14 15:49:20 +08:00
Benjamin Wang
22f3e50ada
Merge pull request #15672 from fuweid/cleanup-15514
chore: cleanup #15514 (Rewrite etcd scripts in strict mode)
2023-04-13 13:06:09 +08:00
Wei Fu
9f034fbaa8 chore: use tools/mod to lock the cfssl cmd version
Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:06:31 +08:00
Wei Fu
9dc54ca32c chore: add strict mode for pkg/proxy/fixtures/gencerts.sh
REF: #15514

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:05:39 +08:00
Wei Fu
dc2cf29598 chore: add strict mode to scripts/test_lib.sh
REF: #15514

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:05:39 +08:00
Wei Fu
8cd5969248 chore: use strict mode for tests/*/*.sh
REF: #15514

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:05:39 +08:00
Wei Fu
78d2ead804 chore: deprecate tests/manual folder
REF: #15514

Signed-off-by: Wei Fu <fuweid89@gmail.com>
2023-04-13 12:05:39 +08:00
Marek Siarkowicz
29e7971721
Merge pull request #15611 from serathius/robustness-merge-failpoints
Robustness merge failpoints
2023-04-12 16:06:30 +02:00
Marek Siarkowicz
e48ef9ea6a tests/robustness: Disable blackholing traffic till snapshot for v3.4.X
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-12 14:39:57 +02:00
Marek Siarkowicz
d19752f16a tests/robustness: Unify failpoint lists by depending on availability checking
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-12 14:38:30 +02:00
Marek Siarkowicz
625d427eb5 tests/robustness: Separate triggering failpoint from injection
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-12 14:36:50 +02:00
Marek Siarkowicz
932415a8d5 tests/robustness: Verify cluster configuration in failpoint availability
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
2023-04-12 14:36:50 +02:00
Benjamin Wang
817aba57c7
Merge pull request #15637 from chaochn47/reduce_e2e_test_runtime
tests/framwork/e2e/cluster.go: revert back to sequential cluster stop to reduce e2e test run time
2023-04-12 14:45:29 +08:00
Chao Chen
941c4afb0c tests/framwork/e2e/cluster.go: revert back to sequential cluster stop to reduce e2e test run time
Signed-off-by: Chao Chen <chaochn@amazon.com>
2023-04-11 22:08:18 -07:00
Marek Siarkowicz
6519a15db4
Merge pull request #15639 from ArkaSaha30/add-unit-test-malformed-jwt
server/auth: fix panic a malformed jwt generation and add test-cases
2023-04-11 12:19:28 +02:00
Marek Siarkowicz
daf9d234d8
Merge pull request #15694 from ahrtr/dependency_20230411
Bump some dependencies
2023-04-11 10:55:47 +02:00
Marek Siarkowicz
d6d4e62f60
Merge pull request #15678 from ahrtr/changelog_jwt_panic_20230410
changelog: add items to cover some fixes for 3.5.8 and 3.4.25
2023-04-11 10:51:16 +02:00
Benjamin Wang
0375317166
Merge pull request #15679 from HeavenTonight/main
Fix link for maintainers role and responsibilities in README.md
2023-04-11 13:02:28 +08:00
Benjamin Wang
946be6b3a5 changelog: add items to cover some fixes for 3.5.8 and 3.4.25
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 12:59:06 +08:00
Benjamin Wang
dae1d70189 test: workaround the breaking change in jonboulle/clockwork
See
- https://github.com/jonboulle/clockwork/pull/55
- https://github.com/jonboulle/clockwork/blob/v0.3.0/clockwork.go#L42

Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 12:01:09 +08:00
Benjamin Wang
ff08625126 dedpendency: bump gotest.tools/gotestsum from 1.9.0 to 1.10.0
Signed-off-by: Benjamin Wang <wachao@vmware.com>
2023-04-11 08:56:09 +08:00