Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
17,237 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

19 Commits

Author SHA1 Message Date
Sergey Kacheev
b922a28622 netutil: add url comparison without resolver to URLStringsEqual 
If one of the nodes in the cluster has lost a dns record,
restarting the second node will break it.
This PR makes an attempt to add a comparison without using a resolver,
which allows to protect cluster from dns errors and does not break
the current logic of comparing urls in the URLStringsEqual function.
You can read more in the issue #7798

Fixes #7798
 2021-07-19 01:31:21 +07:00
Gyuho Lee
e8ba8feaed pkg/netutil: use structured logging for TCP resolve 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-04-27 11:40:13 -07:00
Gyuho Lee
e1de74913d pkg/netutil: return error from "URLStringsEqual" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-01-25 11:22:07 -08:00
Anthony Romano
492bbc9659 netutil: test schemes for URLStringsEqual 
add tests for http/https mismatch and unix scheme
 2017-08-31 12:41:05 -07:00
Anthony Romano
85e87e8f6b netutil: use "context" and ctx-ize TCP addr resolution 2017-04-21 10:01:53 -07:00
Anthony Romano
88d4e7ebeb netutil: fix unused err staticcheck failure 
Clears SA4006
 2017-04-07 10:52:54 -07:00
Anthony Romano
13b05aeff8 netutil: ctx-ize URLStringsEqual 
Handles the case where the DNS entry will only be set up after etcd
starts.
 2016-12-14 15:46:30 -08:00
Gyu-Ho Lee
8b77de4e99 pkg: update LICENSE header 2016-05-12 20:48:53 -07:00
Xiang Li
044b23c3ca Merge pull request #3356 from xiang90/travis 
*: test gofmt with -s and fix reported issues
 2015-08-21 18:59:51 -07:00
Xiang Li
6b23a8131f *: test gofmt with -s and fix reported issues 2015-08-21 18:52:16 -07:00
Yicheng Qin
3c1e6b54b3 pkg/netutil: stop resolving in place 
It helps to copy out a and b, and not modify the original a and b.
 2015-08-21 12:09:17 -07:00
Yicheng Qin
7b871aab41 pkg/netutil: not export resolve and urlsEqual functions 
They are only used in this package, so there is no need to public them.
 2015-08-21 11:58:37 -07:00
Yicheng Qin
b1192e5c48 pkg/netutil: fix false negative comparison 
Sort the resolved URLs before DeepEqual, so it will not compare URLs
that may be out of order due to resolution.
 2015-08-21 10:15:08 -07:00
Yicheng Qin
8ea3d157c5 Revert "Revert "Treat URLs have same IP address as same"" 
This reverts commit 3153e635d5799f1ff8715fd4b7c07e0283820acd.

Conflicts:
	etcdserver/config.go
 2015-08-21 09:41:13 -07:00
Yicheng Qin
3153e635d5 Revert "Treat URLs have same IP address as same" 
This reverts commit f8ce5996b0566619fde8cca431890a49c52cf3d6.

etcd no longer resolves TCP addresses passed in through flags,
so there is no need to compare hostname and IP slices anymore.
(for more details: a3892221eea4804f58ce83934c91964e83f4f30c)

Conflicts:
	etcdserver/cluster.go
	etcdserver/config.go
	pkg/netutil/netutil.go
	pkg/netutil/netutil_test.go
 2015-05-16 03:21:10 -07:00
Alex Crawford
d9ad6aa2a9 *: update to use IANA-assigned ports 2015-04-06 13:49:43 -07:00
Shota Fukumori (sora_h)
f8ce5996b0 Treat URLs have same IP address as same 
- To solve validation error problem using URLs in hostname #2123
 2015-01-27 04:36:41 +09:00
Jonathan Boulle
f1ed69e883 *: switch to line comments for copyright 
Build tags are not compatible with block comments.
Also adds copyright header to a few places it was missing.
 2015-01-26 09:53:30 -08:00
Kelsey Hightower
705ec45083 etcdmain: resolve DNS hostnames for client and peer URLs 
etcd resolves DNS hostnames to IP addresses for client and peer URLs
before creating any listening sockets.

The following messages are logged during startup:

    etcd: Resolving infra0.coreos.com:2380 to 10.0.1.10:2380

Fixes #1991
 2014-12-24 13:12:32 -05:00