Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,467 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

698 Commits

Author SHA1 Message Date
Gyu-Ho Lee
f49f5c9094 *: disable grpc client log in tests by default 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-07 15:05:13 -08:00
Gyu-Ho Lee
5d98710b2e api/v3rpc: deprecate grpc.Errorf 
It's been deprecated as of grpc/grpc-go v1.6.x.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-04 22:08:17 -07:00
Gyu-Ho Lee
0ca8f420d4 clientv3/integration: match more errors in put retries 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-31 13:31:38 -07:00
Gyu-Ho Lee
2c13231e7b clientv3/integration: increase balancer switch timeout for TestKVGetResetLoneEndpoint 
Since 3-second is the minimum time to keep an endpoint in unhealthy,
it is possible that endpoint switch happens right after context timeout.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-31 10:48:15 -07:00
Gyu-Ho Lee
8d23e1c870 clientv3/integration: add blackhole tests for range RPCs 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-30 19:18:53 -07:00
Gyu-Ho Lee
a37dd0055f clientv3/integration: move to TestBalancerUnderBlackholeKeepAliveWatch 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-30 17:19:48 -07:00
Gyu-Ho Lee
8d5c284b6c clientv3/integration: add blackhole tests on mutable operations 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-30 13:32:59 -07:00
Gyu-Ho Lee
bea930f44d clientv3/integration: finish isolated node test cases 
1. one with retry
2. one without retry (range request with longer timeouts)

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-30 11:17:43 -07:00
Gyu-Ho Lee
ca1e6a74e0
Merge pull request #8782 from gyuho/rename 
clientv3/integration: rename to 'mustWaitPinReady'
 2017-10-27 15:07:31 -07:00
Gyu-Ho Lee
5d169b866f clientv3/integration: rename to 'mustWaitPinReady' 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-27 15:00:31 -07:00
Gyu-Ho Lee
03ce2fa037 clientv3/integration: remove client keepalive in network partition tests 
Those tests are about balancer endpoint switch, not about keepalive pings.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-27 14:47:37 -07:00
Xiang Li
2cea13ba68
Merge pull request #8779 from gyuho/shutdown-test 
clientv3/integration: add TestBalancerUnderServerShutdownImmutable
 2017-10-27 12:23:22 -07:00
Gyu-Ho Lee
732c40531b
Merge pull request #8762 from gyuho/partition-test 
clientv3/integration: add TestBalancerUnderNetworkPartitionWatch
 2017-10-27 12:22:32 -07:00
Gyu-Ho Lee
62821158aa
Merge pull request #8767 from xiang90/f 
clientv3/integration: fix a todo in testNetworkPartitionBalancer
 2017-10-27 11:26:40 -07:00
Gyu-Ho Lee
9d95cfb105 clientv3/integration: add TestBalancerUnderServerShutdownImmutable 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-27 10:55:12 -07:00
Gyu-Ho Lee
e980bde82d clientv3/integration: add TestBalancerUnderNetworkPartitionWatch 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-26 18:17:00 -07:00
Gyu-Ho Lee
0bfc6a0d92 clientv3/integration: add TestBalancerUnderServerShutdownMutable* 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-26 16:42:33 -07:00
Gyu-Ho Lee
6a8d6b6ad9 clientv3/integration: use waitPinReady in blackhole test 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-26 15:12:27 -07:00
Gyu-Ho Lee
af53f54042 clientv3/integration: add waitPinReady 
RPC should be sent to trigger 'readyWait' on new pin address.
Otherwise, endpoints other than ep[0] may be pinned.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-26 15:11:10 -07:00
Xiang
10c971db70 clientv3/integration: add put blackhole test 2017-10-26 14:09:51 -07:00
Xiang
7d7e9b6e43 clientv3/integration: fix a todo in testNetworkPartitionBalancer 2017-10-25 22:54:44 -07:00
Gyu-Ho Lee
8fa35216b0 clientv3/integration: Get with context timeout 
Address https://github.com/coreos/etcd/pull/8762#discussion_r147019068.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-25 17:43:29 -07:00
Xiang Li
995d79a0fc Merge pull request #8758 from gyuho/failure-test 
clientv3/integration: add TestBalancerUnderServerShutdownWatch
 2017-10-25 17:03:33 -07:00
Gyu-Ho Lee
cea7387b73 clientv3/integration: add TestBalancerUnderServerShutdownWatch 
Current Watch integration tests haven't covered the balancer
switch behavior under server failures.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-25 16:13:46 -07:00
Gyu-Ho Lee
c50cfbeaf6 Merge pull request #8759 from gyuho/mmm 
integration: use variadic parameters for *Partition
 2017-10-25 15:31:33 -07:00
Gyu-Ho Lee
6f8c476599 clientv3/integration: rename partition tests 
To be consistent with TestBalancerUnderShutdown*

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-25 14:57:16 -07:00
Gyu-Ho Lee
b6f770fc24 integration: use variadic parameters for *Partition 
'member' type is not exported.
In network partition tests, we want do

InjectPartition(t, clus.Members[lead], clus.Members[lead+1])

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-25 14:55:03 -07:00
Gyu-Ho Lee
ff2ed93b5c clientv3/integration: do not create v3 clients when not used 
Add 'SkipCreatingClients' field to skip creating clients if not used.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-24 16:59:41 -07:00
Xiang
8d1f9c654a clientv3/integration: fix keepalive by waiting for unhealthy 2017-10-24 00:56:09 -07:00
Xiang
109f52e3d6 clientv3: fix balancer unresponsiveness 
When no address is pined, and balancer ignores the addr Up due to
its current unhealthy state, balancer will be unresponsive forever.

This PR fixes it by doing a full reset when there is no pined addr,
thus re-trigger the Up call.
 2017-10-23 21:19:21 -07:00
Gyu-Ho Lee
2a49b04f09 clientv3/integration: fix typos 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-23 20:13:53 -07:00
Xiang Li
b699c7cff7 Merge pull request #8737 from xiang90/fix_TestWatchKeepAlive 
clientv3/integration: shorten keepalive timeout
 2017-10-22 21:21:22 -07:00
Xiang Li
97f0b28bdb Merge pull request #8738 from gyuho/ccc 
clientv3: fix balancer notify, stale endpoint handling, retry
 2017-10-22 21:20:44 -07:00
Xiang
f65575073a clientv3/integration: match ErrTimeout in testNetworkPartitionBalancer 
For put, etcd can return timeout errors from network partitions.
 2017-10-22 18:44:35 -07:00
Xiang
5943229921 clientv3: wait for current pin endpoint down on notify 2017-10-22 18:02:58 -07:00
Xiang
3899f9e3c5 clientv3/integration: shorten keepalive timeout 2017-10-22 18:02:15 -07:00
Xiang
59af91fc69 clientv3: use hostPortError in down function 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-22 18:01:31 -07:00
Xiang
63ab5addfa clientv3: do not mark stale endpoints as unhealthy 2017-10-22 17:59:26 -07:00
Gyu-Ho Lee
725df70664 clientv3: only stop if EtcdError code is not Unavailable, retry with more error codes 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-22 17:54:14 -07:00
Xiang Li
5eef654c3c Merge pull request #8734 from xiang90/testing_log 
clientv3: disable server logging for client testing
 2017-10-22 16:50:21 -07:00
Xiang
6f0771d2f6 clientv3: disable server logging for client testing 2017-10-22 16:32:42 -07:00
Xiang
06e591d526 clientv3/integration: skip retry test on txn read 2017-10-22 16:14:39 -07:00
Gyu-Ho Lee
439c97d465 clientv3: remove balancer interface 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-20 16:31:02 -07:00
Gyu-Ho Lee
54ef60d033 clientv3: remove redundant retries in Auth, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 16:03:12 -07:00
Gyu-Ho Lee
1fa60c9882 clientv3: add TODO for watch retry 
Later we can do:

```diff
+// RetryWatchClient implements a WatchClient.
+func RetryWatchClient(c *Client) pb.WatchClient {
+	readRetry := c.newRetryWrapper(isReadStopError)
+	wc := pb.NewWatchClient(c.conn)
+	return &retryWatchClient{wc, readRetry}
+}
+
+type retryWatchClient struct {
+	pb.WatchClient
+	readRetry retryRPCFunc
+}
+
+func (rwc *retryWatchClient) Watch(ctx context.Context, opts ...grpc.CallOption) (stream pb.Watch_WatchClient, err error) {
+	err = rwc.readRetry(ctx, func(rctx context.Context) error {
+		stream, err = rwc.WatchClient.Watch(rctx, opts...)
+		return err
+	})
+	return stream, err
+}

-	return NewWatchFromWatchClient(pb.NewWatchClient(c.conn))
+	return NewWatchFromWatchClient(RetryWatchClient(c))
```

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 16:02:01 -07:00
Gyu-Ho Lee
141170c1d4 clientv3: remove redundant retries in Maintenance, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 16:01:50 -07:00
Gyu-Ho Lee
c09a89d834 clientv3: remove redundant retries in Cluster, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 16:00:45 -07:00
Gyu-Ho Lee
fecd26f141 clientv3: rename to isRepeatableStopError, isNonRepeatableStopError 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 15:58:12 -07:00
Gyu-Ho Lee
b46ab2c36e clientv3: remove redundant retries in KV, set FailFast=true 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 15:57:10 -07:00
Gyu-Ho Lee
f95f865060 clientv3: unexport pb.LeaseClient in lease client 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-10-19 15:02:19 -07:00