Xiang Li
d095a5c48b
Merge pull request #8752 from xiang90/fix_keepalive
...
clientv3/integration: fix keepalive by waiting for unhealthy
2017-10-24 10:12:13 -07:00
Gyu-Ho Lee
6277828f13
Merge pull request #8743 from dmyerscough/fix-example-snippet
...
Documentation/op-guide: Fix missing docker volume commands and specify the initial DATA_DIR
2017-10-24 07:03:26 -07:00
Xiang
8d1f9c654a
clientv3/integration: fix keepalive by waiting for unhealthy
2017-10-24 00:56:09 -07:00
Damian Myerscough
abc606f139
Documentation/op-guide: Fix missing docker volume commands and specifying the initial DATA_DIR usage
2017-10-23 22:40:43 -07:00
Xiang Li
d16de1b914
Merge pull request #8742 from xiang90/debug_ordering
...
clientv3: fix balancer unresponsiveness
2017-10-23 21:57:33 -07:00
Xiang
109f52e3d6
clientv3: fix balancer unresponsiveness
...
When no address is pined, and balancer ignores the addr Up due to
its current unhealthy state, balancer will be unresponsive forever.
This PR fixes it by doing a full reset when there is no pined addr,
thus re-trigger the Up call.
2017-10-23 21:19:21 -07:00
Gyu-Ho Lee
fdaa04e95f
Merge pull request #8749 from gyuho/docker-test
...
*: fix test docker images, switch travis to docker
2017-10-23 21:12:53 -07:00
Gyu-Ho Lee
2a49b04f09
clientv3/integration: fix typos
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-23 20:13:53 -07:00
Gyu-Ho Lee
0d76ede274
words: whitelist more
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-23 20:13:50 -07:00
Gyu-Ho Lee
d5fc37072c
travis: use docker
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-23 20:05:57 -07:00
Gyu-Ho Lee
cd4ca4065e
Dockerfile-test: use ubuntu 16.10 as base image
...
Debian base image from golang-stretch was breaking
shellcheck tests.
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-23 19:28:00 -07:00
Gyu-Ho Lee
1724cfa937
Merge pull request #8748 from gyuho/mmm
...
semaphore: add test scripts
2017-10-23 16:41:24 -07:00
Gyu-Ho Lee
249a2c30d2
Makefile: delete
...
moving to somewhere else
2017-10-23 16:35:04 -07:00
Gyu-Ho Lee
6337e4a1ec
semaphore: add test scripts
2017-10-23 16:35:00 -07:00
Gyu-Ho Lee
319658aef3
Merge pull request #8747 from gyuho/makefile
...
Makefile: clean up all redundant targets
2017-10-23 13:38:41 -07:00
Gyu-Ho Lee
997469a8cf
test: add 'VERBOSE' flag to enable client debugs
2017-10-23 13:13:28 -07:00
Gyu-Ho Lee
2b5733d742
Makefile: remove redundant commands
2017-10-23 13:13:11 -07:00
Gyu-Ho Lee
fa7c8f3f83
gitignore: add covdir
2017-10-23 10:34:30 -07:00
Gyu-Ho Lee
149ee61e02
Dockerfile-test: add codecov for coverage tests
2017-10-23 10:29:08 -07:00
Xiang Li
b699c7cff7
Merge pull request #8737 from xiang90/fix_TestWatchKeepAlive
...
clientv3/integration: shorten keepalive timeout
2017-10-22 21:21:22 -07:00
Xiang Li
97f0b28bdb
Merge pull request #8738 from gyuho/ccc
...
clientv3: fix balancer notify, stale endpoint handling, retry
2017-10-22 21:20:44 -07:00
Xiang Li
2ae10a8184
Merge pull request #8741 from gyuho/ppp
...
clientv3/integration: match ErrTimeout in testNetworkPartitionBalancer
2017-10-22 19:16:55 -07:00
Xiang
f65575073a
clientv3/integration: match ErrTimeout in testNetworkPartitionBalancer
...
For put, etcd can return timeout errors from network partitions.
2017-10-22 18:44:35 -07:00
Xiang
5943229921
clientv3: wait for current pin endpoint down on notify
2017-10-22 18:02:58 -07:00
Xiang
3899f9e3c5
clientv3/integration: shorten keepalive timeout
2017-10-22 18:02:15 -07:00
Xiang
59af91fc69
clientv3: use hostPortError in down function
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-22 18:01:31 -07:00
Xiang
63ab5addfa
clientv3: do not mark stale endpoints as unhealthy
2017-10-22 17:59:26 -07:00
Gyu-Ho Lee
725df70664
clientv3: only stop if EtcdError code is not Unavailable, retry with more error codes
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-22 17:54:14 -07:00
Xiang Li
5eef654c3c
Merge pull request #8734 from xiang90/testing_log
...
clientv3: disable server logging for client testing
2017-10-22 16:50:21 -07:00
Xiang
6f0771d2f6
clientv3: disable server logging for client testing
2017-10-22 16:32:42 -07:00
Xiang Li
0c5ca488c1
Merge pull request #8736 from xiang90/disable_retry
...
clientv3/integration: skip retry test on txn read
2017-10-22 16:15:36 -07:00
Xiang
06e591d526
clientv3/integration: skip retry test on txn read
2017-10-22 16:14:39 -07:00
Xiang Li
ebc09b1149
Merge pull request #8727 from CDKGlobal/fix/close-restore-backup-backend-master
...
etcdctl: close snapshot backend to close open file on member/snap/db
2017-10-21 10:51:33 -07:00
Gyu-Ho Lee
785a5a11ed
Merge pull request #8728 from gyuho/eee
...
clientv3: remove balancer interface
2017-10-20 16:43:32 -07:00
Gyu-Ho Lee
439c97d465
clientv3: remove balancer interface
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-20 16:31:02 -07:00
Jeffrey Gensler
7ffcca5946
etcdctl: close snapshot backend to close open file on member/snap/db
2017-10-20 15:25:21 -07:00
Xiang Li
6c35754481
Merge pull request #8725 from gyuho/condition
...
v3rpc/rpctypes: use codes.FailedPrecondition for ErrGRPCNotLeader
2017-10-20 15:06:57 -07:00
Gyu-Ho Lee
2feb8ba545
v3rpc/rpctypes: use codes.FailedPrecondition for ErrGRPCNotLeader
...
Changes ErrGRPCNotLeader error code to FailedPrecondition,
to disable retry with unavailable.
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-20 14:28:17 -07:00
Gyu-Ho Lee
f83ac25412
Merge pull request #8721 from andrewmeissner/feature/update-codecgen
...
client/v2: regenerate with latest ugorji/go/codec
2017-10-20 09:07:59 -07:00
Gyu-Ho Lee
81ca10f991
client/keys.generated.go: remove ineffassign yynn2 = 0
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-20 08:52:48 -07:00
Gyu-Ho Lee
1b2a62d9d0
client/keys.generated.go: remove redundant and: x.Expiration != nil
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-20 08:47:01 -07:00
Andrew Meissner
cd859cfaa3
scripts: update
...
ran the updatedep.sh
2017-10-20 09:39:37 -06:00
Andrew Meissner
12a6efb74b
update: client
...
Updating the codec required codecgen to be reran on the client/keys.go file. This is the result of that run.
2017-10-20 09:23:23 -06:00
Andrew Meissner
b896e985b6
glide: update github.com/ugorji/go/codec
...
Updating github.com/ugorji/go/codec to the latest commit/version
2017-10-20 09:22:27 -06:00
Gyu-Ho Lee
40b6fcd761
Merge pull request #8717 from gyuho/retry-cleanup
...
clientv3: clean up retry wrapper, remove all FailFast=false
2017-10-19 16:08:59 -07:00
Gyu-Ho Lee
54ef60d033
clientv3: remove redundant retries in Auth, set FailFast=true
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-19 16:03:12 -07:00
Gyu-Ho Lee
1fa60c9882
clientv3: add TODO for watch retry
...
Later we can do:
```diff
+// RetryWatchClient implements a WatchClient.
+func RetryWatchClient(c *Client) pb.WatchClient {
+ readRetry := c.newRetryWrapper(isReadStopError)
+ wc := pb.NewWatchClient(c.conn)
+ return &retryWatchClient{wc, readRetry}
+}
+
+type retryWatchClient struct {
+ pb.WatchClient
+ readRetry retryRPCFunc
+}
+
+func (rwc *retryWatchClient) Watch(ctx context.Context, opts ...grpc.CallOption) (stream pb.Watch_WatchClient, err error) {
+ err = rwc.readRetry(ctx, func(rctx context.Context) error {
+ stream, err = rwc.WatchClient.Watch(rctx, opts...)
+ return err
+ })
+ return stream, err
+}
- return NewWatchFromWatchClient(pb.NewWatchClient(c.conn))
+ return NewWatchFromWatchClient(RetryWatchClient(c))
```
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-19 16:02:01 -07:00
Gyu-Ho Lee
141170c1d4
clientv3: remove redundant retries in Maintenance, set FailFast=true
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-19 16:01:50 -07:00
Gyu-Ho Lee
c09a89d834
clientv3: remove redundant retries in Cluster, set FailFast=true
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-19 16:00:45 -07:00
Gyu-Ho Lee
fecd26f141
clientv3: rename to isRepeatableStopError, isNonRepeatableStopError
...
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
2017-10-19 15:58:12 -07:00