Mirroristas/etcd

mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00

Author SHA1 Message Date

Author	SHA1	Message	Date
Piotr Tabor	ab586cd463	Persists Term in the (bbolt) Backend. Additional layer of protection, that allows to validate whether we start replaying log not only from the proper 'index', but also of the right 'term'.	2021-05-13 21:29:01 +02:00
Piotr Tabor	911204cd76	Fix `ETCDCTL_API=2 etcdctl backup --with-v3` consistent index consistency Prior to this CL, `ETCDCTL_API=2 etcdctl backup --with-v3` was readacting WAL log (by removal of some entries), but was NOT updating consistent_index in the backend. Also the WAL editing logic was buggy, as it didn't took in consideration the fact that when TERM changes, there can be entries with duplicated indexes in the log. So its NOT sufficient to subtract number of removed entries to get accurate log indexes. The PR replaces removing and shifting of WAL entries with replacing them with an no-op entries. Thanks to this consistent-index references are staying up to date. The PR also: - updates 'verification' logic to check whether consistent_index does not lag befor last snapshot - env-gated execution of verification framework in `etcdctl backup`. Tested with: ``` (./build.sh && cd tests && EXPECT_DEBUG=TRUE 'env' 'go' 'test' '-timeout=300m' 'go.etcd.io/etcd/tests/v3/e2e' -run=TestCtlV2Backup --count=1000 2>&1 \| tee TestCtlV2BackupV3.log) ```	2021-04-29 11:51:24 +02:00
Piotr Tabor	47b28b600a	Verification package: Verified given data-dir. For now verifies whete Backend.cindex is consistent with WAL log, but should get expanded to cover memberships & revisions.	2021-04-28 07:56:15 +02:00

Piotr Tabor

ab586cd463

Persists Term in the (bbolt) Backend.

Additional layer of protection, that allows to validate whether we
start replaying log not only from the proper 'index', but also of the
right 'term'.

2021-05-13 21:29:01 +02:00

Piotr Tabor

911204cd76

Fix ETCDCTL_API=2 etcdctl backup --with-v3 consistent index consistency

Prior to this CL, `ETCDCTL_API=2 etcdctl backup --with-v3` was readacting WAL log
(by removal of some entries), but was NOT updating consistent_index in the backend.
Also the WAL editing logic was buggy, as it didn't took in consideration the fact
that when TERM changes, there can be entries with duplicated indexes in
the log. So its NOT sufficient to subtract number of removed entries to
get accurate log indexes.

The PR replaces removing and shifting of WAL entries with replacing them with an no-op entries.
Thanks to this consistent-index references are staying up to date.

The PR also:
  - updates 'verification' logic to check whether consistent_index does not lag befor last snapshot
  - env-gated execution of verification framework in `etcdctl backup`.

Tested with:
```
(./build.sh && cd tests && EXPECT_DEBUG=TRUE 'env' 'go' 'test' '-timeout=300m' 'go.etcd.io/etcd/tests/v3/e2e' -run=TestCtlV2Backup --count=1000 2>&1 | tee TestCtlV2BackupV3.log)
```

2021-04-29 11:51:24 +02:00

Piotr Tabor

47b28b600a

Verification package: Verified given data-dir.

For now verifies whete Backend.cindex is consistent with WAL log,
but should get expanded to cover memberships & revisions.

2021-04-28 07:56:15 +02:00

3 Commits