Sergey Kacheev
baf594b24a
etcdserver: add zap.AddCallerSkip in NewRaftLoggerZap
...
The file `zap_raft.go` adds the raft.Logger proxy logger on top of `*zap.Logger`.
Adding a proxy requires adding the option `zap.AddCallerSkip(1)`,
so that the logging message specifies the correct caller,
two of the three constructors in the `zap_raft.go` adds this option.
This commit fixes the third constructor so that it also adds `zap.AddCallerSkip`.
Before fix:
`{"level":"info","ts":"2021-07-22T17:46:01.435Z","logger":"raft","caller":"etcdserver/zap_raft.go:77","msg":"bd07d29169ff0c5a [logterm: 2, index: 8, vote: 38447ba545569bbe] ignored MsgPreVote from c7baeaad79d6d5ed [logterm: 2, index: 8] at term 2: lease is not expired (remaining ticks: 10)"}`
After fix:
`{"level":"info","ts":"2021-07-22T17:46:51.227Z","logger":"raft","caller":"raft/raft.go:859","msg":"bd07d29169ff0c5a [logterm: 2, index: 8, vote: c7baeaad79d6d5ed] ignored MsgPreVote from 38447ba545569bbe [logterm: 2, index: 8] at term 2: lease is not expired (remaining ticks: 9)"}`
2021-07-23 00:36:15 +07:00
Sergey Kacheev
daf7e0350a
etcdserver: remove code duplication from the peer.send func
...
During the refactoring process, duplicate logging
of the send buffer overflow event was added.
Each of these log lines logs exactly the same information, the logging
context is sufficient to distinguish the cause.
Additionally, the unnecessary context (in parentheses) in the log
message was removed, which was necessary without the zap context (with
the old logger), but now only confuses.
2021-07-22 23:15:20 +07:00
Marek Siarkowicz
a0554a6bd3
etcdserver: Create AuthBackend interface
2021-07-20 18:09:53 +02:00
Marek Siarkowicz
6cd3633543
etcdserver: Rename membershipStore to membershipBackend
2021-07-20 17:56:52 +02:00
Marek Siarkowicz
2f31cc3fbc
etcdserver: Create AlarmBackend interface
2021-07-20 17:53:44 +02:00
Marek Siarkowicz
f6534f1e92
server: Move setting storage version to schema
2021-07-12 15:37:21 +02:00
Marek Siarkowicz
5b6f4579fb
server: Rename buckets to schema
2021-07-12 15:37:21 +02:00
Marek Siarkowicz
5e40a8b00c
server: Create storage package and move mvcc files to it
2021-07-12 15:37:21 +02:00
Marek Siarkowicz
ef6c276fae
etcdserver: Move server bootstraping to one file
2021-07-12 15:37:21 +02:00
Sahdev Zala
0cdd558361
Merge pull request #13188 from ahrtr/fix_excluded_alarm_issue
...
Skip empty query value(alarm) from the query parameter
2021-07-08 10:11:14 -04:00
Marek Siarkowicz
9824cc96ed
etcdserver: Fix typos in bootstrap
2021-07-08 13:37:19 +02:00
Marek Siarkowicz
e1fa356fac
etcdserver: Refactor standalone boostrap
2021-07-08 13:34:31 +02:00
Marek Siarkowicz
244e5c2cce
etcdserver: Unify memory storage boostrap
2021-07-07 23:36:37 +02:00
Marek Siarkowicz
a72d4462fe
etcdserver: Create boostrap wal functions
2021-07-07 23:36:35 +02:00
Marek Siarkowicz
e75dfde4cb
etcdserver: Move raft node start to just before newRaftNode
2021-07-07 23:26:37 +02:00
Marek Siarkowicz
08935247a8
etcdserver: Create raftnode based on boostrapRaft struct
2021-07-07 17:38:56 +02:00
Marek Siarkowicz
554777bba4
etcdserver: Extract boostrapRaft struct
2021-07-07 17:30:27 +02:00
Marek Siarkowicz
880673c4a0
etcdserver: Extract raftConfig function
2021-07-07 17:22:34 +02:00
Marek Siarkowicz
7d39c3c655
etcdserver: Extract boostrapSnapshotter function
2021-07-07 16:14:33 +02:00
Marek Siarkowicz
af0439490c
etcdserver: Extract cluster boostrap functions
2021-07-07 16:04:52 +02:00
Marek Siarkowicz
16b2a8b420
etcdserver: Prepare boostrap to split cluster setup
2021-07-07 15:56:43 +02:00
Marek Siarkowicz
4dd9424d11
etcdserver: Extract boostrapBackend function
2021-07-07 15:46:38 +02:00
Marek Siarkowicz
120cd5abe2
etcdserver: Extract etcdserver boostrap function
2021-07-07 15:40:54 +02:00
Marek Siarkowicz
2db193fda1
etcdserver: Fix snapshot always nil
2021-07-07 13:29:45 +02:00
ahrtr
d38c383c0d
etcdserver: skip empty alarm from the query parameter
2021-07-05 23:54:49 +08:00
Marek Siarkowicz
bf3e7033e9
etcdserver: Move Read/Update methods on Meta bucket to one place
...
There are still some left like compact keys, but they will require more
work to avoid circular dependency.
2021-07-05 13:23:53 +02:00
Piotr Tabor
1208505290
Merge pull request #13161 from serathius/membership
...
etcdserver: Membership uses MembershipStorage interface instead of directly accessing Backend
2021-07-03 11:33:38 +02:00
Piotr Tabor
6825b4da61
Merge pull request #13164 from serathius/alarm
...
etcdserver: Move put/read/delete on Alarm bucket to bucket package
2021-07-03 11:31:37 +02:00
Marek Siarkowicz
e5a026822b
etcdserver: Move put/read/delete on Alarm bucket to bucket package
2021-07-01 13:35:10 +02:00
Marek Siarkowicz
50507d5f3c
etcdserver: Membership uses MembershipStorage interface instead of directly accessing Backend
2021-06-29 16:14:06 +02:00
Marek Siarkowicz
86f68b9374
*: Add missing file licenses and Fix static analysis prevent skipping them in future
2021-06-29 12:52:02 +02:00
Marek Siarkowicz
f79d09d48b
etcdserver: Move all named keys to buckets module
2021-06-28 16:40:50 +02:00
Gyuho Lee
2a0f8f0738
Merge pull request #13145 from tangcong/fix-endpoint-health
...
fix health endpoint not usable when authentication is enabled
2021-06-25 18:33:46 -07:00
Marek Siarkowicz
e2740b4afa
server,etcdutl: Preserve etcd version in backend allowing etcdutl to read it from snapshot
2021-06-25 14:06:56 +02:00
tangcong
dd62aebfb5
fix health endpoint not usable when authentication is enabled
2021-06-25 14:02:45 +08:00
Piotr Tabor
8f9829cd2d
Merge pull request #13114 from lilic/fix-api-version
...
Bump etcd version to 3.5.0 and 3.6.0-pre
2021-06-24 14:26:17 +02:00
Piotr Tabor
72cb652332
Merge pull request #13132 from serathius/refactor-monitor
...
etcdserver: Move version monitor logic to separate module
2021-06-24 10:40:01 +02:00
Marek Siarkowicz
823f85dfc9
etcdserver: Move version monitor logic to separate module
2021-06-23 19:27:29 +02:00
Lili Cosic
b9d837183a
server/etcdserver/api: Add 3.6 to supported version
2021-06-22 12:25:39 +02:00
Marek Siarkowicz
e1b1d93548
*: Snapshot returns local etcd version
...
Co-authored-by: Lili Cosic <cosiclili@gmail.com>
2021-06-14 16:36:50 +02:00
Gyuho Lee
ed790d9639
Merge pull request #13086 from dlowe/crash-on-missing-permission
...
etcdserver: don't attempt to grant nil permission to a role
2021-06-04 15:13:20 -07:00
J. David Lowe
115c694af6
etcdserver: don't attempt to grant nil permission to a role
...
Prevent etcd from crashing when given a bad grant payload, e.g.:
$ curl -d '{"name": "foo"}' http://localhost:2379/v3/auth/role/add
{"header":{"cluster_id":"14841639068965178418", ...
$ curl -d '{"name": "foo"}' http://localhost:2379/v3/auth/role/grant
curl: (52) Empty reply from server
2021-06-04 14:20:02 -07:00
J. David Lowe
8552d8ec20
etcdserver: don't activate alarm w/missing AlarmType
...
Narrowly prevent etcd from crashing when given a bad ACTIVATE payload, e.g.:
$ curl -d "{\"action\":\"ACTIVATE\"}" ${ETCD}/v3/maintenance/alarm
curl: (52) Empty reply from server
2021-06-04 12:18:56 -07:00
Gyuho Lee
57034e1b51
Merge pull request #13075 from wilsonwang371/no-unnecessary-proto_size
...
server: skip unnecessary sprintf which executes proto.Size()
2021-06-03 13:10:11 -07:00
Wilson Wang
11edc76b15
server: skip unnecessary sprintf which executes proto.Size()
2021-06-03 12:58:42 -07:00
Piotr Tabor
f15e0b8237
integration.BeforeTest can be run without leak-detection.
2021-05-27 20:55:11 +02:00
Sahdev Zala
05674c87fb
Merge pull request #13018 from ipixiu/feature/bolt-compaction-sleep-interval
...
add bolt compaction sleep interval
2021-05-25 10:06:47 -04:00
AlexStocks
184b0e5d49
add sleep interval
2021-05-24 16:22:00 +08:00
Pavan BG
d9c5e1f0a2
*: Replace internal testutil AssertEqual function in favour of github.com/stretchr/testify/assert.Equals
...
To maintain uniformity in testing methodology, assert.Equals has been used everywhere while replacing testutil.AssertEqual
Fixes #13015
2021-05-20 19:55:45 +05:30
Piotr Tabor
788bc5359d
Merge pull request #13000 from ptabor/20210519-shouldApplyV3
...
applyV2 should apply on backend only once
2021-05-19 02:09:36 +02:00