Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
20,814 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

1560 Commits

Author SHA1 Message Date
Marek Siarkowicz
57d9a7eec6
Merge pull request #16756 from serathius/robustness-reorder-validation 
Refactor and reorder validation to avoid reporting multiple correlated failures
 2023-10-13 18:12:25 +02:00
Marek Siarkowicz
b02798e946 Refactor and reorder validation to avoid reporting multiple corelated failures 
It doesn't make sense to report watch failure if key value operations
are not linearizable.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-13 14:06:13 +02:00
Benjamin Wang
a92e0de316
Merge pull request #16753 from fuweid/deflake-TestEtcdTLSVersion 
tests: deflake TestEtcdTLSVersion
 2023-10-13 10:28:04 +01:00
Wei Fu
6f95ea04be tests: deflake TestEtcdTLSVersion 
The proc.Stop just sends the SIGTERM to etcd server. The etcd server
needs time to teardown. If we don't wait for it, the etcd server will
hold the port and then next test case, like TestGrpcProxyAutoSync, will
fail to listen on the port 20000.

```bash
file_/__w/etcd/etcd/tests/fixtures/server.crt_--peer-key-file_/__w/etcd/etcd/tests/fixtures/server.key.insecure_--cert-file_/__w/etcd/etcd/tests/fixtures/server2.crt_--key-file_/__w/etcd/etcd/tests/fixtures/server2.key.insecure_--tls-min-version_TLS1.2_--tls-max-version_TLS1.3) (32856): {"level":"info","ts":"2023-10-13T06:12:32.718845Z","caller":"embed/etcd.go:394","msg":"closing etcd server","name":"e1","data-dir":"/tmp/TestEtcdTLSVersion284993522/001","advertise-peer-urls":["https://127.0.0.1:20000"],"advertise-client-urls":["https://0.0.0.0:0"]}
2023-10-13T06:12:32.7399709Z --- PASS: TestEtcdTLSVersion (1.03s)
2023-10-13T06:12:32.7400181Z === RUN   TestGrpcProxyAutoSync
2023-10-13T06:12:32.7401203Z     logger.go:130: 2023-10-13T06:12:32.719Z	INFO	starting server...	{"name": "TestGrpcProxyAutoSync-test-0"}
2023-10-13T06:12:32.7408306Z     logger.go:130: 2023-10-13T06:12:32.719Z	INFO	spawning process	{"args": ["/__w/etcd/etcd/bin/etcd", "--name=TestGrpcProxyAutoSync-test-0", "--listen-client-urls=http://localhost:20000", "--advertise-client-urls=http://localhost:20000", "--listen-peer-urls=http://localhost:20001", "--initial-advertise-peer-urls=http://localhost:20001", "--initial-cluster-token=new", "--data-dir", "/tmp/TestGrpcProxyAutoSync1139610722/001", "--snapshot-count=10000", "--initial-cluster-token=new", "--initial-cluster=TestGrpcProxyAutoSync-test-0=http://localhost:20001", "--initial-cluster-state=new"], "working-dir": "/__w/etcd/etcd/tests/e2e", "name": "TestGrpcProxyAutoSync-test-0", "environment-variables": ["ETCD_VERIFY=all", "EXPECT_DEBUG=true", "PATH=/__t/go/1.21.3/x64/bin:/go/bin:/__t/go/1.21.3/x64/bin:/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin", "ETCD_UNSUPPORTED_ARCH=amd64"]}

...

2023-10-13T06:12:32.7559855Z /__w/etcd/etcd/bin/etcd (TestGrpcProxyAutoSync-test-0) (32863): {"level":"fatal","ts":"2023-10-13T06:12:32.735191Z","caller":"etcdmain/etcd.go:181","msg":"discovery failed","error":"listen tcp 127.0.0.1:20000: bind: address already in use","stacktrace":"go.etcd.io/etcd/server/v3/etcdmain.startEtcdOrProxyV2\n\tgo.etcd.io/etcd/server/v3/etcdmain/etcd.go:181\ngo.etcd.io/etcd/server/v3/etcdmain.Main\n\tgo.etcd.io/etcd/server/v3/etcdmain/main.go:40\nmain.main\n\tgo.etcd.io/etcd/server/v3/main.go:31\nruntime.main\n\truntime/proc.go:267"}
```

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-10-13 16:48:37 +08:00
Marek Siarkowicz
c34ccfbc06 Dynamically generate flags passed to etcd binary 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-12 17:31:56 +02:00
Marek Siarkowicz
2c86103472
Merge pull request #16748 from serathius/test-dynamic-flags-v2 
Test dynamic flags v2
 2023-10-12 17:26:18 +02:00
Marek Siarkowicz
c71f60e797 Remove duplicated test 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-12 14:09:31 +02:00
Marek Siarkowicz
05cc60a539 Use contain to make tests clearer and more resilient to changes 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-12 14:09:31 +02:00
Marek Siarkowicz
6f63f4b676 Use single string to define a flag allowing for easier testing 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-12 14:09:29 +02:00
Marek Siarkowicz
d69378bbbd
Merge pull request #16747 from serathius/test-dynamic-flags 
Add tests to prepare to dynamic flag generation
 2023-10-12 10:47:11 +02:00
Marek Siarkowicz
6d9a0a40b0 Add tests to prepare to dynamic flag generation 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-11 23:31:39 +02:00
Allen Ray
e4c0eb7712 bump google.golang.org/grpc to v1.58.3 
Signed-off-by: Allen Ray <alray@redhat.com>
 2023-10-11 10:39:05 -04:00
Allen Ray
3a61187ce3 bump golang.org/x/net to v0.17.0 
Address CVE-2023-39325 and CVE-2023-44487

Signed-off-by: Allen Ray <alray@redhat.com>
 2023-10-11 10:09:14 -04:00
Marek Siarkowicz
9f40116fa0 Return to default write scheduler since golang.org/x/net@v0.11.0 started using round robin 
Introduction of round robin 120fc906b3
Added in v0.10.0 https://github.com/golang/net/compare/v0.10.0...v0.11.0

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-10 16:31:42 +02:00
Sharath Sivakumar
d884580432
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.44.0 to 0.45.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2023-10-10 11:50:54 +02:00
Sharath Sivakumar
c94deb9511
dependency: bump github.com/prometheus/client_model from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2023-10-10 11:49:36 +02:00
Sharath Sivakumar
1b1c42a7aa
dependency: bump golang.org/x/net from 0.15.0 to 0.16.0 
Signed-off-by: Sharath Sivakumar <mailssr9@gmail.com>
 2023-10-10 11:49:35 +02:00
Marek Siarkowicz
de39c75053
Merge pull request #16711 from serathius/robustness-fix-profile 
Fix providing profile to robustness tests
 2023-10-09 09:52:55 +02:00
Marek Siarkowicz
b4d54922eb Fix providing profile to robustness tests 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-08 21:27:22 +02:00
Marek Siarkowicz
f5e82260da Fix parsing failpoint names when failpoint has value set 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-07 18:20:18 +02:00
Marek Siarkowicz
05a77032fc Inject sleep during etcd bootstrap to reproduce https://github.com/etcd-io/etcd/issues/16666 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-07 12:31:56 +02:00
Marek Siarkowicz
3f859a626b
Merge pull request #16695 from serathius/watch-validation-revision 
Fix watch validation assuming that client requesting older watch revision
 2023-10-05 19:17:51 +02:00
Marek Siarkowicz
6a96ab7c09
Merge pull request #16688 from serathius/e2e-default-config 
Use default embed config in e2e tests
 2023-10-05 14:54:18 +02:00
Marek Siarkowicz
c1fb2c2316 Use default embed config in e2e tests 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-05 14:17:45 +02:00
Marek Siarkowicz
c2655b4112 Fix watch validation assuming that client requesting older watch revision 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-05 14:09:43 +02:00
Marek Siarkowicz
f3196e3bbd Avoid timing out and provide a proper error in TestCtlV3GetFormat test 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-05 11:29:39 +02:00
Benjamin Wang
b385121bec test: add test cases to verify consistent reading right after writing 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2023-10-04 15:26:44 +01:00
Marek Siarkowicz
1c5289dd73
Merge pull request #16677 from serathius/revert-13525 
Revert "etcd server shouldn't wait for the ready notification infinitely on startup"
 2023-10-04 11:49:11 +02:00
James Blair
074d79652d
depdendency: bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2023-10-04 11:10:01 +13:00
James Blair
aac8919b17
depdendency: bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.18.0 to 1.19.0. 
Signed-off-by: James Blair <mail@jamesblair.net>
 2023-10-04 11:06:38 +13:00
Marek Siarkowicz
e31de5e3c1 Revert "etcd server shouldn't wait for the ready notification infinitely on startup" 
This reverts commit 1713dc67b5149e74cd28bad7c080c646315d0b06.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-03 21:37:18 +02:00
Marek Siarkowicz
11b441b605 Reuse embed.Config in e2e cluster config 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2023-10-01 09:56:31 +02:00
Benjamin Wang
b8103b0fe4 test: fix the TestCtlV3ConsistentMemberList: set the wait-cluster-ready-timeout as 1ns 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2023-09-30 14:21:26 +01:00
Benjamin Wang
0b8cad83d1 address the review comments 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2023-09-29 12:58:18 +01:00
Benjamin Wang
628b45c099 test: add a test case to verify consistent memberlist on bootstrap 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2023-09-28 20:04:47 +01:00
Benjamin Wang
cfd35afe93
Merge pull request #16636 from ahrtr/grpc_20230925 
dependency: bump some dependencies
 2023-09-26 12:31:09 +01:00
Benjamin Wang
4d486a2332 bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.17.0 to 1.18.0 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2023-09-25 21:00:55 +01:00
Benjamin Wang
10cddaaf7c bump go.opentelemetry.io/otel/sdk from 1.17.0 to 1.18.0 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2023-09-25 20:59:30 +01:00
Benjamin Wang
df7f2d93f8 dependency: bump google.golang.org/grpc from 1.58.1 to 1.58.2 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2023-09-25 20:53:56 +01:00
Wei Fu
8870cb3070 *: fix unconvert linter 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-09-25 19:40:45 +08:00
Wei Fu
4704a5af3a *: fix unused issue 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-09-25 19:37:18 +08:00
Wei Fu
07effc4d0a *: fix revive linter 
Remove old revive_pass in the bash scripts and migirate the revive.toml
into golangci linter_settings.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-09-24 14:21:11 +08:00
Benjamin Wang
e1ebc260a9
Merge pull request #16628 from fuweid/fix-goimports 
*: fix goimports linter
 2023-09-22 10:26:14 +01:00
sharathsivakumar
443ee6eb40
dependency: bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc from 0.43.0 to 0.44.0 
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
 2023-09-21 20:07:07 +02:00
sharathsivakumar
2048a638fc
dependency: bump google.golang.org/grpc from 1.58.0/1.57.0 to 1.58.1 
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
 2023-09-21 19:54:54 +02:00
sharathsivakumar
eef790399e
dependency: bump go.uber.org/zap from 1.25.0 to 1.26.0 
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
 2023-09-21 19:41:16 +02:00
Wei Fu
aa97484166 *: enable goimports in verify-lint 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-09-21 21:14:09 +08:00
Wei Fu
9c3edfa0af *: fix staticcheck lint 
Changed TraceKey/StartTimeKey/TokenFieldNameGRPCKey to struct{} to
follow the correct usage of context. Similar patch to #8901.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-09-21 11:24:26 +08:00
Wei Fu
df86cadd8b *: fix ineffassign lint 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2023-09-19 22:19:19 +08:00
Benjamin Wang
36403e3909
Merge pull request #16608 from fuweid/fix-shadow-vet 
*: fix govet-shadow lint
 2023-09-19 15:09:05 +01:00