Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
18,844 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

1109 Commits

Author SHA1 Message Date
Bhargav Ravuri
2feec4fe68 comments: fix comments as per goword in go test files 
Comments fixed as per goword in go test files that shell
function go_srcs_in_module lists as per changes on #14827

Helps in #14827

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
 2022-11-23 23:05:42 +05:30
Andrew Sims
f656fa0f49 add missing copyright headers 
Signed-off-by: Andrew Sims <andrew.cameron.sims@gmail.com>
 2022-11-23 19:13:43 +11:00
Benjamin Wang
ebfcaaed34 test: fix the test failures in e2e/warning_logging_test.go 
1. Fixed the test failures which are caused by recent test framework rafactoring;
2. renamed the file to promote_experimental_flag_test.go.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-11-19 01:51:06 +08:00
Bogdan Kanivets
7e8ebf7727 server: added duplicate warning-unary-request-duration flag 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes https://github.com/etcd-io/etcd/issues/13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
 2022-11-18 18:06:00 +08:00
Sasha Melentyev
c3b6cbdb73 all: goimports -w . 
Signed-off-by: Sasha Melentyev <sasha@melentyev.io>
 2022-11-17 19:07:04 +03:00
Benjamin Wang
8438ddae3e
Merge pull request #14767 from sashamelentyev/print 
all: Change Printf and friends to Print if there is no formatting
 2022-11-16 10:38:20 +08:00
Sasha Melentyev
2c9c209eb6 all: Changing Printf and friends to Print if there is no formatting 
Signed-off-by: Sasha Melentyev <sasha@melentyev.io>
 2022-11-15 22:11:23 +03:00
Marek Siarkowicz
f96957adba tests: Add compact failpoints 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-11-15 14:59:03 +01:00
Benjamin Wang
39ca876f38
Merge pull request #14757 from ahrtr/add_failpoint_20221115 
etcdserver: add failpoints for backend
 2022-11-15 17:14:14 +08:00
Benjamin Wang
4f824336ad etcdserver: add two failpoints for backend 
1. before and after create boltDB transaction;
2. before and after writebuf back to read buffer;

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-11-15 08:09:05 +08:00
Sasha Melentyev
006e747a44 all: Change time unit 
Signed-off-by: Sasha Melentyev <sasha@melentyev.io>
 2022-11-15 01:15:01 +03:00
Benjamin Wang
3f18816e7d etcdserver: add gofail points before and after OnPreCommitUnsafe 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-11-14 11:02:18 +08:00
Benjamin Wang
f77b8a735f etcdserver: populate HashRevision when responding to leader or client's HashKV request 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-11-14 08:33:44 +08:00
Benjamin Wang
5a3ef953eb etcdserver: call the OnPreCommitUnsafe in unsafeCommit 
`unsafeCommit` is called by both `(*batchTxBuffered) commit` and
`(*backend) defrag`. When users perform the defragmentation
operation, etcd doesn't update the consistent index. If etcd
crashes(e.g. panicking) in the process for whatever reason, then
etcd replays the WAL entries starting from the latest snapshot,
accordingly it may re-apply entries which might have already been
applied, eventually the revision isn't consistent with other members.

Refer to discussion in https://github.com/etcd-io/etcd/pull/14685

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-11-11 10:57:15 +08:00
Nathan VanBenschoten
0f9d7a4f95 raft: make Message.Snapshot nullable, halve struct size 
This commit makes the rarely used `raftpb.Message.Snapshot` field nullable.
In doing so, it reduces the memory size of a `raftpb.Message` message from
264 bytes to 128 bytes — a 52% reduction in size.

While this commit does not change the protobuf encoding, it does change
how that encoding is used. `(gogoproto.nullable) = false` instruct the
generated proto marshaling logic to always encode a value for the field,
even if that value is empty. `(gogoproto.nullable) = true` instructs the
generated proto marshaling logic to omit an encoded value for the field
if the field is nil.

This raises compatibility concerns in both directions. Messages encoded
by new binary versions without a `Snapshot` field will be decoded as an
empty field by old binary versions. In other words, old binary versions
can't tell the difference. However, messages encoded by old binary versions
with an empty Snapshot field will be decoded as a non-nil, empty field by
new binary versions. As a result, new binary versions need to be prepared
to handle such messages.

While Message.Snapshot is not intentionally part of the external interface
of this library, it was possible for users of the library to access it and
manipulate it. As such, this change may be considered a breaking change.

Signed-off-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
 2022-11-09 17:35:52 +00:00
Marek Siarkowicz
f482f7b4a4
Merge pull request #14705 from serathius/raftapi 
raft: Remove dependency on etcd api
 2022-11-08 14:52:57 +01:00
Marek Siarkowicz
2a1055c7f3 raft: Remove dependency on etcd api 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-11-08 13:56:46 +01:00
Benjamin Wang
2ac149b96a etcdserver: fix log typo when checking version compatiblity 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-11-08 18:27:46 +08:00
Benjamin Wang
c967715d93 auth: protect all maintainence APIs when auth is enabled 
All maintenance APIs require admin privilege when auth is enabled,
otherwise, the request will be rejected. If auth isn't enabled,
then no such requirement any more.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-11-03 04:39:42 +08:00
Cenk Alti
580a86ebe5
server: add more context to panic message 
Signed-off-by: Cenk Alti <cenkalti@gmail.com>
 2022-10-31 20:29:15 -04:00
Hitoshi Mitake
b7146f8f33 server: add a unit test case for authStore.Reocver() with empty rangePermCache 
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
 2022-10-29 12:54:34 +09:00
nic-chen
6f6275e1ab chore: update the warn message on startup when the server name is default 
Signed-off-by: nic-chen <chenjunxu6@gmail.com>
 2022-10-28 20:56:45 +08:00
Oleg Guba
fbed8cb645 etcdserver: call refreshRangePermCache on Recover() in AuthStore 
Signed-off-by: Oleg Guba <oleg@dropbox.com>
 2022-10-27 15:05:05 -07:00
Benjamin Wang
1e124262bc
Merge pull request #14613 from nic-chen/fix/duplicate-cluster-name 
fix: add a warning message on startup if the server name is default
 2022-10-27 09:25:21 +08:00
nic-chen
191fb306ef fix: apply review suggestion 
Signed-off-by: nic-chen <chenjunxu6@gmail.com>
 2022-10-27 08:23:22 +08:00
nic-chen
d4fbfb8cfb fix: add a warning message on startup if the server name is default 
Signed-off-by: nic-chen <chenjunxu6@gmail.com>
 2022-10-26 23:30:25 +08:00
Marek Siarkowicz
f215cd89d2
Merge pull request #14612 from spacewander/azq 
chore: commit the change generated by scripts/genproto.sh
 2022-10-24 20:00:52 +02:00
spacewander
3a63a0d5e3 chore: commit the change generated by scripts/genproto.sh 
TODO: ensure the generated code is up-to-date in the CI.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
 2022-10-23 21:13:55 +08:00
Samuele Resca
b58f9c27e4 Refactoring code to remove duplicate code test. 
Signed-off-by: Samuele Resca <sr7@ad.datcon.co.uk>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
 2022-10-23 13:46:10 +01:00
Samuele Resca
3d9c5c6166 Adding fuzz test on v3rpc interfaces. 
Signed-off-by: Samuele Resca <sr7@ad.datcon.co.uk>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
 2022-10-23 13:46:10 +01:00
qsyqian
1771cec23d lessor: refactor expireExists to make it more clear 
Signed-off-by: qsyqian <qsyqian@gmail.com>
 2022-10-20 09:26:04 +08:00
Benjamin Wang
5e791a0a59
Merge pull request #14588 from serathius/downgrade-proceed 
server: Handle cluster version equal downgrade version
 2022-10-18 06:58:25 +08:00
Atul Kumar
24bd276915 Version parameter for the doc link. 
Co-authored-by: Benjamin Wang <wachao@vmware.com>
Signed-off-by: Atul Kumar <atul.kumar@swiggy.in>
 2022-10-17 17:07:51 +05:30
Atul Kumar
55df4e6ef3 etcdmain: Updates v3.5 supported platform docs 
Signed-off-by: Atul Kumar (katul979@gmail.com)
Signed-off-by: Atul Kumar <atul.kumar@swiggy.in>
 2022-10-17 17:07:51 +05:30
Marek Siarkowicz
2b178fdd96 server: Handle cluster version equal downgrade version 
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
 2022-10-17 12:05:57 +02:00
Benjamin Wang
d15a9d0edc
Merge pull request #14457 from jbml/hashbyrev_compact_main 
etcdserver: fix corruption check when server has just been compacted
 2022-10-13 15:17:38 +08:00
Benjamin Wang
b48641e5f2
Merge pull request #14348 from VinozzZ/add-integration-test-for-tracing 
embed: add integration test for distributed tracing
 2022-10-13 02:11:59 +08:00
Benjamin Wang
5746d6eb86 etcdserver: added more debug log for the purgeFile goroutine 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-10-12 17:32:33 +08:00
Benjamin Wang
1ccdb3762d Test: fix all corruption detection related unit test cases 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-30 06:06:41 +08:00
Benjamin Wang
d116d02e04 etcdserver: update corrupt hash detection's logic 
get peer's hash using the same revision as the value used by leader

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-30 06:03:50 +08:00
Benjamin Wang
abef537a90
Merge pull request #14515 from spongecaptain/btree-generics 
upate:use google/btree in the genric way
 2022-09-27 16:44:13 +08:00
wathenjiang
319db38b0a update: add benchmark test 
benchmark result:
(1) master branch
$ go test -bench='BenchmarkIndexPut$' -count=5
goos: darwin
goarch: amd64
pkg: go.etcd.io/etcd/server/v3/storage/mvcc
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkIndexPut-12             1000000              2591 ns/op
BenchmarkIndexPut-12             1000000              2531 ns/op
BenchmarkIndexPut-12             1000000              2536 ns/op
BenchmarkIndexPut-12             1000000              2546 ns/op
BenchmarkIndexPut-12             1000000              2538 ns/op
PASS
ok      go.etcd.io/etcd/server/v3/storage/mvcc  167.439s

$ go test -bench='BenchmarkIndexGet$' -count=5
goos: darwin
goarch: amd64
pkg: go.etcd.io/etcd/server/v3/storage/mvcc
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkIndexGet-12             1000000              2021 ns/op
BenchmarkIndexGet-12             1000000              2029 ns/op
BenchmarkIndexGet-12             1000000              2044 ns/op
BenchmarkIndexGet-12             1000000              1973 ns/op
BenchmarkIndexGet-12             1000000              2027 ns/op
PASS
ok      go.etcd.io/etcd/server/v3/storage/mvcc  177.815s

(2) google/btree in the generic way
$ go test -bench='BenchmarkIndexPut$' -count=5
goos: darwin
goarch: amd64
pkg: go.etcd.io/etcd/server/v3/storage/mvcc
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkIndexPut-12             1000000              2477 ns/op
BenchmarkIndexPut-12             1000000              2380 ns/op
BenchmarkIndexPut-12             1000000              2360 ns/op
BenchmarkIndexPut-12             1000000              2396 ns/op
BenchmarkIndexPut-12             1000000              2382 ns/op
PASS
ok      go.etcd.io/etcd/server/v3/storage/mvcc  165.841s

$ go test -bench='BenchmarkIndexGet$' -count=5
goos: darwin
goarch: amd64
pkg: go.etcd.io/etcd/server/v3/storage/mvcc
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkIndexGet-12             1000000              1985 ns/op
BenchmarkIndexGet-12             1000000              1914 ns/op
BenchmarkIndexGet-12             1000000              1900 ns/op
BenchmarkIndexGet-12             1000000              1905 ns/op
BenchmarkIndexGet-12             1000000              1894 ns/op
PASS
ok      go.etcd.io/etcd/server/v3/storage/mvcc  177.573s

Signed-off-by: wathenjiang <wathenjiang@tencent.com>
 2022-09-27 14:33:02 +08:00
Spongecaptain
c53dfc7c5b upate:use google/btree in the genric way 
Signed-off-by: wathenjiang <wathenjiang@tencent.com>
 2022-09-27 10:16:15 +08:00
Benjamin Wang
1c20ed2cc5
Merge pull request #14521 from lovehhf/remove_pick_peer_url 
membership: Remove PickPeerURL Method
 2022-09-27 02:10:35 +08:00
Hongfei Huang
f6d808736c membership: Remove PickPeerURL Method 
PickPeerURL only used by unit test

Signed-off-by: Hongfei Huang <853885165@qq.com>
 2022-09-26 23:21:10 +08:00
Kafuu Chino
f1d4935e91 *: avoid closing a watch with ID 0 incorrectly 
Signed-off-by: Kafuu Chino <KafuuChinoQ@gmail.com>

add test
 2022-09-26 20:30:33 +08:00
Benjamin Wang
434c7c4309
Merge pull request #14506 from SimFG/main 
wal: Fix the `walWriteBytes` metric
 2022-09-26 09:36:07 +08:00
Jeremy Leach
cc1e245368 etcdserver: fix corruption check when server has just been compacted 
When a key-value store corruption check happens immediately after a
compaction, the revision at which the key-value store hash is computed,
is the compacted revision itself.
In that case, the hash computation logic was incorrect because it
returned an ErrCompacted error; this error should instead be returned when
the revision at which the key-value store is hashed, is strictly lower
than the compacted revision.

Fixes #14325

Signed-off-by: Jeremy Leach <44558776+jbml@users.noreply.github.com>
 2022-09-24 22:20:26 +10:00
SimFG
5702765729 wal: Fix the walWriteBytes metric 
Signed-off-by: SimFG <1142838399@qq.com>
 2022-09-22 19:23:06 +08:00
Benjamin Wang
9097e61b40 etcdserve: revert the etcdserver side change for the data loss on one node cluster 
Since the raft side change has been merged, so we need to revert the etcdserver
side change.
Refer to
  https://github.com/etcd-io/etcd/pull/14413
  https://github.com/etcd-io/etcd/pull/14400

Signed-off-by: Benjamin Wang <wachao@vmware.com>
 2022-09-22 15:19:20 +08:00