Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,033 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

48 Commits

Author SHA1 Message Date
Gyu-Ho Lee
2fa2c6284e clientv3: add 'prevKV' field to watch request 2016-10-07 14:22:58 -07:00
Anthony Romano
e853451cd2 clientv3: only return closing error to watcher if context is not canceled 
Fixes #6503
 2016-10-05 14:19:32 -07:00
Anthony Romano
1becf9d2f5 clientv3: fix race on watch initial revision 
The initial revision was being updated in the substream goroutine defer;
this was racing with the resume path fetching the initial revision when
the substream closes during resume. Instead, update the initial revision
whenever the substream processes a new watch response. Since the substream
cannot receive a watch response while it is resuming, the write to the
initial revision is ordered to always happen after the resume read.

Fixes #6586
 2016-10-05 10:56:36 -07:00
Anthony Romano
1a712cf187 clientv3: make IsProgressNotify() false on compact event and closed channel 
Fixes #6549
 2016-10-04 15:13:02 -07:00
Anthony Romano
b836d187fd clientv3: simplify watch synchronization 
Was more complicated than it needed to be and didn't really work in the
first place. Restructured watcher registation to use a queue.
 2016-10-04 15:12:18 -07:00
Anthony Romano
273b986751 clientv3: process closed watcherStreams in watcherGrpcStream run loop 
Was racing with Watch() when closing the grpc stream on no watchers.

Fixes #6476
 2016-09-21 15:52:20 -07:00
Anthony Romano
4abc381ebe clientv3: drain buffered WatchResponses before resuming 
Otherwise, the watcherStream can receive WatchResponses in the
middle of a resume, corrupting the stream.

Fixes #6364
 2016-09-15 12:38:15 -07:00
Anthony Romano
69a97863a9 clientv3: handle watchGrpcStream shutdown if prior to goroutine start 
Fixes #6141
 2016-08-09 20:59:09 -07:00
Anthony Romano
12c7e4a9f8 clientv3: close watcher stream once all watchers detach 
Fixes #6134
 2016-08-09 10:44:21 -07:00
Anthony Romano
129b271ff8 clientv3: use grpc.FailFast(false) for all calls 2016-07-14 19:00:46 -07:00
Anthony Romano
4b42ea6cd7 clientv3: only use closeErr on watch when donec is closed 
Fixes #5800
 2016-06-28 17:48:44 -07:00
Anthony Romano
722f5b2a8c clientv3: watch with arbitrary ctx values 
Sets up a new watch stream for every unique set of ctx values.

Fixes #5354
 2016-06-20 12:44:51 -07:00
Anthony Romano
62f8ec25c0 clientv3: use grpc reconnection logic 2016-06-08 01:04:59 -07:00
Anthony Romano
267d1cb16f clientv3: fix watch to reconnect on failure 
It was spinning before.
 2016-06-03 10:25:20 -07:00
Gyu-Ho Lee
75dc10574a clientv3: watch resp with error when client close 2016-06-01 10:39:48 -07:00
Gyu-Ho Lee
f9306fb817 clientv3: preallocate watch streams slice 
To avoid slice growth when appending
 2016-05-19 12:55:55 -07:00
Gyu-Ho Lee
86c85b88ad Merge pull request #5377 from purpleidea/bug/typos 
clientv3: fix typos
 2016-05-17 12:51:13 -07:00
James Shubin
42f3b4964f clientv3: fix typos 2016-05-17 15:39:56 -04:00
Gyu-Ho Lee
fd9e07a529 clientv3: update LICENSE header 2016-05-12 20:50:58 -07:00
Anthony Romano
712090fc09 clientv3: keep watcher client active if reconnect has network error 
Otherwise watchers created after a long disconnect period will always
close immediately.
 2016-05-05 19:30:11 -07:00
Anthony Romano
cdc8f99658 clientv3: rework reconnection logic 
Avoids go routine flood for tight loops with a dead connection.
Now uses request ctx when reconnecting for immediate retry.
 2016-05-05 19:30:11 -07:00
Anthony Romano
8b52fd0d2d clientv3: gracefully handle watcher resume on compacted revision 
Fixes #5239
 2016-05-03 09:30:53 -07:00
Gyu-Ho Lee
2e3d79a7bf clientv3: convert errors to rpctypes on returning 
For https://github.com/coreos/etcd/issues/5211.
 2016-04-28 15:39:37 -07:00
Anthony Romano
b7ac758969 *: rename storage package to mvcc 2016-04-25 15:25:51 -07:00
Hongchao Deng
aa11dafaf8 clientv3: expose event type in user API 
- add another layer of abstraction in clientv3 for user, not expose internal storagepb ones
- provide commonly used routines IsCreate(), IsModify() on event
 2016-04-07 09:47:04 -07:00
Gyu-Ho Lee
b0cc0e443c *: clean up if, bool comparison 2016-04-02 12:55:11 -07:00
Anthony Romano
4bdfc0a46d clientv3: fix race on writing watch channel over return channel 
Found in TestElectionFailover
 2016-03-28 16:08:18 -07:00
Anthony Romano
e129223dbe clientv3: fix race in watcher resume 2016-03-28 16:08:18 -07:00
Anthony Romano
bd832e5b0a *: migrate Godeps to vendor/ 2016-03-22 17:10:28 -07:00
Anthony Romano
44753594ec v3rpc: move errors to v3rpc/rpctypes 
Fixes #4771
 2016-03-17 11:52:34 -07:00
Xiang Li
e708bc14d7 Merge pull request #4689 from hongchaodeng/master 
watch.go: docs on WatchResponse.Canceled
 2016-03-04 16:09:16 -08:00
Hongchao Deng
5e017e94f9 watch.go: docs on WatchResponse.Canceled 2016-03-04 15:51:00 -08:00
Gyu-Ho Lee
450b586011 clientv3: add IsProgressNotify with example 
This makes the test endpoints same as we have in
goreman proc file, and adds 'IsProgressNotify' method
and the 'WatchProgressNotify' code example to godoc.
 2016-03-04 12:16:43 -08:00
Gyu-Ho Lee
27316196d8 clientv3: add WithProgressNotify 
Client side for https://github.com/coreos/etcd/issues/4628.
 2016-03-04 09:47:13 -08:00
Anthony Romano
1e16758029 clientv3: add Err() to WatchResponse 
Checking for number of events as a failure condition was a kludge.
 2016-03-03 15:21:04 -08:00
Anthony Romano
16c35167df clientv3: do not reconnect on request context cancellation 2016-03-03 13:43:16 -08:00
Anthony Romano
8dbc6cfd43 etcdserver: ranges in watcher rpc protocol 
protocol change so watch requests are ranges; server rejects non-prefix ranges
 2016-02-29 14:03:27 -08:00
Anthony Romano
d02b1c982f clientv3: return closed channel on Watch() cancel 
was returning nil; difficult to use correctly

Fixes #4626
 2016-02-26 12:16:41 -08:00
Gyu-Ho Lee
a78604dacb *: watch true cancel, created for wrong rev 
This sets Created and Cancel true in pb.WatchResponse
when it has received wrong start revision instead of
panic. So that clientv3 can set 'Canceled' in WatchResponse
as well.

Fix https://github.com/coreos/etcd/issues/4610.
 2016-02-24 20:56:17 -08:00
Gyu-Ho Lee
8f7948641c contrib/recipes: replace WatchPrefix with Watch 2016-02-23 20:02:24 -08:00
Gyu-Ho Lee
a24d276891 clientv3: combine Watch, WatchPrefix with variadic 
For https://github.com/coreos/etcd/issues/4598.
 2016-02-23 20:02:21 -08:00
Anthony Romano
f66162932c clientv3: fix current watcher reconnection 
If a current watcher didn't receive any events, a reconnect cycle would
advance its revision to the store's current revision. Instead, reconnect
using the watcher's creation header revision if the watcher hasn't received
any events.

Fixes #4502
 2016-02-18 15:01:57 -08:00
Anthony Romano
2415303991 clientv3: typedef <-chan WatchResponse to WatchChan 2016-02-12 14:06:59 -08:00
Anthony Romano
8e411b1b3b clientv3: send compacted revision before closing watch chan 2016-02-12 14:06:59 -08:00
Anthony Romano
ee1a03167d storage, v3: pass compaction revision through watchresponse 2016-02-12 14:06:59 -08:00
Anthony Romano
3b7bd38a2d clientv3: fix bad variable capture in watch request retry 
variables would be niled out when the goroutine runs, causing a crash
 2016-02-11 13:35:07 -08:00
Anthony Romano
580c563ed6 clientv3: watcher implementation 2016-02-01 23:21:55 -08:00
Xiang Li
205ffa5cb6 clientv3: initial watch API 2016-01-28 08:54:32 -08:00