Mirroristas/etcd
2
0
Fork 0
mirror of https://github.com/etcd-io/etcd.git synced 2024-09-27 06:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
13,213 Commits 15 Branches 491 Tags 148 MiB
Commit Graph

756 Commits

Author SHA1 Message Date
cfc4n
999df4e5a1 auth: return incorrect result 'ErrUserNotFound' when client request without username or username was empty. 
Fiexs https://github.com/etcd-io/etcd/issues/12004 .
 2020-06-24 19:10:51 +08:00
Gyuho Lee
924b8128c2 *: make sure snapshot save downloads SHA256 checksum 
ref. https://github.com/etcd-io/etcd/pull/11896

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2020-05-18 02:27:01 -07:00
Gyuho Lee
6f7ee076ea clientv3: embed api version in metadata 
ref.
https://github.com/etcd-io/etcd/pull/11687

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>

clientv3: fix racy writes to context key

=== RUN   TestWatchOverlapContextCancel

==================

WARNING: DATA RACE

Write at 0x00c42110dd40 by goroutine 99:

  runtime.mapassign()

      /usr/local/go/src/runtime/hashmap.go:485 +0x0

  github.com/coreos/etcd/clientv3.metadataSet()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/ctx.go:61 +0x8c

  github.com/coreos/etcd/clientv3.withVersion()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/ctx.go:47 +0x137

  github.com/coreos/etcd/clientv3.newStreamClientInterceptor.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/client.go:309 +0x81

  google.golang.org/grpc.NewClientStream()

      /go/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/stream.go:101 +0x10e

  github.com/coreos/etcd/etcdserver/etcdserverpb.(*watchClient).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/etcdserver/etcdserverpb/rpc.pb.go:3193 +0xe9

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).openWatchClient()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:788 +0x143

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).newWatchClient()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:700 +0x5c3

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).run()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:431 +0x12b

Previous read at 0x00c42110dd40 by goroutine 130:

  reflect.maplen()

      /usr/local/go/src/runtime/hashmap.go:1165 +0x0

  reflect.Value.MapKeys()

      /usr/local/go/src/reflect/value.go:1090 +0x43b

  fmt.(*pp).printValue()

      /usr/local/go/src/fmt/print.go:741 +0x1885

  fmt.(*pp).printArg()

      /usr/local/go/src/fmt/print.go:682 +0x1b1

  fmt.(*pp).doPrintf()

      /usr/local/go/src/fmt/print.go:998 +0x1cad

  fmt.Sprintf()

      /usr/local/go/src/fmt/print.go:196 +0x77

  github.com/coreos/etcd/clientv3.streamKeyFromCtx()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:825 +0xc8

  github.com/coreos/etcd/clientv3.(*watcher).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:265 +0x426

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:959 +0x23e

Goroutine 99 (running) created at:

  github.com/coreos/etcd/clientv3.(*watcher).newWatcherGrpcStream()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:236 +0x59d

  github.com/coreos/etcd/clientv3.(*watcher).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:278 +0xbb6

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:959 +0x23e

Goroutine 130 (running) created at:

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:979 +0x76d

  github.com/coreos/etcd/clientv3/integration.TestWatchOverlapContextCancel()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:922 +0x44

  testing.tRunner()

      /usr/local/go/src/testing/testing.go:657 +0x107

==================

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2020-03-18 17:18:29 -07:00
Gyuho Lee
5cf80a6229 clientv3: fix retry/streamer error message 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2019-10-31 10:08:53 -07:00
Joe Betz
a2f585d80c
clientv3: Set authority used in cert checks to host of endpoint 2019-10-08 18:25:08 -07:00
Joe Betz
4b227b6e71
clientv3: Replace endpoint.ParseHostPort with net.SplitHostPort to fix IPv6 client endpoints 2019-10-08 16:12:13 -07:00
Jingyi Hu
81fc7c23c2 *: fix gofmt 2019-08-19 20:22:15 -07:00
Gyuho Lee
0ddda8c72e integration: fix tests 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2019-08-14 09:32:10 -07:00
Gyuho Lee
9561f6b3b6 clientv3: rewrite based on 3.4 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2019-08-14 09:32:06 -07:00
Rohit Sardesai
8ed3e70d7c etcd: Replace ghodss/yaml with sigs.k8s.io/yaml 2019-05-29 23:03:16 +05:30
Gyuho Lee
b7001c05bc clientv3: fix race condition in "Endpoints" methods 
From https://github.com/etcd-io/etcd/pull/10595.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
 2019-05-02 10:17:58 -07:00
yura
20d83e405f clientv3: concurrency.Mutex.Lock() - preserve invariant 
Convenient invariant:
- if werr == nil then lock is supposed to be locked at the moment.

While we could not be confident in stronger invariant ('is exactly locked'),
it were inconvenient that previous code could return `werr == nil` after
Mutex.Unlock.

It could happen when ctx is canceled/timeouted exactly after waitDeletes
successfully returned werr == nil and before `<-ctx.Done()` checked.
While such situation is very rare, it is still possible.

fixes #10111
 2018-10-08 16:42:26 -07:00
Gyuho Lee
fbc0510a4e clientv3: fix keepalive send interval when response queue is full 
client should update next keepalive send time
even when lease keepalive response queue becomes full.

Otherwise, client sends keepalive request every 500ms
regardless of TTL when the send is only expected to happen
with the interval of TTL / 3 at minimum.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-07-23 08:51:18 -07:00
Jordan Liggitt
1fea97b898 clientv3: backoff on reestablishing watches when Unavailable errors are encountered 2018-06-14 10:47:46 -07:00
Gyuho Lee
d1da2023b9 clientv3/integration: test "rpctypes.ErrLeaseTTLTooLarge" 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-03-08 10:34:34 -08:00
Iwasaki Yudai
eaa0050d4d *: enforce max lease TTL with 9,000,000,000 seconds 
math.MaxInt64 / time.Second is 9,223,372,036. 9,000,000,000 is easier to
remember/document.
 2018-03-08 10:34:12 -08:00
Gyuho Lee
2aa3d91759 clientv3/integration: add TestMemberAddUpdateWrongURLs 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-01-22 11:31:45 -08:00
Gyuho Lee
1c91ddc6f4 clientv3: prevent no-scheme URLs to cluster APIs 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-01-22 11:27:25 -08:00
Gyuho Lee
bf83d5269f clientv3/integration: fix typos 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-01-09 09:11:15 -08:00
Sam Batschelet
a609b1eb47 integration: add constant RequestWaitTimeout. 2018-01-09 09:11:15 -08:00
Gyuho Lee
5e35f79087 clientv3/integration: fix TestKVLargeRequests with -tags cluster_proxy 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2018-01-02 11:07:24 -08:00
Gyuho Lee
3193f3c9ab clientv3/leasing: fix racey waitSession 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-21 17:51:03 -08:00
Gyu-Ho Lee
255476b5e5 clientv3/retry: clean up retryRPCFunc 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-12-20 12:30:33 -08:00
Gyuho Lee
88fe8de99b clientv3/integration: fix TestKVPutError 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-20 10:58:05 -08:00
Gyuho Lee
f38593bbad clientv3/integration: test large KV requests 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-20 10:58:05 -08:00
Gyuho Lee
497412c588 clientv3: call other APIs with default gRPC call options 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-20 10:58:05 -08:00
Gyuho Lee
f87760998b clientv3: call KV/Txn APIs with default gRPC call options 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-20 10:58:05 -08:00
Gyuho Lee
63d66b1011 clientv3: configure gRPC message limits in Config 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-20 10:58:01 -08:00
Gyuho Lee
b0a7623be8
Merge pull request #9023 from gyuho/keepalive-doc 
clientv3: document context to "KeepAlive" API
 2017-12-19 11:53:56 -08:00
Gyuho Lee
7cd985bdac clientv3: translate Snapshot API gRPC status error 
To be consistent with other APIs.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-19 10:46:19 -08:00
Gyuho Lee
3e58dd707f clientv3: document lease KeepAlive streaming errors 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-18 10:19:41 -08:00
Anthony Romano
da3e3b7240 clientv3: document from "don't halt lease client if there is a lease error" 
From https://github.com/coreos/etcd/pull/7866.
 2017-12-18 09:55:00 -08:00
Sam Batschelet
a5d9bff24c clientv3/lease.go: TTL, document expired Lease. 2017-12-18 08:34:19 -05:00
Manjunath A Kumatagi
18746c65da Clientv3: Fix govet error for gotip 2017-12-15 14:31:27 +05:30
Gyu-Ho Lee
805bcc828c clientv3: simplify V(4) logger with Lvl(4) 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-12-05 18:48:36 -08:00
Gyu-Ho Lee
5d2461e139 clientv3: add Lvl method to logger 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-12-05 18:48:36 -08:00
Gyuho Lee
3a941c9455 clientv3/config.go: remove extra whitespace character 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-05 14:51:36 -08:00
Gyuho Lee
6458e22708 clientv3: fix indentation in doc.go 
Looks off in https://godoc.org/github.com/coreos/etcd/clientv3.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2017-12-04 17:05:31 -08:00
Gyu-Ho Lee
6b6013fad5 clientv3/doc: update dial-timeout error handling with new gRPC 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-12-04 13:45:42 -08:00
Rene Zbinden
e18afc462b clientv3: Fix comment for DialKeepAliveTime and DialKeepAliveTimeout 2017-12-04 14:22:34 +01:00
Gyuho Lee
56a012f2ab
Merge pull request #8841 from gyuho/test-test 
clientv3/integration: add more tests on balancer switch, inflight range
 2017-11-30 09:38:53 -08:00
Gyu-Ho Lee
92167e8773 clientv3: update error handling godoc 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-29 10:53:54 -08:00
Gyu-Ho Lee
a7cb307a18 clientv3/integration: add more tests on balancer switch, inflight range 
Test all possible cases of server shutdown with inflight range requests.
Removed redundant tests in kv_test.go.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-27 15:05:12 -08:00
Gyu-Ho Lee
bd76ac85db clientv3/integration: move isServerCtxTimeout to server_shutdown_test.go 
Tests with cluster_proxy tags were failing, since isServerCtxTimeout
was defined with "+build !cluster_proxy".

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-27 15:02:48 -08:00
Gyu-Ho Lee
a9105b5a8d clientv3: document context timeout error with server-side clock skew 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-27 14:06:42 -08:00
Gyu-Ho Lee
0d0e8e78f7 clientv3/integration: handle server-side context timeouts from clock-drift 
Due to clock drifts in server-side, client context times out
first in server-side, while original client-side context is
not timed out yet.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-27 14:02:09 -08:00
Gyu-Ho Lee
5a154e8e2b *: disable gRPC client logs in tests 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-11 20:56:00 -08:00
Gyu-Ho Lee
977f33a5a6 clientv3: grpclog.SetLoggerV2 on clientv3.SetLogger 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-11 20:51:45 -08:00
Gyu-Ho Lee
75110dd839 *: fix naked returns 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-10 18:46:15 -08:00
Gyu-Ho Lee
c669ff9765 clientv3: retry mutable ops on "no connection available" 
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
 2017-11-10 15:40:06 -08:00