// Copyright 2016 The etcd Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package e2e import ( "bytes" "context" "fmt" "reflect" "sort" "strings" "testing" "github.com/coreos/go-semver/semver" "github.com/stretchr/testify/assert" "go.uber.org/zap" "go.uber.org/zap/zaptest" "go.etcd.io/etcd/client/pkg/v3/fileutil" "go.etcd.io/etcd/pkg/v3/expect" "go.etcd.io/etcd/server/v3/etcdserver" "go.etcd.io/etcd/server/v3/etcdserver/api/membership" "go.etcd.io/etcd/server/v3/etcdserver/api/snap" "go.etcd.io/etcd/server/v3/etcdserver/api/v2store" "go.etcd.io/etcd/tests/v3/framework/config" "go.etcd.io/etcd/tests/v3/framework/e2e" ) func writeCustomV2Data(t testing.TB, epc *e2e.EtcdProcessCluster, count int) { for i := 0; i < count; i++ { if err := e2e.CURLPut(epc, e2e.CURLReq{ Endpoint: "/v2/keys/foo", Value: "bar" + fmt.Sprint(i), Expected: expect.ExpectedResponse{Value: `{"action":"set","node":{"key":"/foo","value":"bar` + fmt.Sprint(i)}}); err != nil { t.Fatalf("failed put with curl (%v)", err) } } } func TestV2DeprecationNotYet(t *testing.T) { e2e.BeforeTest(t) t.Log("Verify its infeasible to start etcd with --v2-deprecation=not-yet mode") proc, err := e2e.SpawnCmd([]string{e2e.BinPath.Etcd, "--v2-deprecation=not-yet"}, nil) assert.NoError(t, err) _, err = proc.Expect(`invalid value "not-yet" for flag -v2-deprecation: invalid value "not-yet"`) assert.NoError(t, err) } func TestV2DeprecationWriteOnlyWAL(t *testing.T) { e2e.BeforeTest(t) dataDirPath := t.TempDir() if !fileutil.Exist(e2e.BinPath.EtcdLastRelease) { t.Skipf("%q does not exist", e2e.BinPath.EtcdLastRelease) } cfg := e2e.ConfigStandalone(*e2e.NewConfig( e2e.WithVersion(e2e.LastVersion), e2e.WithEnableV2(true), e2e.WithDataDirPath(dataDirPath), )) epc, err := e2e.NewEtcdProcessCluster(context.TODO(), t, e2e.WithConfig(cfg)) assert.NoError(t, err) memberDataDir := epc.Procs[0].Config().DataDirPath writeCustomV2Data(t, epc, 1) assert.NoError(t, epc.Stop()) t.Log("Verify its infeasible to start etcd with --v2-deprecation=write-only mode") proc, err := e2e.SpawnCmd([]string{e2e.BinPath.Etcd, "--v2-deprecation=write-only", "--data-dir=" + memberDataDir}, nil) assert.NoError(t, err) _, err = proc.Expect("detected disallowed v2 WAL for stage --v2-deprecation=write-only") assert.NoError(t, err) } func TestV2DeprecationWriteOnlySnapshot(t *testing.T) { e2e.BeforeTest(t) dataDirPath := t.TempDir() if !fileutil.Exist(e2e.BinPath.EtcdLastRelease) { t.Skipf("%q does not exist", e2e.BinPath.EtcdLastRelease) } cfg := e2e.ConfigStandalone(*e2e.NewConfig( e2e.WithVersion(e2e.LastVersion), e2e.WithEnableV2(true), e2e.WithDataDirPath(dataDirPath), e2e.WithSnapshotCount(10), )) epc, err := e2e.NewEtcdProcessCluster(context.TODO(), t, e2e.WithConfig(cfg)) assert.NoError(t, err) memberDataDir := epc.Procs[0].Config().DataDirPath // We need to exceed 'SnapshotCount' such that v2 snapshot is dumped. writeCustomV2Data(t, epc, 10) assert.NoError(t, epc.Stop()) t.Log("Verify its infeasible to start etcd with --v2-deprecation=write-only mode") proc, err := e2e.SpawnCmd([]string{e2e.BinPath.Etcd, "--v2-deprecation=write-only", "--data-dir=" + memberDataDir}, nil) assert.NoError(t, err) _, err = proc.Expect("detected disallowed custom content in v2store for stage --v2-deprecation=write-only") assert.NoError(t, err) } func TestV2DeprecationSnapshotMatches(t *testing.T) { e2e.BeforeTest(t) lastReleaseData := t.TempDir() currentReleaseData := t.TempDir() ctx, cancel := context.WithCancel(context.Background()) defer cancel() if !fileutil.Exist(e2e.BinPath.EtcdLastRelease) { t.Skipf("%q does not exist", e2e.BinPath.EtcdLastRelease) } var snapshotCount uint64 = 10 epc := runEtcdAndCreateSnapshot(t, e2e.LastVersion, lastReleaseData, snapshotCount) oldMemberDataDir := epc.Procs[0].Config().DataDirPath cc1 := epc.Etcdctl() members1 := addAndRemoveKeysAndMembers(ctx, t, cc1, snapshotCount) assert.NoError(t, epc.Close()) epc = runEtcdAndCreateSnapshot(t, e2e.CurrentVersion, currentReleaseData, snapshotCount) newMemberDataDir := epc.Procs[0].Config().DataDirPath cc2 := epc.Etcdctl() members2 := addAndRemoveKeysAndMembers(ctx, t, cc2, snapshotCount) assert.NoError(t, epc.Close()) assertSnapshotsMatch(t, oldMemberDataDir, newMemberDataDir, func(data []byte) []byte { // Patch members ids for i, mid := range members1 { data = bytes.Replace(data, []byte(fmt.Sprintf("%x", mid)), []byte(fmt.Sprintf("%d", i+1)), -1) } for i, mid := range members2 { data = bytes.Replace(data, []byte(fmt.Sprintf("%x", mid)), []byte(fmt.Sprintf("%d", i+1)), -1) } return data }) } func TestV2DeprecationSnapshotRecover(t *testing.T) { e2e.BeforeTest(t) dataDir := t.TempDir() ctx, cancel := context.WithCancel(context.Background()) defer cancel() if !fileutil.Exist(e2e.BinPath.EtcdLastRelease) { t.Skipf("%q does not exist", e2e.BinPath.EtcdLastRelease) } epc := runEtcdAndCreateSnapshot(t, e2e.LastVersion, dataDir, 10) cc := epc.Etcdctl() lastReleaseGetResponse, err := cc.Get(ctx, "", config.GetOptions{Prefix: true}) assert.NoError(t, err) lastReleaseMemberListResponse, err := cc.MemberList(ctx, false) assert.NoError(t, err) assert.NoError(t, epc.Close()) cfg := e2e.ConfigStandalone(*e2e.NewConfig( e2e.WithVersion(e2e.CurrentVersion), e2e.WithDataDirPath(dataDir), )) epc, err = e2e.NewEtcdProcessCluster(context.TODO(), t, e2e.WithConfig(cfg)) assert.NoError(t, err) cc = epc.Etcdctl() currentReleaseGetResponse, err := cc.Get(ctx, "", config.GetOptions{Prefix: true}) assert.NoError(t, err) currentReleaseMemberListResponse, err := cc.MemberList(ctx, false) assert.NoError(t, err) assert.Equal(t, lastReleaseGetResponse.Kvs, currentReleaseGetResponse.Kvs) assert.Equal(t, lastReleaseMemberListResponse.Members, currentReleaseMemberListResponse.Members) assert.NoError(t, epc.Close()) } func runEtcdAndCreateSnapshot(t testing.TB, serverVersion e2e.ClusterVersion, dataDir string, snapshotCount uint64) *e2e.EtcdProcessCluster { cfg := e2e.ConfigStandalone(*e2e.NewConfig( e2e.WithVersion(serverVersion), e2e.WithDataDirPath(dataDir), e2e.WithSnapshotCount(snapshotCount), e2e.WithKeepDataDir(true), )) epc, err := e2e.NewEtcdProcessCluster(context.TODO(), t, e2e.WithConfig(cfg)) assert.NoError(t, err) return epc } func addAndRemoveKeysAndMembers(ctx context.Context, t testing.TB, cc *e2e.EtcdctlV3, snapshotCount uint64) (members []uint64) { // Execute some non-trivial key&member operation var i uint64 for i = 0; i < snapshotCount*3; i++ { err := cc.Put(ctx, fmt.Sprintf("%d", i), "1", config.PutOptions{}) assert.NoError(t, err) } member1, err := cc.MemberAddAsLearner(ctx, "member1", []string{"http://127.0.0.1:2000"}) assert.NoError(t, err) members = append(members, member1.Member.ID) for i = 0; i < snapshotCount*2; i++ { _, err = cc.Delete(ctx, fmt.Sprintf("%d", i), config.DeleteOptions{}) assert.NoError(t, err) } _, err = cc.MemberRemove(ctx, member1.Member.ID) assert.NoError(t, err) for i = 0; i < snapshotCount; i++ { err = cc.Put(ctx, fmt.Sprintf("%d", i), "2", config.PutOptions{}) assert.NoError(t, err) } member2, err := cc.MemberAddAsLearner(ctx, "member2", []string{"http://127.0.0.1:2001"}) assert.NoError(t, err) members = append(members, member2.Member.ID) for i = 0; i < snapshotCount/2; i++ { err = cc.Put(ctx, fmt.Sprintf("%d", i), "3", config.PutOptions{}) assert.NoError(t, err) } return members } func filterSnapshotFiles(path string) bool { return strings.HasSuffix(path, ".snap") } func assertSnapshotsMatch(t testing.TB, firstDataDir, secondDataDir string, patch func([]byte) []byte) { lg := zaptest.NewLogger(t) firstFiles, err := fileutil.ListFiles(firstDataDir, filterSnapshotFiles) if err != nil { t.Fatal(err) } secondFiles, err := fileutil.ListFiles(secondDataDir, filterSnapshotFiles) if err != nil { t.Fatal(err) } assert.NotEmpty(t, firstFiles) assert.NotEmpty(t, secondFiles) assert.Equal(t, len(firstFiles), len(secondFiles)) sort.Strings(firstFiles) sort.Strings(secondFiles) for i := 0; i < len(firstFiles); i++ { firstSnapshot, err := snap.Read(lg, firstFiles[i]) if err != nil { t.Fatal(err) } secondSnapshot, err := snap.Read(lg, secondFiles[i]) if err != nil { t.Fatal(err) } assertMembershipEqual(t, openSnap(patch(firstSnapshot.Data)), openSnap(patch(secondSnapshot.Data))) } } func assertMembershipEqual(t testing.TB, firstStore v2store.Store, secondStore v2store.Store) { rc1 := membership.NewCluster(zaptest.NewLogger(t)) rc1.SetStore(firstStore) rc1.Recover(func(lg *zap.Logger, v *semver.Version) { return }) rc2 := membership.NewCluster(zaptest.NewLogger(t)) rc2.SetStore(secondStore) rc2.Recover(func(lg *zap.Logger, v *semver.Version) { return }) //membership should match if !reflect.DeepEqual(rc1.Members(), rc2.Members()) { t.Logf("memberids_from_last_version = %+v, member_ids_from_current_version = %+v", rc1.MemberIDs(), rc2.MemberIDs()) t.Errorf("members_from_last_version_snapshot = %+v, members_from_current_version_snapshot %+v", rc1.Members(), rc2.Members()) } } func openSnap(data []byte) v2store.Store { st := v2store.New(etcdserver.StoreClusterPrefix, etcdserver.StoreKeysPrefix) st.Recovery(data) return st }