// Copyright 2022 The etcd Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package model import ( "errors" "testing" "github.com/stretchr/testify/assert" "go.etcd.io/etcd/api/v3/mvccpb" ) func TestModelNonDeterministic(t *testing.T) { type testOperation struct { req EtcdRequest resp EtcdNonDeterministicResponse failure bool } tcs := []struct { name string operations []testOperation }{ { name: "First Get can start from non-empty value and non-zero revision", operations: []testOperation{ {req: getRequest("key"), resp: getResponse("key", "1", 42, 42)}, {req: getRequest("key"), resp: getResponse("key", "1", 42, 42)}, }, }, { name: "First Range can start from non-empty value and non-zero revision", operations: []testOperation{ {req: rangeRequest("key", true, 0), resp: rangeResponse([]*mvccpb.KeyValue{{Key: []byte("key"), Value: []byte("1")}}, 1, 42)}, {req: rangeRequest("key", true, 0), resp: rangeResponse([]*mvccpb.KeyValue{{Key: []byte("key"), Value: []byte("1")}}, 1, 42)}, }, }, { name: "First Range can start from non-zero revision", operations: []testOperation{ {req: rangeRequest("key", true, 0), resp: rangeResponse(nil, 1, 1)}, {req: rangeRequest("key", true, 0), resp: rangeResponse(nil, 1, 1)}, }, }, { name: "First Put can start from non-zero revision", operations: []testOperation{ {req: putRequest("key", "1"), resp: putResponse(42)}, }, }, { name: "First delete can start from non-zero revision", operations: []testOperation{ {req: deleteRequest("key"), resp: deleteResponse(0, 42)}, }, }, { name: "First Txn can start from non-zero revision", operations: []testOperation{ {req: compareRevisionAndPutRequest("key", 0, "42"), resp: compareRevisionAndPutResponse(false, 42)}, }, }, { name: "Get response data should match put", operations: []testOperation{ {req: putRequest("key1", "11"), resp: putResponse(1)}, {req: putRequest("key2", "12"), resp: putResponse(2)}, {req: getRequest("key1"), resp: getResponse("key1", "11", 1, 1), failure: true}, {req: getRequest("key1"), resp: getResponse("key1", "12", 1, 1), failure: true}, {req: getRequest("key1"), resp: getResponse("key1", "12", 2, 2), failure: true}, {req: getRequest("key1"), resp: getResponse("key1", "11", 1, 2)}, {req: getRequest("key2"), resp: getResponse("key2", "11", 2, 2), failure: true}, {req: getRequest("key2"), resp: getResponse("key2", "12", 1, 1), failure: true}, {req: getRequest("key2"), resp: getResponse("key2", "11", 1, 1), failure: true}, {req: getRequest("key2"), resp: getResponse("key2", "12", 2, 2)}, }, }, { name: "Range response data should match put", operations: []testOperation{ {req: putRequest("key1", "1"), resp: putResponse(1)}, {req: putRequest("key2", "2"), resp: putResponse(2)}, {req: rangeRequest("key", true, 0), resp: rangeResponse([]*mvccpb.KeyValue{{Key: []byte("key1"), Value: []byte("1"), ModRevision: 1}, {Key: []byte("key2"), Value: []byte("2"), ModRevision: 2}}, 2, 2)}, {req: rangeRequest("key", true, 0), resp: rangeResponse([]*mvccpb.KeyValue{{Key: []byte("key1"), Value: []byte("1"), ModRevision: 1}, {Key: []byte("key2"), Value: []byte("2"), ModRevision: 2}}, 2, 2)}, }, }, { name: "Range response should be ordered by key", operations: []testOperation{ {req: rangeRequest("key", true, 0), resp: rangeResponse([]*mvccpb.KeyValue{ {Key: []byte("key1"), Value: []byte("2"), ModRevision: 3}, {Key: []byte("key2"), Value: []byte("1"), ModRevision: 2}, {Key: []byte("key3"), Value: []byte("3"), ModRevision: 1}, }, 3, 3)}, }, }, { name: "Range response data should match large put", operations: []testOperation{ {req: putRequest("key", "012345678901234567890"), resp: putResponse(1)}, {req: getRequest("key"), resp: getResponse("key", "123456789012345678901", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "012345678901234567890", 1, 1)}, {req: putRequest("key", "123456789012345678901"), resp: putResponse(2)}, {req: getRequest("key"), resp: getResponse("key", "123456789012345678901", 2, 2)}, {req: getRequest("key"), resp: getResponse("key", "012345678901234567890", 2, 2), failure: true}, }, }, { name: "Put must increase revision by 1", operations: []testOperation{ {req: getRequest("key"), resp: emptyGetResponse(1)}, {req: putRequest("key", "1"), resp: putResponse(1), failure: true}, {req: putRequest("key", "1"), resp: putResponse(3), failure: true}, {req: putRequest("key", "1"), resp: putResponse(2)}, }, }, { name: "Put can fail and be lost before get", operations: []testOperation{ {req: putRequest("key", "1"), resp: putResponse(1)}, {req: putRequest("key", "1"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: getRequest("key"), resp: getResponse("key", "2", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "2", 1, 2), failure: true}, }, }, { name: "Put can fail and be lost before put", operations: []testOperation{ {req: getRequest("key"), resp: emptyGetResponse(1)}, {req: putRequest("key", "1"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "3"), resp: putResponse(2)}, }, }, { name: "Put can fail and be lost before delete", operations: []testOperation{ {req: deleteRequest("key"), resp: deleteResponse(0, 1)}, {req: putRequest("key", "1"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(0, 1)}, }, }, { name: "Put can fail and be lost before txn", operations: []testOperation{ // Txn failure {req: getRequest("key"), resp: emptyGetResponse(1)}, {req: putRequest("key", "1"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 2, "3"), resp: compareRevisionAndPutResponse(false, 1)}, // Txn success {req: putRequest("key", "2"), resp: putResponse(2)}, {req: putRequest("key", "4"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 2, "5"), resp: compareRevisionAndPutResponse(true, 3)}, }, }, { name: "Put can fail and be lost before txn success", operations: []testOperation{}, }, { name: "Put can fail but be persisted and increase revision before get", operations: []testOperation{ // One failed request, one persisted. {req: putRequest("key", "1"), resp: putResponse(1)}, {req: putRequest("key", "2"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "3", 2, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "3", 1, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "2", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "2", 2, 2)}, // Two failed request, two persisted. {req: putRequest("key", "3"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "4"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "4", 4, 4)}, }, }, { name: "Put can fail but be persisted and increase revision before delete", operations: []testOperation{ // One failed request, one persisted. {req: deleteRequest("key"), resp: deleteResponse(0, 1)}, {req: putRequest("key", "1"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(1, 1), failure: true}, {req: deleteRequest("key"), resp: deleteResponse(1, 2), failure: true}, {req: deleteRequest("key"), resp: deleteResponse(1, 3)}, // Two failed request, two persisted. {req: putRequest("key", "4"), resp: putResponse(4)}, {req: putRequest("key", "5"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "6"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(1, 7)}, // Two failed request, one persisted. {req: putRequest("key", "8"), resp: putResponse(8)}, {req: putRequest("key", "9"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "10"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(1, 10)}, }, }, { name: "Put can fail but be persisted before txn", operations: []testOperation{ // Txn success {req: getRequest("key"), resp: emptyGetResponse(1)}, {req: putRequest("key", "2"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 2, ""), resp: compareRevisionAndPutResponse(true, 2), failure: true}, {req: compareRevisionAndPutRequest("key", 2, ""), resp: compareRevisionAndPutResponse(true, 3)}, // Txn failure {req: putRequest("key", "4"), resp: putResponse(4)}, {req: compareRevisionAndPutRequest("key", 5, ""), resp: compareRevisionAndPutResponse(false, 4)}, {req: putRequest("key", "5"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "5", 5, 5)}, }, }, { name: "Delete only increases revision on success", operations: []testOperation{ {req: putRequest("key1", "11"), resp: putResponse(1)}, {req: putRequest("key2", "12"), resp: putResponse(2)}, {req: deleteRequest("key1"), resp: deleteResponse(1, 2), failure: true}, {req: deleteRequest("key1"), resp: deleteResponse(1, 3)}, {req: deleteRequest("key1"), resp: deleteResponse(0, 4), failure: true}, {req: deleteRequest("key1"), resp: deleteResponse(0, 3)}, }, }, { name: "Delete not existing key", operations: []testOperation{ {req: getRequest("key"), resp: emptyGetResponse(1)}, {req: deleteRequest("key"), resp: deleteResponse(1, 2), failure: true}, {req: deleteRequest("key"), resp: deleteResponse(0, 1)}, }, }, { name: "Delete clears value", operations: []testOperation{ {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: deleteRequest("key"), resp: deleteResponse(1, 2)}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "1", 2, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 2), failure: true}, {req: getRequest("key"), resp: emptyGetResponse(2)}, }, }, { name: "Delete can fail and be lost before get", operations: []testOperation{ {req: putRequest("key", "1"), resp: putResponse(1)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: getRequest("key"), resp: emptyGetResponse(2), failure: true}, {req: getRequest("key"), resp: emptyGetResponse(2), failure: true}, {req: getRequest("key"), resp: emptyGetResponse(1), failure: true}, }, }, { name: "Delete can fail and be lost before delete", operations: []testOperation{ {req: putRequest("key", "1"), resp: putResponse(1)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(1, 1), failure: true}, {req: deleteRequest("key"), resp: deleteResponse(1, 2)}, }, }, { name: "Delete can fail and be lost before put", operations: []testOperation{ {req: putRequest("key", "1"), resp: putResponse(1)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "1"), resp: putResponse(2)}, }, }, { name: "Delete can fail but be persisted before get", operations: []testOperation{ // One failed request, one persisted. {req: putRequest("key", "1"), resp: putResponse(1)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: emptyGetResponse(2)}, // Two failed request, one persisted. {req: putRequest("key", "3"), resp: putResponse(3)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: emptyGetResponse(4)}, }, }, { name: "Delete can fail but be persisted before put", operations: []testOperation{ // One failed request, one persisted. {req: putRequest("key", "1"), resp: putResponse(1)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "3"), resp: putResponse(3)}, // Two failed request, one persisted. {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "5"), resp: putResponse(5)}, }, }, { name: "Delete can fail but be persisted before delete", operations: []testOperation{ // One failed request, one persisted. {req: putRequest("key", "1"), resp: putResponse(1)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(0, 2)}, {req: putRequest("key", "3"), resp: putResponse(3)}, // Two failed request, one persisted. {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(0, 4)}, }, }, { name: "Delete can fail but be persisted before txn", operations: []testOperation{ // Txn success {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 0, "3"), resp: compareRevisionAndPutResponse(true, 3)}, // Txn failure {req: putRequest("key", "4"), resp: putResponse(4)}, {req: deleteRequest("key"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 4, "5"), resp: compareRevisionAndPutResponse(false, 5)}, }, }, { name: "Txn sets new value if value matches expected", operations: []testOperation{ {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: compareRevisionAndPutResponse(true, 1), failure: true}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: compareRevisionAndPutResponse(false, 2), failure: true}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: compareRevisionAndPutResponse(false, 1), failure: true}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: compareRevisionAndPutResponse(true, 2)}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "1", 2, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "2", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "2", 2, 2)}, }, }, { name: "Txn can expect on empty key", operations: []testOperation{ {req: getRequest("key1"), resp: emptyGetResponse(1)}, {req: compareRevisionAndPutRequest("key1", 0, "2"), resp: compareRevisionAndPutResponse(true, 2)}, {req: compareRevisionAndPutRequest("key2", 0, "3"), resp: compareRevisionAndPutResponse(true, 3)}, {req: compareRevisionAndPutRequest("key3", 4, "4"), resp: compareRevisionAndPutResponse(false, 4), failure: true}, }, }, { name: "Txn doesn't do anything if value doesn't match expected", operations: []testOperation{ {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 2, "3"), resp: compareRevisionAndPutResponse(true, 2), failure: true}, {req: compareRevisionAndPutRequest("key", 2, "3"), resp: compareRevisionAndPutResponse(true, 1), failure: true}, {req: compareRevisionAndPutRequest("key", 2, "3"), resp: compareRevisionAndPutResponse(false, 2), failure: true}, {req: compareRevisionAndPutRequest("key", 2, "3"), resp: compareRevisionAndPutResponse(false, 1)}, {req: getRequest("key"), resp: getResponse("key", "2", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "2", 2, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "3", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "3", 1, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "3", 2, 2), failure: true}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, }, }, { name: "Txn can fail and be lost before get", operations: []testOperation{ {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: getRequest("key"), resp: getResponse("key", "2", 2, 2), failure: true}, }, }, { name: "Txn can fail and be lost before delete", operations: []testOperation{ {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(1, 2)}, }, }, { name: "Txn can fail and be lost before put", operations: []testOperation{ {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "3"), resp: putResponse(2)}, }, }, { name: "Txn can fail but be persisted before get", operations: []testOperation{ // One failed request, one persisted. {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "2", 1, 1), failure: true}, {req: getRequest("key"), resp: getResponse("key", "2", 2, 2)}, // Two failed request, two persisted. {req: putRequest("key", "3"), resp: putResponse(3)}, {req: compareRevisionAndPutRequest("key", 3, "4"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 4, "5"), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "5", 5, 5)}, }, }, { name: "Txn can fail but be persisted before put", operations: []testOperation{ // One failed request, one persisted. {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "3"), resp: putResponse(3)}, // Two failed request, two persisted. {req: putRequest("key", "4"), resp: putResponse(4)}, {req: compareRevisionAndPutRequest("key", 4, "5"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 5, "6"), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "7"), resp: putResponse(7)}, }, }, { name: "Txn can fail but be persisted before delete", operations: []testOperation{ // One failed request, one persisted. {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(1, 3)}, // Two failed request, two persisted. {req: putRequest("key", "4"), resp: putResponse(4)}, {req: compareRevisionAndPutRequest("key", 4, "5"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 5, "6"), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(1, 7)}, }, }, { name: "Txn can fail but be persisted before txn", operations: []testOperation{ // One failed request, one persisted with success. {req: getRequest("key"), resp: getResponse("key", "1", 1, 1)}, {req: compareRevisionAndPutRequest("key", 1, "2"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 2, "3"), resp: compareRevisionAndPutResponse(true, 3)}, // Two failed request, two persisted with success. {req: putRequest("key", "4"), resp: putResponse(4)}, {req: compareRevisionAndPutRequest("key", 4, "5"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 5, "6"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 6, "7"), resp: compareRevisionAndPutResponse(true, 7)}, // One failed request, one persisted with failure. {req: putRequest("key", "8"), resp: putResponse(8)}, {req: compareRevisionAndPutRequest("key", 8, "9"), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 8, "10"), resp: compareRevisionAndPutResponse(false, 9)}, }, }, { name: "Put with valid lease id should succeed. Put with invalid lease id should fail", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key", "2", 1), resp: putResponse(2)}, {req: putWithLeaseRequest("key", "3", 2), resp: putResponse(3), failure: true}, {req: getRequest("key"), resp: getResponse("key", "2", 2, 2)}, }, }, { name: "Put with valid lease id should succeed. Put with expired lease id should fail", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key", "2", 1), resp: putResponse(2)}, {req: getRequest("key"), resp: getResponse("key", "2", 2, 2)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(3)}, {req: putWithLeaseRequest("key", "4", 1), resp: putResponse(4), failure: true}, {req: getRequest("key"), resp: emptyGetResponse(3)}, }, }, { name: "Revoke should increment the revision", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key", "2", 1), resp: putResponse(2)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(3)}, {req: getRequest("key"), resp: emptyGetResponse(3)}, }, }, { name: "Put following a PutWithLease will detach the key from the lease", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key", "2", 1), resp: putResponse(2)}, {req: putRequest("key", "3"), resp: putResponse(3)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(3)}, {req: getRequest("key"), resp: getResponse("key", "3", 3, 3)}, }, }, { name: "Change lease. Revoking older lease should not increment revision", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: leaseGrantRequest(2), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key", "2", 1), resp: putResponse(2)}, {req: putWithLeaseRequest("key", "3", 2), resp: putResponse(3)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(3)}, {req: getRequest("key"), resp: getResponse("key", "3", 3, 3)}, {req: leaseRevokeRequest(2), resp: leaseRevokeResponse(4)}, {req: getRequest("key"), resp: emptyGetResponse(4)}, }, }, { name: "Update key with same lease", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key", "2", 1), resp: putResponse(2)}, {req: putWithLeaseRequest("key", "3", 1), resp: putResponse(3)}, {req: getRequest("key"), resp: getResponse("key", "3", 3, 3)}, }, }, { name: "Deleting a leased key - revoke should not increment revision", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key", "2", 1), resp: putResponse(2)}, {req: deleteRequest("key"), resp: deleteResponse(1, 3)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(4), failure: true}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(3)}, }, }, { name: "Lease a few keys - revoke should increment revision only once", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key1", "1", 1), resp: putResponse(2)}, {req: putWithLeaseRequest("key2", "2", 1), resp: putResponse(3)}, {req: putWithLeaseRequest("key3", "3", 1), resp: putResponse(4)}, {req: putWithLeaseRequest("key4", "4", 1), resp: putResponse(5)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(6)}, }, }, { name: "Lease some keys then delete some of them. Revoke should increment revision since some keys were still leased", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key1", "1", 1), resp: putResponse(2)}, {req: putWithLeaseRequest("key2", "2", 1), resp: putResponse(3)}, {req: putWithLeaseRequest("key3", "3", 1), resp: putResponse(4)}, {req: putWithLeaseRequest("key4", "4", 1), resp: putResponse(5)}, {req: deleteRequest("key1"), resp: deleteResponse(1, 6)}, {req: deleteRequest("key3"), resp: deleteResponse(1, 7)}, {req: deleteRequest("key4"), resp: deleteResponse(1, 8)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(9)}, {req: deleteRequest("key2"), resp: deleteResponse(0, 9)}, {req: getRequest("key1"), resp: emptyGetResponse(9)}, {req: getRequest("key2"), resp: emptyGetResponse(9)}, {req: getRequest("key3"), resp: emptyGetResponse(9)}, {req: getRequest("key4"), resp: emptyGetResponse(9)}, }, }, { name: "Lease some keys then delete all of them. Revoke should not increment", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key1", "1", 1), resp: putResponse(2)}, {req: putWithLeaseRequest("key2", "2", 1), resp: putResponse(3)}, {req: putWithLeaseRequest("key3", "3", 1), resp: putResponse(4)}, {req: putWithLeaseRequest("key4", "4", 1), resp: putResponse(5)}, {req: deleteRequest("key1"), resp: deleteResponse(1, 6)}, {req: deleteRequest("key2"), resp: deleteResponse(1, 7)}, {req: deleteRequest("key3"), resp: deleteResponse(1, 8)}, {req: deleteRequest("key4"), resp: deleteResponse(1, 9)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(9)}, }, }, { name: "All request types", operations: []testOperation{ {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: putWithLeaseRequest("key", "1", 1), resp: putResponse(2)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(3)}, {req: putRequest("key", "4"), resp: putResponse(4)}, {req: getRequest("key"), resp: getResponse("key", "4", 4, 4)}, {req: compareRevisionAndPutRequest("key", 4, "5"), resp: compareRevisionAndPutResponse(true, 5)}, {req: deleteRequest("key"), resp: deleteResponse(1, 6)}, {req: defragmentRequest(), resp: defragmentResponse(6)}, }, }, { name: "Defragment success between all other request types", operations: []testOperation{ {req: defragmentRequest(), resp: defragmentResponse(1)}, {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: defragmentRequest(), resp: defragmentResponse(1)}, {req: putWithLeaseRequest("key", "1", 1), resp: putResponse(2)}, {req: defragmentRequest(), resp: defragmentResponse(2)}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(3)}, {req: defragmentRequest(), resp: defragmentResponse(3)}, {req: putRequest("key", "4"), resp: putResponse(4)}, {req: defragmentRequest(), resp: defragmentResponse(4)}, {req: getRequest("key"), resp: getResponse("key", "4", 4, 4)}, {req: defragmentRequest(), resp: defragmentResponse(4)}, {req: compareRevisionAndPutRequest("key", 4, "5"), resp: compareRevisionAndPutResponse(true, 5)}, {req: defragmentRequest(), resp: defragmentResponse(5)}, {req: deleteRequest("key"), resp: deleteResponse(1, 6)}, {req: defragmentRequest(), resp: defragmentResponse(6)}, }, }, { name: "Defragment failures between all other request types", operations: []testOperation{ {req: defragmentRequest(), resp: failedResponse(errors.New("failed"))}, {req: leaseGrantRequest(1), resp: leaseGrantResponse(1)}, {req: defragmentRequest(), resp: failedResponse(errors.New("failed"))}, {req: putWithLeaseRequest("key", "1", 1), resp: putResponse(2)}, {req: defragmentRequest(), resp: failedResponse(errors.New("failed"))}, {req: leaseRevokeRequest(1), resp: leaseRevokeResponse(3)}, {req: defragmentRequest(), resp: failedResponse(errors.New("failed"))}, {req: putRequest("key", "4"), resp: putResponse(4)}, {req: defragmentRequest(), resp: failedResponse(errors.New("failed"))}, {req: getRequest("key"), resp: getResponse("key", "4", 4, 4)}, {req: defragmentRequest(), resp: failedResponse(errors.New("failed"))}, {req: compareRevisionAndPutRequest("key", 4, "5"), resp: compareRevisionAndPutResponse(true, 5)}, {req: defragmentRequest(), resp: failedResponse(errors.New("failed"))}, {req: deleteRequest("key"), resp: deleteResponse(1, 6)}, {req: defragmentRequest(), resp: failedResponse(errors.New("failed"))}, }, }, } for _, tc := range tcs { t.Run(tc.name, func(t *testing.T) { state := NonDeterministicModel.Init() for _, op := range tc.operations { ok, newState := NonDeterministicModel.Step(state, op.req, op.resp) if ok != !op.failure { t.Logf("state: %v", state) t.Errorf("Unexpected operation result, expect: %v, got: %v, operation: %s", !op.failure, ok, NonDeterministicModel.DescribeOperation(op.req, op.resp)) } if ok { state = newState t.Logf("state: %v", state) } } }) } } func TestModelResponseMatch(t *testing.T) { tcs := []struct { resp1 EtcdNonDeterministicResponse resp2 EtcdNonDeterministicResponse expectMatch bool }{ { resp1: getResponse("key", "a", 1, 1), resp2: getResponse("key", "a", 1, 1), expectMatch: true, }, { resp1: getResponse("key", "a", 1, 1), resp2: getResponse("key", "b", 1, 1), expectMatch: false, }, { resp1: getResponse("key", "a", 1, 1), resp2: getResponse("key", "a", 2, 1), expectMatch: false, }, { resp1: getResponse("key", "a", 1, 1), resp2: getResponse("key", "a", 1, 2), expectMatch: false, }, { resp1: getResponse("key", "a", 1, 1), resp2: failedResponse(errors.New("failed request")), expectMatch: false, }, { resp1: getResponse("key", "a", 1, 1), resp2: unknownResponse(1), expectMatch: true, }, { resp1: getResponse("key", "a", 1, 1), resp2: unknownResponse(0), expectMatch: false, }, { resp1: putResponse(3), resp2: putResponse(3), expectMatch: true, }, { resp1: putResponse(3), resp2: putResponse(4), expectMatch: false, }, { resp1: putResponse(3), resp2: failedResponse(errors.New("failed request")), expectMatch: false, }, { resp1: putResponse(3), resp2: unknownResponse(3), expectMatch: true, }, { resp1: putResponse(3), resp2: unknownResponse(0), expectMatch: false, }, { resp1: deleteResponse(1, 5), resp2: deleteResponse(1, 5), expectMatch: true, }, { resp1: deleteResponse(1, 5), resp2: deleteResponse(0, 5), expectMatch: false, }, { resp1: deleteResponse(1, 5), resp2: deleteResponse(1, 6), expectMatch: false, }, { resp1: deleteResponse(1, 5), resp2: failedResponse(errors.New("failed request")), expectMatch: false, }, { resp1: deleteResponse(1, 5), resp2: unknownResponse(5), expectMatch: true, }, { resp1: deleteResponse(0, 5), resp2: unknownResponse(0), expectMatch: false, }, { resp1: deleteResponse(1, 5), resp2: unknownResponse(0), expectMatch: false, }, { resp1: deleteResponse(0, 5), resp2: unknownResponse(2), expectMatch: false, }, { resp1: compareRevisionAndPutResponse(false, 7), resp2: compareRevisionAndPutResponse(false, 7), expectMatch: true, }, { resp1: compareRevisionAndPutResponse(true, 7), resp2: compareRevisionAndPutResponse(false, 7), expectMatch: false, }, { resp1: compareRevisionAndPutResponse(false, 7), resp2: compareRevisionAndPutResponse(false, 8), expectMatch: false, }, { resp1: compareRevisionAndPutResponse(false, 7), resp2: failedResponse(errors.New("failed request")), expectMatch: false, }, { resp1: compareRevisionAndPutResponse(true, 7), resp2: unknownResponse(7), expectMatch: true, }, { resp1: compareRevisionAndPutResponse(false, 7), resp2: unknownResponse(7), expectMatch: true, }, { resp1: compareRevisionAndPutResponse(true, 7), resp2: unknownResponse(0), expectMatch: false, }, { resp1: compareRevisionAndPutResponse(false, 7), resp2: unknownResponse(0), expectMatch: false, }, } for i, tc := range tcs { assert.Equal(t, tc.expectMatch, Match(tc.resp1, tc.resp2), "%d %+v %+v", i, tc.resp1, tc.resp2) } }