mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00
66c7aab4d3
Previously the SetConsistentIndex() is called during the apply workflow, but it's outside the db transaction. If a commit happens between SetConsistentIndex and the following apply workflow, and etcd crashes for whatever reason right after the commit, then etcd commits an incomplete transaction to db. Eventually etcd runs into the data inconsistency issue. In this commit, we move the SetConsistentIndex into a txPostLockHook, so it will be executed inside the transaction lock.
112 lines
2.9 KiB
Go
112 lines
2.9 KiB
Go
// Copyright 2022 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package backend_test
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"go.etcd.io/etcd/server/v3/mvcc/backend"
|
|
betesting "go.etcd.io/etcd/server/v3/mvcc/backend/testing"
|
|
)
|
|
|
|
func TestLockVerify(t *testing.T) {
|
|
tcs := []struct {
|
|
name string
|
|
insideApply bool
|
|
lock func(tx backend.BatchTx)
|
|
txPostLockInsideApplyHook func()
|
|
expectPanic bool
|
|
}{
|
|
{
|
|
name: "call lockInsideApply from inside apply",
|
|
insideApply: true,
|
|
lock: lockInsideApply,
|
|
expectPanic: false,
|
|
},
|
|
{
|
|
name: "call lockInsideApply from outside apply (without txPostLockInsideApplyHook)",
|
|
insideApply: false,
|
|
lock: lockInsideApply,
|
|
expectPanic: false,
|
|
},
|
|
{
|
|
name: "call lockInsideApply from outside apply (with txPostLockInsideApplyHook)",
|
|
insideApply: false,
|
|
lock: lockInsideApply,
|
|
txPostLockInsideApplyHook: func() {},
|
|
expectPanic: true,
|
|
},
|
|
{
|
|
name: "call lockOutsideApply from outside apply",
|
|
insideApply: false,
|
|
lock: lockOutsideApply,
|
|
expectPanic: false,
|
|
},
|
|
{
|
|
name: "call lockOutsideApply from inside apply",
|
|
insideApply: true,
|
|
lock: lockOutsideApply,
|
|
expectPanic: true,
|
|
},
|
|
{
|
|
name: "call Lock from unit test",
|
|
insideApply: false,
|
|
lock: lockFromUT,
|
|
expectPanic: false,
|
|
},
|
|
}
|
|
env := os.Getenv("ETCD_VERIFY")
|
|
os.Setenv("ETCD_VERIFY", "lock")
|
|
defer func() {
|
|
os.Setenv("ETCD_VERIFY", env)
|
|
}()
|
|
for _, tc := range tcs {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
|
|
be, _ := betesting.NewTmpBackend(t, time.Hour, 10000)
|
|
be.SetTxPostLockInsideApplyHook(tc.txPostLockInsideApplyHook)
|
|
|
|
hasPaniced := handlePanic(func() {
|
|
if tc.insideApply {
|
|
applyEntries(be, tc.lock)
|
|
} else {
|
|
tc.lock(be.BatchTx())
|
|
}
|
|
}) != nil
|
|
if hasPaniced != tc.expectPanic {
|
|
t.Errorf("%v != %v", hasPaniced, tc.expectPanic)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func handlePanic(f func()) (result interface{}) {
|
|
defer func() {
|
|
result = recover()
|
|
}()
|
|
f()
|
|
return result
|
|
}
|
|
|
|
func applyEntries(be backend.Backend, f func(tx backend.BatchTx)) {
|
|
f(be.BatchTx())
|
|
}
|
|
|
|
func lockInsideApply(tx backend.BatchTx) { tx.LockInsideApply() }
|
|
func lockOutsideApply(tx backend.BatchTx) { tx.LockOutsideApply() }
|
|
func lockFromUT(tx backend.BatchTx) { tx.Lock() }
|