mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00
37c95c9fd4
The e2e tests can be flaky due to various tests mutating shared mutable fixtures, causing non-deterministic behavior depending on the test set, order, etc. For example, `configTLS` is mutated in at least two tests in such a way that the config is potentially invalidated for any subsequent test running in the same process (e.g. by setting the `enableV2` field). This particular example caused a substantial amount of confusion diagnosing the new test introduced for https://github.com/etcd-io/etcd/pull/12370. Independent tests should not share mutable state unless deliberately. This patch refactors the e2e test config fixtures to safeguard against these problems by replacing the package variables (which cannot easily be made immutable) with functions that return new instances.
61 lines
1.5 KiB
Go
61 lines
1.5 KiB
Go
// Copyright 2016 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package e2e
|
|
|
|
import (
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"go.etcd.io/etcd/pkg/v3/expect"
|
|
)
|
|
|
|
var (
|
|
defaultGatewayEndpoint = "127.0.0.1:23790"
|
|
)
|
|
|
|
func TestGateway(t *testing.T) {
|
|
ec, err := newEtcdProcessCluster(t, newConfigNoTLS())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer ec.Stop()
|
|
|
|
eps := strings.Join(ec.EndpointsV3(), ",")
|
|
|
|
p := startGateway(t, eps)
|
|
defer p.Stop()
|
|
|
|
os.Setenv("ETCDCTL_API", "3")
|
|
defer os.Unsetenv("ETCDCTL_API")
|
|
|
|
err = spawnWithExpect([]string{ctlBinPath, "--endpoints=" + defaultGatewayEndpoint, "put", "foo", "bar"}, "OK\r\n")
|
|
if err != nil {
|
|
t.Errorf("failed to finish put request through gateway: %v", err)
|
|
}
|
|
}
|
|
|
|
func startGateway(t *testing.T, endpoints string) *expect.ExpectProcess {
|
|
p, err := expect.NewExpect(binPath, "gateway", "--endpoints="+endpoints, "start")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
_, err = p.Expect("ready to proxy client requests")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return p
|
|
}
|