mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00
1f8764be3b
Some goroutines in test functions will be leaked in certain cases. This patch stops these leaks no matter what happens in test, by putting the blocking channel in select together with a new stopc channel, or adding 1 buffer to the blocking channel.
86 lines
2.1 KiB
Go
86 lines
2.1 KiB
Go
// Copyright 2016 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package integration
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"go.etcd.io/etcd/clientv3"
|
|
"go.etcd.io/etcd/contrib/recipes"
|
|
"go.etcd.io/etcd/pkg/testutil"
|
|
)
|
|
|
|
func TestBarrierSingleNode(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
clus := NewClusterV3(t, &ClusterConfig{Size: 1})
|
|
defer clus.Terminate(t)
|
|
testBarrier(t, 5, func() *clientv3.Client { return clus.clients[0] })
|
|
}
|
|
|
|
func TestBarrierMultiNode(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
clus := NewClusterV3(t, &ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
testBarrier(t, 5, func() *clientv3.Client { return clus.RandClient() })
|
|
}
|
|
|
|
func testBarrier(t *testing.T, waiters int, chooseClient func() *clientv3.Client) {
|
|
b := recipe.NewBarrier(chooseClient(), "test-barrier")
|
|
if err := b.Hold(); err != nil {
|
|
t.Fatalf("could not hold barrier (%v)", err)
|
|
}
|
|
if err := b.Hold(); err == nil {
|
|
t.Fatalf("able to double-hold barrier")
|
|
}
|
|
|
|
donec := make(chan struct{})
|
|
stopc := make(chan struct{})
|
|
defer close(stopc)
|
|
|
|
for i := 0; i < waiters; i++ {
|
|
go func() {
|
|
br := recipe.NewBarrier(chooseClient(), "test-barrier")
|
|
if err := br.Wait(); err != nil {
|
|
t.Errorf("could not wait on barrier (%v)", err)
|
|
}
|
|
select {
|
|
case donec <- struct{}{}:
|
|
case <-stopc:
|
|
}
|
|
|
|
}()
|
|
}
|
|
|
|
select {
|
|
case <-donec:
|
|
t.Fatalf("barrier did not wait")
|
|
default:
|
|
}
|
|
|
|
if err := b.Release(); err != nil {
|
|
t.Fatalf("could not release barrier (%v)", err)
|
|
}
|
|
|
|
timerC := time.After(time.Duration(waiters*100) * time.Millisecond)
|
|
for i := 0; i < waiters; i++ {
|
|
select {
|
|
case <-timerC:
|
|
t.Fatalf("barrier timed out")
|
|
case <-donec:
|
|
}
|
|
}
|
|
}
|