mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00
2648a36f8c
In go1.13, the TLS13 is enablled by default, and as per go1.13 release notes : TLS 1.3 cipher suites are not configurable. All supported cipher suites are safe, and if PreferServerCipherSuites is set in Config the preference order is based on the available hardware. Fixing the test case for go1.13 by limiting the TLS version to TLS12
78 lines
2.4 KiB
Go
78 lines
2.4 KiB
Go
// Copyright 2018 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package integration
|
|
|
|
import (
|
|
"context"
|
|
"crypto/tls"
|
|
"testing"
|
|
"time"
|
|
|
|
"go.etcd.io/etcd/clientv3"
|
|
"go.etcd.io/etcd/pkg/testutil"
|
|
|
|
"google.golang.org/grpc"
|
|
)
|
|
|
|
func TestTLSClientCipherSuitesValid(t *testing.T) { testTLSCipherSuites(t, true) }
|
|
func TestTLSClientCipherSuitesMismatch(t *testing.T) { testTLSCipherSuites(t, false) }
|
|
|
|
// testTLSCipherSuites ensures mismatching client-side cipher suite
|
|
// fail TLS handshake with the server.
|
|
func testTLSCipherSuites(t *testing.T, valid bool) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
cipherSuites := []uint16{
|
|
tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
|
|
tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
|
|
tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
|
|
tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
|
|
tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,
|
|
tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305,
|
|
}
|
|
srvTLS, cliTLS := testTLSInfo, testTLSInfo
|
|
if valid {
|
|
srvTLS.CipherSuites, cliTLS.CipherSuites = cipherSuites, cipherSuites
|
|
} else {
|
|
srvTLS.CipherSuites, cliTLS.CipherSuites = cipherSuites[:2], cipherSuites[2:]
|
|
}
|
|
|
|
clus := NewClusterV3(t, &ClusterConfig{Size: 1, ClientTLS: &srvTLS})
|
|
defer clus.Terminate(t)
|
|
|
|
cc, err := cliTLS.ClientConfig()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// go1.13 enables TLS13 by default, and in TLS13, cipher suites are not configurable
|
|
// setting Max TLS version to TLS12 for go1.13
|
|
cc.MaxVersion = tls.VersionTLS12
|
|
cli, cerr := clientv3.New(clientv3.Config{
|
|
Endpoints: []string{clus.Members[0].GRPCAddr()},
|
|
DialTimeout: time.Second,
|
|
DialOptions: []grpc.DialOption{grpc.WithBlock()},
|
|
TLS: cc,
|
|
})
|
|
if cli != nil {
|
|
cli.Close()
|
|
}
|
|
if !valid && cerr != context.DeadlineExceeded {
|
|
t.Fatalf("expected %v with TLS handshake failure, got %v", context.DeadlineExceeded, cerr)
|
|
}
|
|
if valid && cerr != nil {
|
|
t.Fatalf("expected TLS handshake success, got %v", cerr)
|
|
}
|
|
}
|