mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00

This change is to ensure that all members returned during the client's AutoSync are started and are not learners, which are not valid etcd members to make requests to. Signed-off-by: Chris Ayoub <cayoub@hubspot.com>
218 lines
5.6 KiB
Go
218 lines
5.6 KiB
Go
// Copyright 2016 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package clientv3
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net"
|
|
"testing"
|
|
"time"
|
|
|
|
"go.etcd.io/etcd/etcdserver/api/v3rpc/rpctypes"
|
|
"go.etcd.io/etcd/etcdserver/etcdserverpb"
|
|
"go.etcd.io/etcd/pkg/testutil"
|
|
|
|
"google.golang.org/grpc"
|
|
)
|
|
|
|
func TestDialCancel(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
// accept first connection so client is created with dial timeout
|
|
ln, err := net.Listen("unix", "dialcancel:12345")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer ln.Close()
|
|
|
|
ep := "unix://dialcancel:12345"
|
|
cfg := Config{
|
|
Endpoints: []string{ep},
|
|
DialTimeout: 30 * time.Second}
|
|
c, err := New(cfg)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// connect to ipv4 black hole so dial blocks
|
|
c.SetEndpoints("http://254.0.0.1:12345")
|
|
|
|
// issue Get to force redial attempts
|
|
getc := make(chan struct{})
|
|
go func() {
|
|
defer close(getc)
|
|
// Get may hang forever on grpc's Stream.Header() if its
|
|
// context is never canceled.
|
|
c.Get(c.Ctx(), "abc")
|
|
}()
|
|
|
|
// wait a little bit so client close is after dial starts
|
|
time.Sleep(100 * time.Millisecond)
|
|
|
|
donec := make(chan struct{})
|
|
go func() {
|
|
defer close(donec)
|
|
c.Close()
|
|
}()
|
|
|
|
select {
|
|
case <-time.After(5 * time.Second):
|
|
t.Fatalf("failed to close")
|
|
case <-donec:
|
|
}
|
|
select {
|
|
case <-time.After(5 * time.Second):
|
|
t.Fatalf("get failed to exit")
|
|
case <-getc:
|
|
}
|
|
}
|
|
|
|
func TestDialTimeout(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
// grpc.WithBlock to block until connection up or timeout
|
|
testCfgs := []Config{
|
|
{
|
|
Endpoints: []string{"http://254.0.0.1:12345"},
|
|
DialTimeout: 2 * time.Second,
|
|
DialOptions: []grpc.DialOption{grpc.WithBlock()},
|
|
},
|
|
{
|
|
Endpoints: []string{"http://254.0.0.1:12345"},
|
|
DialTimeout: time.Second,
|
|
DialOptions: []grpc.DialOption{grpc.WithBlock()},
|
|
Username: "abc",
|
|
Password: "def",
|
|
},
|
|
}
|
|
|
|
for i, cfg := range testCfgs {
|
|
donec := make(chan error)
|
|
go func() {
|
|
// without timeout, dial continues forever on ipv4 black hole
|
|
c, err := New(cfg)
|
|
if c != nil || err == nil {
|
|
t.Errorf("#%d: new client should fail", i)
|
|
}
|
|
donec <- err
|
|
}()
|
|
|
|
time.Sleep(10 * time.Millisecond)
|
|
|
|
select {
|
|
case err := <-donec:
|
|
t.Errorf("#%d: dial didn't wait (%v)", i, err)
|
|
default:
|
|
}
|
|
|
|
select {
|
|
case <-time.After(5 * time.Second):
|
|
t.Errorf("#%d: failed to timeout dial on time", i)
|
|
case err := <-donec:
|
|
if err != context.DeadlineExceeded {
|
|
t.Errorf("#%d: unexpected error %v, want %v", i, err, context.DeadlineExceeded)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDialNoTimeout(t *testing.T) {
|
|
cfg := Config{Endpoints: []string{"127.0.0.1:12345"}}
|
|
c, err := New(cfg)
|
|
if c == nil || err != nil {
|
|
t.Fatalf("new client with DialNoWait should succeed, got %v", err)
|
|
}
|
|
c.Close()
|
|
}
|
|
|
|
func TestIsHaltErr(t *testing.T) {
|
|
if !isHaltErr(nil, fmt.Errorf("etcdserver: some etcdserver error")) {
|
|
t.Errorf(`error prefixed with "etcdserver: " should be Halted by default`)
|
|
}
|
|
if isHaltErr(nil, rpctypes.ErrGRPCStopped) {
|
|
t.Errorf("error %v should not halt", rpctypes.ErrGRPCStopped)
|
|
}
|
|
if isHaltErr(nil, rpctypes.ErrGRPCNoLeader) {
|
|
t.Errorf("error %v should not halt", rpctypes.ErrGRPCNoLeader)
|
|
}
|
|
ctx, cancel := context.WithCancel(context.TODO())
|
|
if isHaltErr(ctx, nil) {
|
|
t.Errorf("no error and active context should not be Halted")
|
|
}
|
|
cancel()
|
|
if !isHaltErr(ctx, nil) {
|
|
t.Errorf("cancel on context should be Halted")
|
|
}
|
|
}
|
|
|
|
func TestCloseCtxClient(t *testing.T) {
|
|
ctx := context.Background()
|
|
c := NewCtxClient(ctx)
|
|
err := c.Close()
|
|
// Close returns ctx.toErr, a nil error means an open Done channel
|
|
if err == nil {
|
|
t.Errorf("failed to Close the client. %v", err)
|
|
}
|
|
}
|
|
|
|
func TestSyncFiltersMembers(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
c, _ := New(Config{Endpoints: []string{"http://254.0.0.1:12345"}})
|
|
c.Cluster = &mockCluster{
|
|
[]*etcdserverpb.Member{
|
|
{ID: 0, Name: "", ClientURLs: []string{"http://254.0.0.1:12345"}, IsLearner: false},
|
|
{ID: 1, Name: "isStarted", ClientURLs: []string{"http://254.0.0.2:12345"}, IsLearner: true},
|
|
{ID: 2, Name: "isStartedAndNotLearner", ClientURLs: []string{"http://254.0.0.3:12345"}, IsLearner: false},
|
|
},
|
|
}
|
|
c.Sync(context.Background())
|
|
|
|
endpoints := c.Endpoints()
|
|
if len(endpoints) != 1 || endpoints[0] != "http://254.0.0.3:12345" {
|
|
t.Error("Client.Sync uses learner and/or non-started member client URLs")
|
|
}
|
|
c.Close()
|
|
}
|
|
|
|
type mockCluster struct {
|
|
members []*etcdserverpb.Member
|
|
}
|
|
|
|
func (mc *mockCluster) MemberList(ctx context.Context) (*MemberListResponse, error) {
|
|
return &MemberListResponse{Members: mc.members}, nil
|
|
}
|
|
|
|
func (mc *mockCluster) MemberAdd(ctx context.Context, peerAddrs []string) (*MemberAddResponse, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (mc *mockCluster) MemberAddAsLearner(ctx context.Context, peerAddrs []string) (*MemberAddResponse, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (mc *mockCluster) MemberRemove(ctx context.Context, id uint64) (*MemberRemoveResponse, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (mc *mockCluster) MemberUpdate(ctx context.Context, id uint64, peerAddrs []string) (*MemberUpdateResponse, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (mc *mockCluster) MemberPromote(ctx context.Context, id uint64) (*MemberPromoteResponse, error) {
|
|
return nil, nil
|
|
}
|