mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00

This commit adds a feature for creating a user without password. The purpose of the feature is reducing attack surface by configuring bad passwords (CN based auth will be allowed for the user). The feature can be used with `--no-password` of `etcdctl user add` command. Fix https://github.com/coreos/etcd/issues/9590
300 lines
7.9 KiB
Go
300 lines
7.9 KiB
Go
// Copyright 2016 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package command
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/bgentry/speakeasy"
|
|
"github.com/spf13/cobra"
|
|
"go.etcd.io/etcd/clientv3"
|
|
)
|
|
|
|
var (
|
|
userShowDetail bool
|
|
)
|
|
|
|
// NewUserCommand returns the cobra command for "user".
|
|
func NewUserCommand() *cobra.Command {
|
|
ac := &cobra.Command{
|
|
Use: "user <subcommand>",
|
|
Short: "User related commands",
|
|
}
|
|
|
|
ac.AddCommand(newUserAddCommand())
|
|
ac.AddCommand(newUserDeleteCommand())
|
|
ac.AddCommand(newUserGetCommand())
|
|
ac.AddCommand(newUserListCommand())
|
|
ac.AddCommand(newUserChangePasswordCommand())
|
|
ac.AddCommand(newUserGrantRoleCommand())
|
|
ac.AddCommand(newUserRevokeRoleCommand())
|
|
|
|
return ac
|
|
}
|
|
|
|
var (
|
|
passwordInteractive bool
|
|
passwordFromFlag string
|
|
noPassword bool
|
|
)
|
|
|
|
func newUserAddCommand() *cobra.Command {
|
|
cmd := cobra.Command{
|
|
Use: "add <user name or user:password> [options]",
|
|
Short: "Adds a new user",
|
|
Run: userAddCommandFunc,
|
|
}
|
|
|
|
cmd.Flags().BoolVar(&passwordInteractive, "interactive", true, "Read password from stdin instead of interactive terminal")
|
|
cmd.Flags().StringVar(&passwordFromFlag, "new-user-password", "", "Supply password from the command line flag")
|
|
cmd.Flags().BoolVar(&noPassword, "no-password", false, "Create a user without password (CN based auth only)")
|
|
|
|
return &cmd
|
|
}
|
|
|
|
func newUserDeleteCommand() *cobra.Command {
|
|
return &cobra.Command{
|
|
Use: "delete <user name>",
|
|
Short: "Deletes a user",
|
|
Run: userDeleteCommandFunc,
|
|
}
|
|
}
|
|
|
|
func newUserGetCommand() *cobra.Command {
|
|
cmd := cobra.Command{
|
|
Use: "get <user name> [options]",
|
|
Short: "Gets detailed information of a user",
|
|
Run: userGetCommandFunc,
|
|
}
|
|
|
|
cmd.Flags().BoolVar(&userShowDetail, "detail", false, "Show permissions of roles granted to the user")
|
|
|
|
return &cmd
|
|
}
|
|
|
|
func newUserListCommand() *cobra.Command {
|
|
return &cobra.Command{
|
|
Use: "list",
|
|
Short: "Lists all users",
|
|
Run: userListCommandFunc,
|
|
}
|
|
}
|
|
|
|
func newUserChangePasswordCommand() *cobra.Command {
|
|
cmd := cobra.Command{
|
|
Use: "passwd <user name> [options]",
|
|
Short: "Changes password of user",
|
|
Run: userChangePasswordCommandFunc,
|
|
}
|
|
|
|
cmd.Flags().BoolVar(&passwordInteractive, "interactive", true, "If true, read password from stdin instead of interactive terminal")
|
|
|
|
return &cmd
|
|
}
|
|
|
|
func newUserGrantRoleCommand() *cobra.Command {
|
|
return &cobra.Command{
|
|
Use: "grant-role <user name> <role name>",
|
|
Short: "Grants a role to a user",
|
|
Run: userGrantRoleCommandFunc,
|
|
}
|
|
}
|
|
|
|
func newUserRevokeRoleCommand() *cobra.Command {
|
|
return &cobra.Command{
|
|
Use: "revoke-role <user name> <role name>",
|
|
Short: "Revokes a role from a user",
|
|
Run: userRevokeRoleCommandFunc,
|
|
}
|
|
}
|
|
|
|
// userAddCommandFunc executes the "user add" command.
|
|
func userAddCommandFunc(cmd *cobra.Command, args []string) {
|
|
if len(args) != 1 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("user add command requires user name as its argument"))
|
|
}
|
|
|
|
var password string
|
|
var user string
|
|
|
|
options := &clientv3.UserAddOptions{
|
|
NoPassword: false,
|
|
}
|
|
|
|
if !noPassword {
|
|
if passwordFromFlag != "" {
|
|
user = args[0]
|
|
password = passwordFromFlag
|
|
} else {
|
|
splitted := strings.SplitN(args[0], ":", 2)
|
|
if len(splitted) < 2 {
|
|
user = args[0]
|
|
if !passwordInteractive {
|
|
fmt.Scanf("%s", &password)
|
|
} else {
|
|
password = readPasswordInteractive(args[0])
|
|
}
|
|
} else {
|
|
user = splitted[0]
|
|
password = splitted[1]
|
|
if len(user) == 0 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("empty user name is not allowed"))
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
user = args[0]
|
|
options.NoPassword = true
|
|
}
|
|
|
|
resp, err := mustClientFromCmd(cmd).Auth.UserAddWithOptions(context.TODO(), user, password, options)
|
|
if err != nil {
|
|
ExitWithError(ExitError, err)
|
|
}
|
|
|
|
display.UserAdd(user, *resp)
|
|
}
|
|
|
|
// userDeleteCommandFunc executes the "user delete" command.
|
|
func userDeleteCommandFunc(cmd *cobra.Command, args []string) {
|
|
if len(args) != 1 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("user delete command requires user name as its argument"))
|
|
}
|
|
|
|
resp, err := mustClientFromCmd(cmd).Auth.UserDelete(context.TODO(), args[0])
|
|
if err != nil {
|
|
ExitWithError(ExitError, err)
|
|
}
|
|
display.UserDelete(args[0], *resp)
|
|
}
|
|
|
|
// userGetCommandFunc executes the "user get" command.
|
|
func userGetCommandFunc(cmd *cobra.Command, args []string) {
|
|
if len(args) != 1 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("user get command requires user name as its argument"))
|
|
}
|
|
|
|
name := args[0]
|
|
client := mustClientFromCmd(cmd)
|
|
resp, err := client.Auth.UserGet(context.TODO(), name)
|
|
if err != nil {
|
|
ExitWithError(ExitError, err)
|
|
}
|
|
|
|
if userShowDetail {
|
|
fmt.Printf("User: %s\n", name)
|
|
for _, role := range resp.Roles {
|
|
fmt.Printf("\n")
|
|
roleResp, err := client.Auth.RoleGet(context.TODO(), role)
|
|
if err != nil {
|
|
ExitWithError(ExitError, err)
|
|
}
|
|
display.RoleGet(role, *roleResp)
|
|
}
|
|
} else {
|
|
display.UserGet(name, *resp)
|
|
}
|
|
}
|
|
|
|
// userListCommandFunc executes the "user list" command.
|
|
func userListCommandFunc(cmd *cobra.Command, args []string) {
|
|
if len(args) != 0 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("user list command requires no arguments"))
|
|
}
|
|
|
|
resp, err := mustClientFromCmd(cmd).Auth.UserList(context.TODO())
|
|
if err != nil {
|
|
ExitWithError(ExitError, err)
|
|
}
|
|
|
|
display.UserList(*resp)
|
|
}
|
|
|
|
// userChangePasswordCommandFunc executes the "user passwd" command.
|
|
func userChangePasswordCommandFunc(cmd *cobra.Command, args []string) {
|
|
if len(args) != 1 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("user passwd command requires user name as its argument"))
|
|
}
|
|
|
|
var password string
|
|
|
|
if !passwordInteractive {
|
|
fmt.Scanf("%s", &password)
|
|
} else {
|
|
password = readPasswordInteractive(args[0])
|
|
}
|
|
|
|
resp, err := mustClientFromCmd(cmd).Auth.UserChangePassword(context.TODO(), args[0], password)
|
|
if err != nil {
|
|
ExitWithError(ExitError, err)
|
|
}
|
|
|
|
display.UserChangePassword(*resp)
|
|
}
|
|
|
|
// userGrantRoleCommandFunc executes the "user grant-role" command.
|
|
func userGrantRoleCommandFunc(cmd *cobra.Command, args []string) {
|
|
if len(args) != 2 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("user grant command requires user name and role name as its argument"))
|
|
}
|
|
|
|
resp, err := mustClientFromCmd(cmd).Auth.UserGrantRole(context.TODO(), args[0], args[1])
|
|
if err != nil {
|
|
ExitWithError(ExitError, err)
|
|
}
|
|
|
|
display.UserGrantRole(args[0], args[1], *resp)
|
|
}
|
|
|
|
// userRevokeRoleCommandFunc executes the "user revoke-role" command.
|
|
func userRevokeRoleCommandFunc(cmd *cobra.Command, args []string) {
|
|
if len(args) != 2 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("user revoke-role requires user name and role name as its argument"))
|
|
}
|
|
|
|
resp, err := mustClientFromCmd(cmd).Auth.UserRevokeRole(context.TODO(), args[0], args[1])
|
|
if err != nil {
|
|
ExitWithError(ExitError, err)
|
|
}
|
|
|
|
display.UserRevokeRole(args[0], args[1], *resp)
|
|
}
|
|
|
|
func readPasswordInteractive(name string) string {
|
|
prompt1 := fmt.Sprintf("Password of %s: ", name)
|
|
password1, err1 := speakeasy.Ask(prompt1)
|
|
if err1 != nil {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("failed to ask password: %s", err1))
|
|
}
|
|
|
|
if len(password1) == 0 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("empty password"))
|
|
}
|
|
|
|
prompt2 := fmt.Sprintf("Type password of %s again for confirmation: ", name)
|
|
password2, err2 := speakeasy.Ask(prompt2)
|
|
if err2 != nil {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("failed to ask password: %s", err2))
|
|
}
|
|
|
|
if password1 != password2 {
|
|
ExitWithError(ExitBadArgs, fmt.Errorf("given passwords are different"))
|
|
}
|
|
|
|
return password1
|
|
}
|