mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00

This attempts to fix a special case of the problem described in #12385, where trying to do `clientv3.Watch` with an expired token would result in `ErrGRPCPermissionDenied`, due to the failing authorization check in `isWatchPermitted`. Furthermore, the client can't auto recover, since `shouldRefreshToken` rightly returns false for the permission denied error. In this case, we would like to have a runbook to dynamically disable auth, without causing any disruption. Doing so would immediately expire all existing tokens, which would then cause the behavior described above. This means existing watchers would still work for a period of time after disabling auth, until they have to reconnect, e.g. due to a rolling restart of server nodes. This commit adds a client-side fix and a server-side fix, either of which is sufficient to get the added test case to pass. Note that it is an e2e test case instead of an integration one, as the reconnect only happens if the server node is stopped via SIGINT or SIGTERM. A generic fix for the problem described in #12385 would be better, as that shall also fix this special case. However, the fix would likely be a lot more involved, as some untangling of authn/authz is required.
1204 lines
30 KiB
Go
1204 lines
30 KiB
Go
// Copyright 2016 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package auth
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/base64"
|
|
"errors"
|
|
"sort"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
"time"
|
|
|
|
"go.etcd.io/etcd/api/v3/authpb"
|
|
pb "go.etcd.io/etcd/api/v3/etcdserverpb"
|
|
"go.etcd.io/etcd/api/v3/v3rpc/rpctypes"
|
|
|
|
"go.uber.org/zap"
|
|
"golang.org/x/crypto/bcrypt"
|
|
"google.golang.org/grpc/credentials"
|
|
"google.golang.org/grpc/metadata"
|
|
"google.golang.org/grpc/peer"
|
|
)
|
|
|
|
var (
|
|
authEnabled = []byte{1}
|
|
authDisabled = []byte{0}
|
|
|
|
rootPerm = authpb.Permission{PermType: authpb.READWRITE, Key: []byte{}, RangeEnd: []byte{0}}
|
|
|
|
ErrRootUserNotExist = errors.New("auth: root user does not exist")
|
|
ErrRootRoleNotExist = errors.New("auth: root user does not have root role")
|
|
ErrUserAlreadyExist = errors.New("auth: user already exists")
|
|
ErrUserEmpty = errors.New("auth: user name is empty")
|
|
ErrUserNotFound = errors.New("auth: user not found")
|
|
ErrRoleAlreadyExist = errors.New("auth: role already exists")
|
|
ErrRoleNotFound = errors.New("auth: role not found")
|
|
ErrRoleEmpty = errors.New("auth: role name is empty")
|
|
ErrPermissionNotGiven = errors.New("auth: permission not given")
|
|
ErrAuthFailed = errors.New("auth: authentication failed, invalid user ID or password")
|
|
ErrNoPasswordUser = errors.New("auth: authentication failed, password was given for no password user")
|
|
ErrPermissionDenied = errors.New("auth: permission denied")
|
|
ErrRoleNotGranted = errors.New("auth: role is not granted to the user")
|
|
ErrPermissionNotGranted = errors.New("auth: permission is not granted to the role")
|
|
ErrAuthNotEnabled = errors.New("auth: authentication is not enabled")
|
|
ErrAuthOldRevision = errors.New("auth: revision in header is old")
|
|
ErrInvalidAuthToken = errors.New("auth: invalid auth token")
|
|
ErrInvalidAuthOpts = errors.New("auth: invalid auth options")
|
|
ErrInvalidAuthMgmt = errors.New("auth: invalid auth management")
|
|
ErrInvalidAuthMethod = errors.New("auth: invalid auth signature method")
|
|
ErrMissingKey = errors.New("auth: missing key data")
|
|
ErrKeyMismatch = errors.New("auth: public and private keys don't match")
|
|
ErrVerifyOnly = errors.New("auth: token signing attempted with verify-only key")
|
|
)
|
|
|
|
const (
|
|
rootUser = "root"
|
|
rootRole = "root"
|
|
|
|
tokenTypeSimple = "simple"
|
|
tokenTypeJWT = "jwt"
|
|
)
|
|
|
|
type AuthInfo struct {
|
|
Username string
|
|
Revision uint64
|
|
}
|
|
|
|
// AuthenticateParamIndex is used for a key of context in the parameters of Authenticate()
|
|
type AuthenticateParamIndex struct{}
|
|
|
|
// AuthenticateParamSimpleTokenPrefix is used for a key of context in the parameters of Authenticate()
|
|
type AuthenticateParamSimpleTokenPrefix struct{}
|
|
|
|
// AuthStore defines auth storage interface.
|
|
type AuthStore interface {
|
|
// AuthEnable turns on the authentication feature
|
|
AuthEnable() error
|
|
|
|
// AuthDisable turns off the authentication feature
|
|
AuthDisable()
|
|
|
|
// IsAuthEnabled returns true if the authentication feature is enabled.
|
|
IsAuthEnabled() bool
|
|
|
|
// Authenticate does authentication based on given user name and password
|
|
Authenticate(ctx context.Context, username, password string) (*pb.AuthenticateResponse, error)
|
|
|
|
// Recover recovers the state of auth store from the given backend
|
|
Recover(be AuthBackend)
|
|
|
|
// UserAdd adds a new user
|
|
UserAdd(r *pb.AuthUserAddRequest) (*pb.AuthUserAddResponse, error)
|
|
|
|
// UserDelete deletes a user
|
|
UserDelete(r *pb.AuthUserDeleteRequest) (*pb.AuthUserDeleteResponse, error)
|
|
|
|
// UserChangePassword changes a password of a user
|
|
UserChangePassword(r *pb.AuthUserChangePasswordRequest) (*pb.AuthUserChangePasswordResponse, error)
|
|
|
|
// UserGrantRole grants a role to the user
|
|
UserGrantRole(r *pb.AuthUserGrantRoleRequest) (*pb.AuthUserGrantRoleResponse, error)
|
|
|
|
// UserGet gets the detailed information of a users
|
|
UserGet(r *pb.AuthUserGetRequest) (*pb.AuthUserGetResponse, error)
|
|
|
|
// UserRevokeRole revokes a role of a user
|
|
UserRevokeRole(r *pb.AuthUserRevokeRoleRequest) (*pb.AuthUserRevokeRoleResponse, error)
|
|
|
|
// RoleAdd adds a new role
|
|
RoleAdd(r *pb.AuthRoleAddRequest) (*pb.AuthRoleAddResponse, error)
|
|
|
|
// RoleGrantPermission grants a permission to a role
|
|
RoleGrantPermission(r *pb.AuthRoleGrantPermissionRequest) (*pb.AuthRoleGrantPermissionResponse, error)
|
|
|
|
// RoleGet gets the detailed information of a role
|
|
RoleGet(r *pb.AuthRoleGetRequest) (*pb.AuthRoleGetResponse, error)
|
|
|
|
// RoleRevokePermission gets the detailed information of a role
|
|
RoleRevokePermission(r *pb.AuthRoleRevokePermissionRequest) (*pb.AuthRoleRevokePermissionResponse, error)
|
|
|
|
// RoleDelete gets the detailed information of a role
|
|
RoleDelete(r *pb.AuthRoleDeleteRequest) (*pb.AuthRoleDeleteResponse, error)
|
|
|
|
// UserList gets a list of all users
|
|
UserList(r *pb.AuthUserListRequest) (*pb.AuthUserListResponse, error)
|
|
|
|
// RoleList gets a list of all roles
|
|
RoleList(r *pb.AuthRoleListRequest) (*pb.AuthRoleListResponse, error)
|
|
|
|
// IsPutPermitted checks put permission of the user
|
|
IsPutPermitted(authInfo *AuthInfo, key []byte) error
|
|
|
|
// IsRangePermitted checks range permission of the user
|
|
IsRangePermitted(authInfo *AuthInfo, key, rangeEnd []byte) error
|
|
|
|
// IsDeleteRangePermitted checks delete-range permission of the user
|
|
IsDeleteRangePermitted(authInfo *AuthInfo, key, rangeEnd []byte) error
|
|
|
|
// IsAdminPermitted checks admin permission of the user
|
|
IsAdminPermitted(authInfo *AuthInfo) error
|
|
|
|
// GenTokenPrefix produces a random string in a case of simple token
|
|
// in a case of JWT, it produces an empty string
|
|
GenTokenPrefix() (string, error)
|
|
|
|
// Revision gets current revision of authStore
|
|
Revision() uint64
|
|
|
|
// CheckPassword checks a given pair of username and password is correct
|
|
CheckPassword(username, password string) (uint64, error)
|
|
|
|
// Close does cleanup of AuthStore
|
|
Close() error
|
|
|
|
// AuthInfoFromCtx gets AuthInfo from gRPC's context
|
|
AuthInfoFromCtx(ctx context.Context) (*AuthInfo, error)
|
|
|
|
// AuthInfoFromTLS gets AuthInfo from TLS info of gRPC's context
|
|
AuthInfoFromTLS(ctx context.Context) *AuthInfo
|
|
|
|
// WithRoot generates and installs a token that can be used as a root credential
|
|
WithRoot(ctx context.Context) context.Context
|
|
|
|
// HasRole checks that user has role
|
|
HasRole(user, role string) bool
|
|
|
|
// BcryptCost gets strength of hashing bcrypted auth password
|
|
BcryptCost() int
|
|
}
|
|
|
|
type TokenProvider interface {
|
|
info(ctx context.Context, token string, revision uint64) (*AuthInfo, bool)
|
|
assign(ctx context.Context, username string, revision uint64) (string, error)
|
|
enable()
|
|
disable()
|
|
|
|
invalidateUser(string)
|
|
genTokenPrefix() (string, error)
|
|
}
|
|
|
|
type AuthBackend interface {
|
|
CreateAuthBuckets()
|
|
ForceCommit()
|
|
BatchTx() AuthBatchTx
|
|
|
|
GetUser(string) *authpb.User
|
|
GetAllUsers() []*authpb.User
|
|
GetRole(string) *authpb.Role
|
|
GetAllRoles() []*authpb.Role
|
|
}
|
|
|
|
type AuthBatchTx interface {
|
|
AuthReadTx
|
|
UnsafeSaveAuthEnabled(enabled bool)
|
|
UnsafeSaveAuthRevision(rev uint64)
|
|
UnsafePutUser(*authpb.User)
|
|
UnsafeDeleteUser(string)
|
|
UnsafePutRole(*authpb.Role)
|
|
UnsafeDeleteRole(string)
|
|
}
|
|
|
|
type AuthReadTx interface {
|
|
UnsafeReadAuthEnabled() bool
|
|
UnsafeReadAuthRevision() uint64
|
|
UnsafeGetUser(string) *authpb.User
|
|
UnsafeGetRole(string) *authpb.Role
|
|
UnsafeGetAllUsers() []*authpb.User
|
|
UnsafeGetAllRoles() []*authpb.Role
|
|
Lock()
|
|
Unlock()
|
|
}
|
|
|
|
type authStore struct {
|
|
// atomic operations; need 64-bit align, or 32-bit tests will crash
|
|
revision uint64
|
|
|
|
lg *zap.Logger
|
|
be AuthBackend
|
|
enabled bool
|
|
enabledMu sync.RWMutex
|
|
|
|
rangePermCache map[string]*unifiedRangePermissions // username -> unifiedRangePermissions
|
|
|
|
tokenProvider TokenProvider
|
|
bcryptCost int // the algorithm cost / strength for hashing auth passwords
|
|
}
|
|
|
|
func (as *authStore) AuthEnable() error {
|
|
as.enabledMu.Lock()
|
|
defer as.enabledMu.Unlock()
|
|
if as.enabled {
|
|
as.lg.Info("authentication is already enabled; ignored auth enable request")
|
|
return nil
|
|
}
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer func() {
|
|
tx.Unlock()
|
|
as.be.ForceCommit()
|
|
}()
|
|
|
|
u := tx.UnsafeGetUser(rootUser)
|
|
if u == nil {
|
|
return ErrRootUserNotExist
|
|
}
|
|
|
|
if !hasRootRole(u) {
|
|
return ErrRootRoleNotExist
|
|
}
|
|
|
|
tx.UnsafeSaveAuthEnabled(true)
|
|
as.enabled = true
|
|
as.tokenProvider.enable()
|
|
|
|
as.rangePermCache = make(map[string]*unifiedRangePermissions)
|
|
|
|
as.setRevision(tx.UnsafeReadAuthRevision())
|
|
|
|
as.lg.Info("enabled authentication")
|
|
return nil
|
|
}
|
|
|
|
func (as *authStore) AuthDisable() {
|
|
as.enabledMu.Lock()
|
|
defer as.enabledMu.Unlock()
|
|
if !as.enabled {
|
|
return
|
|
}
|
|
b := as.be
|
|
|
|
tx := b.BatchTx()
|
|
tx.Lock()
|
|
tx.UnsafeSaveAuthEnabled(false)
|
|
as.commitRevision(tx)
|
|
tx.Unlock()
|
|
|
|
b.ForceCommit()
|
|
|
|
as.enabled = false
|
|
as.tokenProvider.disable()
|
|
|
|
as.lg.Info("disabled authentication")
|
|
}
|
|
|
|
func (as *authStore) Close() error {
|
|
as.enabledMu.Lock()
|
|
defer as.enabledMu.Unlock()
|
|
if !as.enabled {
|
|
return nil
|
|
}
|
|
as.tokenProvider.disable()
|
|
return nil
|
|
}
|
|
|
|
func (as *authStore) Authenticate(ctx context.Context, username, password string) (*pb.AuthenticateResponse, error) {
|
|
if !as.IsAuthEnabled() {
|
|
return nil, ErrAuthNotEnabled
|
|
}
|
|
user := as.be.GetUser(username)
|
|
if user == nil {
|
|
return nil, ErrAuthFailed
|
|
}
|
|
|
|
if user.Options != nil && user.Options.NoPassword {
|
|
return nil, ErrAuthFailed
|
|
}
|
|
|
|
// Password checking is already performed in the API layer, so we don't need to check for now.
|
|
// Staleness of password can be detected with OCC in the API layer, too.
|
|
|
|
token, err := as.tokenProvider.assign(ctx, username, as.Revision())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
as.lg.Debug(
|
|
"authenticated a user",
|
|
zap.String("user-name", username),
|
|
zap.String("token", token),
|
|
)
|
|
return &pb.AuthenticateResponse{Token: token}, nil
|
|
}
|
|
|
|
func (as *authStore) CheckPassword(username, password string) (uint64, error) {
|
|
if !as.IsAuthEnabled() {
|
|
return 0, ErrAuthNotEnabled
|
|
}
|
|
|
|
var user *authpb.User
|
|
// CompareHashAndPassword is very expensive, so we use closures
|
|
// to avoid putting it in the critical section of the tx lock.
|
|
revision, err := func() (uint64, error) {
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
user = tx.UnsafeGetUser(username)
|
|
if user == nil {
|
|
return 0, ErrAuthFailed
|
|
}
|
|
|
|
if user.Options != nil && user.Options.NoPassword {
|
|
return 0, ErrNoPasswordUser
|
|
}
|
|
|
|
return tx.UnsafeReadAuthRevision(), nil
|
|
}()
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
|
|
if bcrypt.CompareHashAndPassword(user.Password, []byte(password)) != nil {
|
|
as.lg.Info("invalid password", zap.String("user-name", username))
|
|
return 0, ErrAuthFailed
|
|
}
|
|
return revision, nil
|
|
}
|
|
|
|
func (as *authStore) Recover(be AuthBackend) {
|
|
as.be = be
|
|
tx := be.BatchTx()
|
|
tx.Lock()
|
|
|
|
enabled := tx.UnsafeReadAuthEnabled()
|
|
as.setRevision(tx.UnsafeReadAuthRevision())
|
|
|
|
tx.Unlock()
|
|
|
|
as.enabledMu.Lock()
|
|
as.enabled = enabled
|
|
if enabled {
|
|
as.tokenProvider.enable()
|
|
}
|
|
as.enabledMu.Unlock()
|
|
}
|
|
|
|
func (as *authStore) selectPassword(password string, hashedPassword string) ([]byte, error) {
|
|
if password != "" && hashedPassword == "" {
|
|
// This path is for processing log entries created by etcd whose version is older than 3.5
|
|
return bcrypt.GenerateFromPassword([]byte(password), as.bcryptCost)
|
|
}
|
|
return base64.StdEncoding.DecodeString(hashedPassword)
|
|
}
|
|
|
|
func (as *authStore) UserAdd(r *pb.AuthUserAddRequest) (*pb.AuthUserAddResponse, error) {
|
|
if len(r.Name) == 0 {
|
|
return nil, ErrUserEmpty
|
|
}
|
|
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
user := tx.UnsafeGetUser(r.Name)
|
|
if user != nil {
|
|
return nil, ErrUserAlreadyExist
|
|
}
|
|
|
|
options := r.Options
|
|
if options == nil {
|
|
options = &authpb.UserAddOptions{
|
|
NoPassword: false,
|
|
}
|
|
}
|
|
|
|
var password []byte
|
|
var err error
|
|
|
|
if !options.NoPassword {
|
|
password, err = as.selectPassword(r.Password, r.HashedPassword)
|
|
if err != nil {
|
|
return nil, ErrNoPasswordUser
|
|
}
|
|
}
|
|
|
|
newUser := &authpb.User{
|
|
Name: []byte(r.Name),
|
|
Password: password,
|
|
Options: options,
|
|
}
|
|
tx.UnsafePutUser(newUser)
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.lg.Info("added a user", zap.String("user-name", r.Name))
|
|
return &pb.AuthUserAddResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) UserDelete(r *pb.AuthUserDeleteRequest) (*pb.AuthUserDeleteResponse, error) {
|
|
if as.enabled && r.Name == rootUser {
|
|
as.lg.Error("cannot delete 'root' user", zap.String("user-name", r.Name))
|
|
return nil, ErrInvalidAuthMgmt
|
|
}
|
|
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
user := tx.UnsafeGetUser(r.Name)
|
|
if user == nil {
|
|
return nil, ErrUserNotFound
|
|
}
|
|
tx.UnsafeDeleteUser(r.Name)
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.invalidateCachedPerm(r.Name)
|
|
as.tokenProvider.invalidateUser(r.Name)
|
|
|
|
as.lg.Info(
|
|
"deleted a user",
|
|
zap.String("user-name", r.Name),
|
|
zap.Strings("user-roles", user.Roles),
|
|
)
|
|
return &pb.AuthUserDeleteResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) UserChangePassword(r *pb.AuthUserChangePasswordRequest) (*pb.AuthUserChangePasswordResponse, error) {
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
user := tx.UnsafeGetUser(r.Name)
|
|
if user == nil {
|
|
return nil, ErrUserNotFound
|
|
}
|
|
|
|
var password []byte
|
|
var err error
|
|
|
|
if !user.Options.NoPassword {
|
|
password, err = as.selectPassword(r.Password, r.HashedPassword)
|
|
if err != nil {
|
|
return nil, ErrNoPasswordUser
|
|
}
|
|
}
|
|
|
|
updatedUser := &authpb.User{
|
|
Name: []byte(r.Name),
|
|
Roles: user.Roles,
|
|
Password: password,
|
|
Options: user.Options,
|
|
}
|
|
tx.UnsafePutUser(updatedUser)
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.invalidateCachedPerm(r.Name)
|
|
as.tokenProvider.invalidateUser(r.Name)
|
|
|
|
as.lg.Info(
|
|
"changed a password of a user",
|
|
zap.String("user-name", r.Name),
|
|
zap.Strings("user-roles", user.Roles),
|
|
)
|
|
return &pb.AuthUserChangePasswordResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) UserGrantRole(r *pb.AuthUserGrantRoleRequest) (*pb.AuthUserGrantRoleResponse, error) {
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
user := tx.UnsafeGetUser(r.User)
|
|
if user == nil {
|
|
return nil, ErrUserNotFound
|
|
}
|
|
|
|
if r.Role != rootRole {
|
|
role := tx.UnsafeGetRole(r.Role)
|
|
if role == nil {
|
|
return nil, ErrRoleNotFound
|
|
}
|
|
}
|
|
|
|
idx := sort.SearchStrings(user.Roles, r.Role)
|
|
if idx < len(user.Roles) && user.Roles[idx] == r.Role {
|
|
as.lg.Warn(
|
|
"ignored grant role request to a user",
|
|
zap.String("user-name", r.User),
|
|
zap.Strings("user-roles", user.Roles),
|
|
zap.String("duplicate-role-name", r.Role),
|
|
)
|
|
return &pb.AuthUserGrantRoleResponse{}, nil
|
|
}
|
|
|
|
user.Roles = append(user.Roles, r.Role)
|
|
sort.Strings(user.Roles)
|
|
|
|
tx.UnsafePutUser(user)
|
|
|
|
as.invalidateCachedPerm(r.User)
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.lg.Info(
|
|
"granted a role to a user",
|
|
zap.String("user-name", r.User),
|
|
zap.Strings("user-roles", user.Roles),
|
|
zap.String("added-role-name", r.Role),
|
|
)
|
|
return &pb.AuthUserGrantRoleResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) UserGet(r *pb.AuthUserGetRequest) (*pb.AuthUserGetResponse, error) {
|
|
user := as.be.GetUser(r.Name)
|
|
|
|
if user == nil {
|
|
return nil, ErrUserNotFound
|
|
}
|
|
|
|
var resp pb.AuthUserGetResponse
|
|
resp.Roles = append(resp.Roles, user.Roles...)
|
|
return &resp, nil
|
|
}
|
|
|
|
func (as *authStore) UserList(r *pb.AuthUserListRequest) (*pb.AuthUserListResponse, error) {
|
|
users := as.be.GetAllUsers()
|
|
|
|
resp := &pb.AuthUserListResponse{Users: make([]string, len(users))}
|
|
for i := range users {
|
|
resp.Users[i] = string(users[i].Name)
|
|
}
|
|
return resp, nil
|
|
}
|
|
|
|
func (as *authStore) UserRevokeRole(r *pb.AuthUserRevokeRoleRequest) (*pb.AuthUserRevokeRoleResponse, error) {
|
|
if as.enabled && r.Name == rootUser && r.Role == rootRole {
|
|
as.lg.Error(
|
|
"'root' user cannot revoke 'root' role",
|
|
zap.String("user-name", r.Name),
|
|
zap.String("role-name", r.Role),
|
|
)
|
|
return nil, ErrInvalidAuthMgmt
|
|
}
|
|
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
user := tx.UnsafeGetUser(r.Name)
|
|
if user == nil {
|
|
return nil, ErrUserNotFound
|
|
}
|
|
|
|
updatedUser := &authpb.User{
|
|
Name: user.Name,
|
|
Password: user.Password,
|
|
Options: user.Options,
|
|
}
|
|
|
|
for _, role := range user.Roles {
|
|
if role != r.Role {
|
|
updatedUser.Roles = append(updatedUser.Roles, role)
|
|
}
|
|
}
|
|
|
|
if len(updatedUser.Roles) == len(user.Roles) {
|
|
return nil, ErrRoleNotGranted
|
|
}
|
|
|
|
tx.UnsafePutUser(updatedUser)
|
|
|
|
as.invalidateCachedPerm(r.Name)
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.lg.Info(
|
|
"revoked a role from a user",
|
|
zap.String("user-name", r.Name),
|
|
zap.Strings("old-user-roles", user.Roles),
|
|
zap.Strings("new-user-roles", updatedUser.Roles),
|
|
zap.String("revoked-role-name", r.Role),
|
|
)
|
|
return &pb.AuthUserRevokeRoleResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) RoleGet(r *pb.AuthRoleGetRequest) (*pb.AuthRoleGetResponse, error) {
|
|
var resp pb.AuthRoleGetResponse
|
|
|
|
role := as.be.GetRole(r.Role)
|
|
if role == nil {
|
|
return nil, ErrRoleNotFound
|
|
}
|
|
if rootRole == string(role.Name) {
|
|
resp.Perm = append(resp.Perm, &rootPerm)
|
|
} else {
|
|
resp.Perm = append(resp.Perm, role.KeyPermission...)
|
|
}
|
|
return &resp, nil
|
|
}
|
|
|
|
func (as *authStore) RoleList(r *pb.AuthRoleListRequest) (*pb.AuthRoleListResponse, error) {
|
|
roles := as.be.GetAllRoles()
|
|
|
|
resp := &pb.AuthRoleListResponse{Roles: make([]string, len(roles))}
|
|
for i := range roles {
|
|
resp.Roles[i] = string(roles[i].Name)
|
|
}
|
|
return resp, nil
|
|
}
|
|
|
|
func (as *authStore) RoleRevokePermission(r *pb.AuthRoleRevokePermissionRequest) (*pb.AuthRoleRevokePermissionResponse, error) {
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
role := tx.UnsafeGetRole(r.Role)
|
|
if role == nil {
|
|
return nil, ErrRoleNotFound
|
|
}
|
|
|
|
updatedRole := &authpb.Role{
|
|
Name: role.Name,
|
|
}
|
|
|
|
for _, perm := range role.KeyPermission {
|
|
if !bytes.Equal(perm.Key, r.Key) || !bytes.Equal(perm.RangeEnd, r.RangeEnd) {
|
|
updatedRole.KeyPermission = append(updatedRole.KeyPermission, perm)
|
|
}
|
|
}
|
|
|
|
if len(role.KeyPermission) == len(updatedRole.KeyPermission) {
|
|
return nil, ErrPermissionNotGranted
|
|
}
|
|
|
|
tx.UnsafePutRole(updatedRole)
|
|
|
|
// TODO(mitake): currently single role update invalidates every cache
|
|
// It should be optimized.
|
|
as.clearCachedPerm()
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.lg.Info(
|
|
"revoked a permission on range",
|
|
zap.String("role-name", r.Role),
|
|
zap.String("key", string(r.Key)),
|
|
zap.String("range-end", string(r.RangeEnd)),
|
|
)
|
|
return &pb.AuthRoleRevokePermissionResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) RoleDelete(r *pb.AuthRoleDeleteRequest) (*pb.AuthRoleDeleteResponse, error) {
|
|
if as.enabled && r.Role == rootRole {
|
|
as.lg.Error("cannot delete 'root' role", zap.String("role-name", r.Role))
|
|
return nil, ErrInvalidAuthMgmt
|
|
}
|
|
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
role := tx.UnsafeGetRole(r.Role)
|
|
if role == nil {
|
|
return nil, ErrRoleNotFound
|
|
}
|
|
|
|
tx.UnsafeDeleteRole(r.Role)
|
|
|
|
users := tx.UnsafeGetAllUsers()
|
|
for _, user := range users {
|
|
updatedUser := &authpb.User{
|
|
Name: user.Name,
|
|
Password: user.Password,
|
|
Options: user.Options,
|
|
}
|
|
|
|
for _, role := range user.Roles {
|
|
if role != r.Role {
|
|
updatedUser.Roles = append(updatedUser.Roles, role)
|
|
}
|
|
}
|
|
|
|
if len(updatedUser.Roles) == len(user.Roles) {
|
|
continue
|
|
}
|
|
|
|
tx.UnsafePutUser(updatedUser)
|
|
|
|
as.invalidateCachedPerm(string(user.Name))
|
|
}
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.lg.Info("deleted a role", zap.String("role-name", r.Role))
|
|
return &pb.AuthRoleDeleteResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) RoleAdd(r *pb.AuthRoleAddRequest) (*pb.AuthRoleAddResponse, error) {
|
|
if len(r.Name) == 0 {
|
|
return nil, ErrRoleEmpty
|
|
}
|
|
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
role := tx.UnsafeGetRole(r.Name)
|
|
if role != nil {
|
|
return nil, ErrRoleAlreadyExist
|
|
}
|
|
|
|
newRole := &authpb.Role{
|
|
Name: []byte(r.Name),
|
|
}
|
|
|
|
tx.UnsafePutRole(newRole)
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.lg.Info("created a role", zap.String("role-name", r.Name))
|
|
return &pb.AuthRoleAddResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) authInfoFromToken(ctx context.Context, token string) (*AuthInfo, bool) {
|
|
return as.tokenProvider.info(ctx, token, as.Revision())
|
|
}
|
|
|
|
type permSlice []*authpb.Permission
|
|
|
|
func (perms permSlice) Len() int {
|
|
return len(perms)
|
|
}
|
|
|
|
func (perms permSlice) Less(i, j int) bool {
|
|
return bytes.Compare(perms[i].Key, perms[j].Key) < 0
|
|
}
|
|
|
|
func (perms permSlice) Swap(i, j int) {
|
|
perms[i], perms[j] = perms[j], perms[i]
|
|
}
|
|
|
|
func (as *authStore) RoleGrantPermission(r *pb.AuthRoleGrantPermissionRequest) (*pb.AuthRoleGrantPermissionResponse, error) {
|
|
if r.Perm == nil {
|
|
return nil, ErrPermissionNotGiven
|
|
}
|
|
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
role := tx.UnsafeGetRole(r.Name)
|
|
if role == nil {
|
|
return nil, ErrRoleNotFound
|
|
}
|
|
|
|
idx := sort.Search(len(role.KeyPermission), func(i int) bool {
|
|
return bytes.Compare(role.KeyPermission[i].Key, r.Perm.Key) >= 0
|
|
})
|
|
|
|
if idx < len(role.KeyPermission) && bytes.Equal(role.KeyPermission[idx].Key, r.Perm.Key) && bytes.Equal(role.KeyPermission[idx].RangeEnd, r.Perm.RangeEnd) {
|
|
// update existing permission
|
|
role.KeyPermission[idx].PermType = r.Perm.PermType
|
|
} else {
|
|
// append new permission to the role
|
|
newPerm := &authpb.Permission{
|
|
Key: r.Perm.Key,
|
|
RangeEnd: r.Perm.RangeEnd,
|
|
PermType: r.Perm.PermType,
|
|
}
|
|
|
|
role.KeyPermission = append(role.KeyPermission, newPerm)
|
|
sort.Sort(permSlice(role.KeyPermission))
|
|
}
|
|
|
|
tx.UnsafePutRole(role)
|
|
|
|
// TODO(mitake): currently single role update invalidates every cache
|
|
// It should be optimized.
|
|
as.clearCachedPerm()
|
|
|
|
as.commitRevision(tx)
|
|
|
|
as.lg.Info(
|
|
"granted/updated a permission to a user",
|
|
zap.String("user-name", r.Name),
|
|
zap.String("permission-name", authpb.Permission_Type_name[int32(r.Perm.PermType)]),
|
|
)
|
|
return &pb.AuthRoleGrantPermissionResponse{}, nil
|
|
}
|
|
|
|
func (as *authStore) isOpPermitted(userName string, revision uint64, key, rangeEnd []byte, permTyp authpb.Permission_Type) error {
|
|
// TODO(mitake): this function would be costly so we need a caching mechanism
|
|
if !as.IsAuthEnabled() {
|
|
return nil
|
|
}
|
|
|
|
// only gets rev == 0 when passed AuthInfo{}; no user given
|
|
if revision == 0 {
|
|
return ErrUserEmpty
|
|
}
|
|
rev := as.Revision()
|
|
if revision < rev {
|
|
as.lg.Warn("request auth revision is less than current node auth revision",
|
|
zap.Uint64("current node auth revision", rev),
|
|
zap.Uint64("request auth revision", revision),
|
|
zap.ByteString("request key", key),
|
|
zap.Error(ErrAuthOldRevision))
|
|
return ErrAuthOldRevision
|
|
}
|
|
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
defer tx.Unlock()
|
|
|
|
user := tx.UnsafeGetUser(userName)
|
|
if user == nil {
|
|
as.lg.Error("cannot find a user for permission check", zap.String("user-name", userName))
|
|
return ErrPermissionDenied
|
|
}
|
|
|
|
// root role should have permission on all ranges
|
|
if hasRootRole(user) {
|
|
return nil
|
|
}
|
|
|
|
if as.isRangeOpPermitted(tx, userName, key, rangeEnd, permTyp) {
|
|
return nil
|
|
}
|
|
|
|
return ErrPermissionDenied
|
|
}
|
|
|
|
func (as *authStore) IsPutPermitted(authInfo *AuthInfo, key []byte) error {
|
|
return as.isOpPermitted(authInfo.Username, authInfo.Revision, key, nil, authpb.WRITE)
|
|
}
|
|
|
|
func (as *authStore) IsRangePermitted(authInfo *AuthInfo, key, rangeEnd []byte) error {
|
|
return as.isOpPermitted(authInfo.Username, authInfo.Revision, key, rangeEnd, authpb.READ)
|
|
}
|
|
|
|
func (as *authStore) IsDeleteRangePermitted(authInfo *AuthInfo, key, rangeEnd []byte) error {
|
|
return as.isOpPermitted(authInfo.Username, authInfo.Revision, key, rangeEnd, authpb.WRITE)
|
|
}
|
|
|
|
func (as *authStore) IsAdminPermitted(authInfo *AuthInfo) error {
|
|
if !as.IsAuthEnabled() {
|
|
return nil
|
|
}
|
|
if authInfo == nil || authInfo.Username == "" {
|
|
return ErrUserEmpty
|
|
}
|
|
|
|
u := as.be.GetUser(authInfo.Username)
|
|
|
|
if u == nil {
|
|
return ErrUserNotFound
|
|
}
|
|
|
|
if !hasRootRole(u) {
|
|
return ErrPermissionDenied
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (as *authStore) IsAuthEnabled() bool {
|
|
as.enabledMu.RLock()
|
|
defer as.enabledMu.RUnlock()
|
|
return as.enabled
|
|
}
|
|
|
|
// NewAuthStore creates a new AuthStore.
|
|
func NewAuthStore(lg *zap.Logger, be AuthBackend, tp TokenProvider, bcryptCost int) *authStore {
|
|
if lg == nil {
|
|
lg = zap.NewNop()
|
|
}
|
|
|
|
if bcryptCost < bcrypt.MinCost || bcryptCost > bcrypt.MaxCost {
|
|
lg.Warn(
|
|
"use default bcrypt cost instead of the invalid given cost",
|
|
zap.Int("min-cost", bcrypt.MinCost),
|
|
zap.Int("max-cost", bcrypt.MaxCost),
|
|
zap.Int("default-cost", bcrypt.DefaultCost),
|
|
zap.Int("given-cost", bcryptCost),
|
|
)
|
|
bcryptCost = bcrypt.DefaultCost
|
|
}
|
|
|
|
be.CreateAuthBuckets()
|
|
tx := be.BatchTx()
|
|
tx.Lock()
|
|
enabled := tx.UnsafeReadAuthEnabled()
|
|
as := &authStore{
|
|
revision: tx.UnsafeReadAuthRevision(),
|
|
lg: lg,
|
|
be: be,
|
|
enabled: enabled,
|
|
rangePermCache: make(map[string]*unifiedRangePermissions),
|
|
tokenProvider: tp,
|
|
bcryptCost: bcryptCost,
|
|
}
|
|
|
|
if enabled {
|
|
as.tokenProvider.enable()
|
|
}
|
|
|
|
if as.Revision() == 0 {
|
|
as.commitRevision(tx)
|
|
}
|
|
|
|
as.setupMetricsReporter()
|
|
|
|
tx.Unlock()
|
|
be.ForceCommit()
|
|
|
|
return as
|
|
}
|
|
|
|
func hasRootRole(u *authpb.User) bool {
|
|
// u.Roles is sorted in UserGrantRole(), so we can use binary search.
|
|
idx := sort.SearchStrings(u.Roles, rootRole)
|
|
return idx != len(u.Roles) && u.Roles[idx] == rootRole
|
|
}
|
|
|
|
func (as *authStore) commitRevision(tx AuthBatchTx) {
|
|
atomic.AddUint64(&as.revision, 1)
|
|
tx.UnsafeSaveAuthRevision(as.Revision())
|
|
}
|
|
|
|
func (as *authStore) setRevision(rev uint64) {
|
|
atomic.StoreUint64(&as.revision, rev)
|
|
}
|
|
|
|
func (as *authStore) Revision() uint64 {
|
|
return atomic.LoadUint64(&as.revision)
|
|
}
|
|
|
|
func (as *authStore) AuthInfoFromTLS(ctx context.Context) (ai *AuthInfo) {
|
|
peer, ok := peer.FromContext(ctx)
|
|
if !ok || peer == nil || peer.AuthInfo == nil {
|
|
return nil
|
|
}
|
|
|
|
tlsInfo := peer.AuthInfo.(credentials.TLSInfo)
|
|
for _, chains := range tlsInfo.State.VerifiedChains {
|
|
if len(chains) < 1 {
|
|
continue
|
|
}
|
|
ai = &AuthInfo{
|
|
Username: chains[0].Subject.CommonName,
|
|
Revision: as.Revision(),
|
|
}
|
|
md, ok := metadata.FromIncomingContext(ctx)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
|
|
// gRPC-gateway proxy request to etcd server includes Grpcgateway-Accept
|
|
// header. The proxy uses etcd client server certificate. If the certificate
|
|
// has a CommonName we should never use this for authentication.
|
|
if gw := md["grpcgateway-accept"]; len(gw) > 0 {
|
|
as.lg.Warn(
|
|
"ignoring common name in gRPC-gateway proxy request",
|
|
zap.String("common-name", ai.Username),
|
|
zap.String("user-name", ai.Username),
|
|
zap.Uint64("revision", ai.Revision),
|
|
)
|
|
return nil
|
|
}
|
|
as.lg.Debug(
|
|
"found command name",
|
|
zap.String("common-name", ai.Username),
|
|
zap.String("user-name", ai.Username),
|
|
zap.Uint64("revision", ai.Revision),
|
|
)
|
|
break
|
|
}
|
|
return ai
|
|
}
|
|
|
|
func (as *authStore) AuthInfoFromCtx(ctx context.Context) (*AuthInfo, error) {
|
|
if !as.IsAuthEnabled() {
|
|
return nil, nil
|
|
}
|
|
|
|
md, ok := metadata.FromIncomingContext(ctx)
|
|
if !ok {
|
|
return nil, nil
|
|
}
|
|
|
|
//TODO(mitake|hexfusion) review unifying key names
|
|
ts, ok := md[rpctypes.TokenFieldNameGRPC]
|
|
if !ok {
|
|
ts, ok = md[rpctypes.TokenFieldNameSwagger]
|
|
}
|
|
if !ok {
|
|
return nil, nil
|
|
}
|
|
|
|
token := ts[0]
|
|
authInfo, uok := as.authInfoFromToken(ctx, token)
|
|
if !uok {
|
|
as.lg.Warn("invalid auth token", zap.String("token", token))
|
|
return nil, ErrInvalidAuthToken
|
|
}
|
|
|
|
return authInfo, nil
|
|
}
|
|
|
|
func (as *authStore) GenTokenPrefix() (string, error) {
|
|
return as.tokenProvider.genTokenPrefix()
|
|
}
|
|
|
|
func decomposeOpts(lg *zap.Logger, optstr string) (string, map[string]string, error) {
|
|
opts := strings.Split(optstr, ",")
|
|
tokenType := opts[0]
|
|
|
|
typeSpecificOpts := make(map[string]string)
|
|
for i := 1; i < len(opts); i++ {
|
|
pair := strings.Split(opts[i], "=")
|
|
|
|
if len(pair) != 2 {
|
|
if lg != nil {
|
|
lg.Error("invalid token option", zap.String("option", optstr))
|
|
}
|
|
return "", nil, ErrInvalidAuthOpts
|
|
}
|
|
|
|
if _, ok := typeSpecificOpts[pair[0]]; ok {
|
|
if lg != nil {
|
|
lg.Error(
|
|
"invalid token option",
|
|
zap.String("option", optstr),
|
|
zap.String("duplicate-parameter", pair[0]),
|
|
)
|
|
}
|
|
return "", nil, ErrInvalidAuthOpts
|
|
}
|
|
|
|
typeSpecificOpts[pair[0]] = pair[1]
|
|
}
|
|
|
|
return tokenType, typeSpecificOpts, nil
|
|
|
|
}
|
|
|
|
// NewTokenProvider creates a new token provider.
|
|
func NewTokenProvider(
|
|
lg *zap.Logger,
|
|
tokenOpts string,
|
|
indexWaiter func(uint64) <-chan struct{},
|
|
TokenTTL time.Duration) (TokenProvider, error) {
|
|
tokenType, typeSpecificOpts, err := decomposeOpts(lg, tokenOpts)
|
|
if err != nil {
|
|
return nil, ErrInvalidAuthOpts
|
|
}
|
|
|
|
switch tokenType {
|
|
case tokenTypeSimple:
|
|
if lg != nil {
|
|
lg.Warn("simple token is not cryptographically signed")
|
|
}
|
|
return newTokenProviderSimple(lg, indexWaiter, TokenTTL), nil
|
|
|
|
case tokenTypeJWT:
|
|
return newTokenProviderJWT(lg, typeSpecificOpts)
|
|
|
|
case "":
|
|
return newTokenProviderNop()
|
|
|
|
default:
|
|
if lg != nil {
|
|
lg.Warn(
|
|
"unknown token type",
|
|
zap.String("type", tokenType),
|
|
zap.Error(ErrInvalidAuthOpts),
|
|
)
|
|
}
|
|
return nil, ErrInvalidAuthOpts
|
|
}
|
|
}
|
|
|
|
func (as *authStore) WithRoot(ctx context.Context) context.Context {
|
|
if !as.IsAuthEnabled() {
|
|
return ctx
|
|
}
|
|
|
|
var ctxForAssign context.Context
|
|
if ts, ok := as.tokenProvider.(*tokenSimple); ok && ts != nil {
|
|
ctx1 := context.WithValue(ctx, AuthenticateParamIndex{}, uint64(0))
|
|
prefix, err := ts.genTokenPrefix()
|
|
if err != nil {
|
|
as.lg.Error(
|
|
"failed to generate prefix of internally used token",
|
|
zap.Error(err),
|
|
)
|
|
return ctx
|
|
}
|
|
ctxForAssign = context.WithValue(ctx1, AuthenticateParamSimpleTokenPrefix{}, prefix)
|
|
} else {
|
|
ctxForAssign = ctx
|
|
}
|
|
|
|
token, err := as.tokenProvider.assign(ctxForAssign, "root", as.Revision())
|
|
if err != nil {
|
|
// this must not happen
|
|
as.lg.Error(
|
|
"failed to assign token for lease revoking",
|
|
zap.Error(err),
|
|
)
|
|
return ctx
|
|
}
|
|
|
|
mdMap := map[string]string{
|
|
rpctypes.TokenFieldNameGRPC: token,
|
|
}
|
|
tokenMD := metadata.New(mdMap)
|
|
|
|
// use "mdIncomingKey{}" since it's called from local etcdserver
|
|
return metadata.NewIncomingContext(ctx, tokenMD)
|
|
}
|
|
|
|
func (as *authStore) HasRole(user, role string) bool {
|
|
tx := as.be.BatchTx()
|
|
tx.Lock()
|
|
u := tx.UnsafeGetUser(user)
|
|
tx.Unlock()
|
|
|
|
if u == nil {
|
|
as.lg.Warn(
|
|
"'has-role' requested for non-existing user",
|
|
zap.String("user-name", user),
|
|
zap.String("role-name", role),
|
|
)
|
|
return false
|
|
}
|
|
|
|
for _, r := range u.Roles {
|
|
if role == r {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (as *authStore) BcryptCost() int {
|
|
return as.bcryptCost
|
|
}
|
|
|
|
func (as *authStore) setupMetricsReporter() {
|
|
reportCurrentAuthRevMu.Lock()
|
|
reportCurrentAuthRev = func() float64 {
|
|
return float64(as.Revision())
|
|
}
|
|
reportCurrentAuthRevMu.Unlock()
|
|
}
|