mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00
6bf609b96d
Update TestMemberPromote to include both learner not-ready and learner ready test cases. Removed unit test TestPromoteMember, it requires underlying raft node to be started and running. The member promote is covered by the integration test.
334 lines
9.5 KiB
Go
334 lines
9.5 KiB
Go
// Copyright 2016 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package integration
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"go.etcd.io/etcd/integration"
|
|
"go.etcd.io/etcd/pkg/testutil"
|
|
"go.etcd.io/etcd/pkg/types"
|
|
)
|
|
|
|
func TestMemberList(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
|
|
capi := clus.RandClient()
|
|
|
|
resp, err := capi.MemberList(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("failed to list member %v", err)
|
|
}
|
|
|
|
if len(resp.Members) != 3 {
|
|
t.Errorf("number of members = %d, want %d", len(resp.Members), 3)
|
|
}
|
|
}
|
|
|
|
func TestMemberAdd(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
|
|
capi := clus.RandClient()
|
|
|
|
urls := []string{"http://127.0.0.1:1234"}
|
|
resp, err := capi.MemberAdd(context.Background(), urls)
|
|
if err != nil {
|
|
t.Fatalf("failed to add member %v", err)
|
|
}
|
|
|
|
if !reflect.DeepEqual(resp.Member.PeerURLs, urls) {
|
|
t.Errorf("urls = %v, want %v", urls, resp.Member.PeerURLs)
|
|
}
|
|
}
|
|
|
|
func TestMemberAddWithExistingURLs(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
|
|
capi := clus.RandClient()
|
|
|
|
resp, err := capi.MemberList(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("failed to list member %v", err)
|
|
}
|
|
|
|
existingURL := resp.Members[0].PeerURLs[0]
|
|
_, err = capi.MemberAdd(context.Background(), []string{existingURL})
|
|
expectedErrKeywords := "Peer URLs already exists"
|
|
if err == nil {
|
|
t.Fatalf("expecting add member to fail, got no error")
|
|
}
|
|
if !strings.Contains(err.Error(), expectedErrKeywords) {
|
|
t.Errorf("expecting error to contain %s, got %s", expectedErrKeywords, err.Error())
|
|
}
|
|
}
|
|
|
|
func TestMemberRemove(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
|
|
capi := clus.Client(1)
|
|
resp, err := capi.MemberList(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("failed to list member %v", err)
|
|
}
|
|
|
|
rmvID := resp.Members[0].ID
|
|
// indexes in capi member list don't necessarily match cluster member list;
|
|
// find member that is not the client to remove
|
|
for _, m := range resp.Members {
|
|
mURLs, _ := types.NewURLs(m.PeerURLs)
|
|
if !reflect.DeepEqual(mURLs, clus.Members[1].ServerConfig.PeerURLs) {
|
|
rmvID = m.ID
|
|
break
|
|
}
|
|
}
|
|
|
|
_, err = capi.MemberRemove(context.Background(), rmvID)
|
|
if err != nil {
|
|
t.Fatalf("failed to remove member %v", err)
|
|
}
|
|
|
|
resp, err = capi.MemberList(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("failed to list member %v", err)
|
|
}
|
|
|
|
if len(resp.Members) != 2 {
|
|
t.Errorf("number of members = %d, want %d", len(resp.Members), 2)
|
|
}
|
|
}
|
|
|
|
func TestMemberUpdate(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
|
|
capi := clus.RandClient()
|
|
resp, err := capi.MemberList(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("failed to list member %v", err)
|
|
}
|
|
|
|
urls := []string{"http://127.0.0.1:1234"}
|
|
_, err = capi.MemberUpdate(context.Background(), resp.Members[0].ID, urls)
|
|
if err != nil {
|
|
t.Fatalf("failed to update member %v", err)
|
|
}
|
|
|
|
resp, err = capi.MemberList(context.Background())
|
|
if err != nil {
|
|
t.Fatalf("failed to list member %v", err)
|
|
}
|
|
|
|
if !reflect.DeepEqual(resp.Members[0].PeerURLs, urls) {
|
|
t.Errorf("urls = %v, want %v", urls, resp.Members[0].PeerURLs)
|
|
}
|
|
}
|
|
|
|
func TestMemberAddUpdateWrongURLs(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 1})
|
|
defer clus.Terminate(t)
|
|
|
|
capi := clus.RandClient()
|
|
tt := [][]string{
|
|
// missing protocol scheme
|
|
{"://127.0.0.1:2379"},
|
|
// unsupported scheme
|
|
{"mailto://127.0.0.1:2379"},
|
|
// not conform to host:port
|
|
{"http://127.0.0.1"},
|
|
// contain a path
|
|
{"http://127.0.0.1:2379/path"},
|
|
// first path segment in URL cannot contain colon
|
|
{"127.0.0.1:1234"},
|
|
// URL scheme must be http, https, unix, or unixs
|
|
{"localhost:1234"},
|
|
}
|
|
for i := range tt {
|
|
_, err := capi.MemberAdd(context.Background(), tt[i])
|
|
if err == nil {
|
|
t.Errorf("#%d: MemberAdd err = nil, but error", i)
|
|
}
|
|
_, err = capi.MemberUpdate(context.Background(), 0, tt[i])
|
|
if err == nil {
|
|
t.Errorf("#%d: MemberUpdate err = nil, but error", i)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestMemberAddForLearner(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
|
|
capi := clus.RandClient()
|
|
|
|
urls := []string{"http://127.0.0.1:1234"}
|
|
resp, err := capi.MemberAddAsLearner(context.Background(), urls)
|
|
if err != nil {
|
|
t.Fatalf("failed to add member %v", err)
|
|
}
|
|
|
|
if !resp.Member.IsLearner {
|
|
t.Errorf("Added a member as learner, got resp.Member.IsLearner = %v", resp.Member.IsLearner)
|
|
}
|
|
|
|
numberOfLearners := 0
|
|
for _, m := range resp.Members {
|
|
if m.IsLearner {
|
|
numberOfLearners++
|
|
}
|
|
}
|
|
if numberOfLearners != 1 {
|
|
t.Errorf("Added 1 learner node to cluster, got %d", numberOfLearners)
|
|
}
|
|
}
|
|
|
|
func TestMemberPromote(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
|
|
// member promote request can be sent to any server in cluster,
|
|
// the request will be auto-forwarded to leader on server-side.
|
|
// This test explicitly includes the server-side forwarding by
|
|
// sending the request to follower.
|
|
leaderIdx := clus.WaitLeader(t)
|
|
followerIdx := (leaderIdx + 1) % 3
|
|
capi := clus.Client(followerIdx)
|
|
|
|
urls := []string{"http://127.0.0.1:1234"}
|
|
memberAddResp, err := capi.MemberAddAsLearner(context.Background(), urls)
|
|
if err != nil {
|
|
t.Fatalf("failed to add member %v", err)
|
|
}
|
|
|
|
if !memberAddResp.Member.IsLearner {
|
|
t.Fatalf("Added a member as learner, got resp.Member.IsLearner = %v", memberAddResp.Member.IsLearner)
|
|
}
|
|
learnerID := memberAddResp.Member.ID
|
|
|
|
numberOfLearners := 0
|
|
for _, m := range memberAddResp.Members {
|
|
if m.IsLearner {
|
|
numberOfLearners++
|
|
}
|
|
}
|
|
if numberOfLearners != 1 {
|
|
t.Fatalf("Added 1 learner node to cluster, got %d", numberOfLearners)
|
|
}
|
|
|
|
// learner is not started yet. Expect learner progress check to fail.
|
|
// As the result, member promote request will fail.
|
|
_, err = capi.MemberPromote(context.Background(), learnerID)
|
|
expectedErrKeywords := "can only promote a learner member which is in sync with leader"
|
|
if err == nil {
|
|
t.Fatalf("expecting promote not ready learner to fail, got no error")
|
|
}
|
|
if !strings.Contains(err.Error(), expectedErrKeywords) {
|
|
t.Fatalf("expecting error to contain %s, got %s", expectedErrKeywords, err.Error())
|
|
}
|
|
|
|
// create and launch learner member based on the response of V3 Member Add API.
|
|
// (the response has information on peer urls of the existing members in cluster)
|
|
learnerMember := clus.MustNewMember(t, memberAddResp)
|
|
clus.Members = append(clus.Members, learnerMember)
|
|
if err := learnerMember.Launch(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// retry until promote succeed or timeout
|
|
timeout := time.After(5 * time.Second)
|
|
for {
|
|
select {
|
|
case <-time.After(500 * time.Millisecond):
|
|
case <-timeout:
|
|
t.Errorf("failed all attempts to promote learner member, last error: %v", err)
|
|
break
|
|
}
|
|
|
|
_, err = capi.MemberPromote(context.Background(), learnerID)
|
|
// successfully promoted learner
|
|
if err == nil {
|
|
break
|
|
}
|
|
// if member promote fails due to learner not ready, retry.
|
|
// otherwise fails the test.
|
|
if !strings.Contains(err.Error(), expectedErrKeywords) {
|
|
t.Fatalf("unexpected error when promoting learner member: %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestMaxLearnerInCluster verifies that the maximum number of learners allowed in a cluster is 1
|
|
func TestMaxLearnerInCluster(t *testing.T) {
|
|
defer testutil.AfterTest(t)
|
|
|
|
// 1. start with a cluster with 3 voting member and 0 learner member
|
|
clus := integration.NewClusterV3(t, &integration.ClusterConfig{Size: 3})
|
|
defer clus.Terminate(t)
|
|
|
|
// 2. adding a learner member should succeed
|
|
resp1, err := clus.Client(0).MemberAddAsLearner(context.Background(), []string{"http://127.0.0.1:1234"})
|
|
if err != nil {
|
|
t.Fatalf("failed to add learner member %v", err)
|
|
}
|
|
numberOfLearners := 0
|
|
for _, m := range resp1.Members {
|
|
if m.IsLearner {
|
|
numberOfLearners++
|
|
}
|
|
}
|
|
if numberOfLearners != 1 {
|
|
t.Fatalf("Added 1 learner node to cluster, got %d", numberOfLearners)
|
|
}
|
|
|
|
// 3. cluster has 3 voting member and 1 learner, adding another learner should fail
|
|
_, err = clus.Client(0).MemberAddAsLearner(context.Background(), []string{"http://127.0.0.1:2345"})
|
|
if err == nil {
|
|
t.Fatalf("expect member add to fail, got no error")
|
|
}
|
|
expectedErrKeywords := "too many learner members in cluster"
|
|
if !strings.Contains(err.Error(), expectedErrKeywords) {
|
|
t.Fatalf("expecting error to contain %s, got %s", expectedErrKeywords, err.Error())
|
|
}
|
|
|
|
// 4. cluster has 3 voting member and 1 learner, adding a voting member should succeed
|
|
_, err = clus.Client(0).MemberAdd(context.Background(), []string{"http://127.0.0.1:3456"})
|
|
if err != nil {
|
|
t.Errorf("failed to add member %v", err)
|
|
}
|
|
}
|