mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00

Update to Go 1.12.5 testing. Remove deprecated unused and gosimple pacakges, and mask staticcheck 1006. Also, fix unconvert errors related to unnecessary type conversions and following staticcheck errors: - remove redundant return statements - use for range instead of for select - use time.Since instead of time.Now().Sub - omit comparison to bool constant - replace T.Fatal and T.Fatalf in tests with T.Error and T.Fatalf respectively because the goroutine calls T.Fatal must be called in the same goroutine as the test - fix error strings that should not be capitalized - use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) - use he status code of Canceled instead of grpc.ErrClientConnClosing which is deprecated - use use status.Errorf instead of grpc.Errorf which is deprecated Related #10528 #10438
75 lines
2.1 KiB
Go
75 lines
2.1 KiB
Go
// Copyright 2018 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package transport
|
|
|
|
import (
|
|
"crypto/tls"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// TestNewTransportTLSInvalidCipherSuitesTLS12 expects a client with invalid
|
|
// cipher suites fail to handshake with the server.
|
|
func TestNewTransportTLSInvalidCipherSuitesTLS12(t *testing.T) {
|
|
tlsInfo, del, err := createSelfCert()
|
|
if err != nil {
|
|
t.Fatalf("unable to create cert: %v", err)
|
|
}
|
|
defer del()
|
|
|
|
cipherSuites := []uint16{
|
|
tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
|
|
tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
|
|
tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
|
|
tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
|
|
tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,
|
|
tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305,
|
|
}
|
|
|
|
// make server and client have unmatched cipher suites
|
|
srvTLS, cliTLS := *tlsInfo, *tlsInfo
|
|
srvTLS.CipherSuites, cliTLS.CipherSuites = cipherSuites[:2], cipherSuites[2:]
|
|
|
|
ln, err := NewListener("127.0.0.1:0", "https", &srvTLS)
|
|
if err != nil {
|
|
t.Fatalf("unexpected NewListener error: %v", err)
|
|
}
|
|
defer ln.Close()
|
|
|
|
donec := make(chan struct{})
|
|
go func() {
|
|
ln.Accept()
|
|
donec <- struct{}{}
|
|
}()
|
|
go func() {
|
|
tr, err := NewTransport(cliTLS, 3*time.Second)
|
|
tr.TLSClientConfig.MaxVersion = tls.VersionTLS12
|
|
if err != nil {
|
|
t.Errorf("unexpected NewTransport error: %v", err)
|
|
}
|
|
cli := &http.Client{Transport: tr}
|
|
_, gerr := cli.Get("https://" + ln.Addr().String())
|
|
if gerr == nil || !strings.Contains(gerr.Error(), "tls: handshake failure") {
|
|
t.Error("expected client TLS handshake error")
|
|
}
|
|
ln.Close()
|
|
donec <- struct{}{}
|
|
}()
|
|
<-donec
|
|
<-donec
|
|
}
|