mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00
f2ee15a1e1
Should solve the problem of flakes documented here: https://github.com/etcd-io/etcd/issues/12372#issuecomment-706337969 ``` % (cd tests && env go test -short -timeout=3m -cpu=4 --race=true ./... -p=2) Unexpected goroutines running after all test(s). 1 instances of: go.etcd.io/etcd/v3/clientv3.(*watchGrpcStream).sendCloseSubstream(...) /go/src/go.etcd.io/etcd/clientv3/watch.go:464 +0x204 created by go.etcd.io/etcd/v3/clientv3.(*watchGrpcStream).closeSubstream /go/src/go.etcd.io/etcd/clientv3/watch.go:480 +0x21f FAIL go.etcd.io/etcd/tests/v3/integration/clientv3/examples 2.111s ``` The goroutine finishes automatically with timeout of 250ms.The change makes the test wait for it - if it still exists. Examples: https://travis-ci.com/github/etcd-io/etcd/jobs/397449189 https://travis-ci.com/github/etcd-io/etcd/jobs/397532784 https://travis-ci.com/github/etcd-io/etcd/jobs/397696506 https://travis-ci.com/github/etcd-io/etcd/jobs/403603526
pkg/ is a collection of utility packages used by etcd without being specific to etcd itself. A package belongs here only if it could possibly be moved out into its own repository in the future.