mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00
c37991cf8b
Creation of event history requires each client to return consistent events. If clients observed inconsistent view of some revision, merging will fail and return diff between two clients. This however doesn't provide hint on what kind of issue happend. This PR helps cases where there is an error with single watch stream (like event duplication) by running normal watch validation even without full event history. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
109 lines
3.9 KiB
Go
109 lines
3.9 KiB
Go
// Copyright 2023 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package validate
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
"testing"
|
|
|
|
"github.com/anishathalye/porcupine"
|
|
"github.com/google/go-cmp/cmp"
|
|
"go.uber.org/zap"
|
|
|
|
"go.etcd.io/etcd/tests/v3/robustness/model"
|
|
"go.etcd.io/etcd/tests/v3/robustness/report"
|
|
)
|
|
|
|
// ValidateAndReturnVisualize returns visualize as porcupine.linearizationInfo used to generate visualization is private.
|
|
func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, reports []report.ClientReport) (visualize func(basepath string) error) {
|
|
patchedOperations := patchedOperationHistory(reports)
|
|
linearizable, visualize := validateLinearizableOperationsAndVisualize(lg, patchedOperations)
|
|
if linearizable != porcupine.Ok {
|
|
t.Error("Failed linearization, skipping further validation")
|
|
return visualize
|
|
}
|
|
// TODO: Don't use watch events to get event history.
|
|
eventHistory, err := mergeWatchEventHistory(reports)
|
|
if err != nil {
|
|
t.Errorf("Failed merging watch history to create event history, err: %s", err)
|
|
validateWatch(t, lg, cfg, reports, nil)
|
|
return visualize
|
|
}
|
|
validateWatch(t, lg, cfg, reports, eventHistory)
|
|
validateSerializableOperations(t, lg, patchedOperations, eventHistory)
|
|
return visualize
|
|
}
|
|
|
|
type Config struct {
|
|
ExpectRevisionUnique bool
|
|
}
|
|
|
|
func mergeWatchEventHistory(reports []report.ClientReport) ([]model.WatchEvent, error) {
|
|
type revisionEvents struct {
|
|
events []model.WatchEvent
|
|
revision int64
|
|
clientId int
|
|
}
|
|
revisionToEvents := map[int64]revisionEvents{}
|
|
var lastClientId = 0
|
|
var lastRevision int64
|
|
events := []model.WatchEvent{}
|
|
for _, r := range reports {
|
|
for _, op := range r.Watch {
|
|
for _, resp := range op.Responses {
|
|
for _, event := range resp.Events {
|
|
if event.Revision == lastRevision && lastClientId == r.ClientId {
|
|
events = append(events, event)
|
|
} else {
|
|
if prev, found := revisionToEvents[lastRevision]; found {
|
|
// This assumes that there are txn that would be observed differently by two watches.
|
|
// TODO: Implement merging events from multiple watches about single revision based on operations.
|
|
if diff := cmp.Diff(prev.events, events); diff != "" {
|
|
return nil, fmt.Errorf("events between clients %d and %d don't match, revision: %d, diff: %s", prev.clientId, lastClientId, lastRevision, diff)
|
|
}
|
|
} else {
|
|
revisionToEvents[lastRevision] = revisionEvents{clientId: lastClientId, events: events, revision: lastRevision}
|
|
}
|
|
lastClientId = r.ClientId
|
|
lastRevision = event.Revision
|
|
events = []model.WatchEvent{event}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
if prev, found := revisionToEvents[lastRevision]; found {
|
|
if diff := cmp.Diff(prev.events, events); diff != "" {
|
|
return nil, fmt.Errorf("events between clients %d and %d don't match, revision: %d, diff: %s", prev.clientId, lastClientId, lastRevision, diff)
|
|
}
|
|
} else {
|
|
revisionToEvents[lastRevision] = revisionEvents{clientId: lastClientId, events: events, revision: lastRevision}
|
|
}
|
|
|
|
var allRevisionEvents []revisionEvents
|
|
for _, revEvents := range revisionToEvents {
|
|
allRevisionEvents = append(allRevisionEvents, revEvents)
|
|
}
|
|
sort.Slice(allRevisionEvents, func(i, j int) bool {
|
|
return allRevisionEvents[i].revision < allRevisionEvents[j].revision
|
|
})
|
|
var eventHistory []model.WatchEvent
|
|
for _, revEvents := range allRevisionEvents {
|
|
eventHistory = append(eventHistory, revEvents.events...)
|
|
}
|
|
return eventHistory, nil
|
|
}
|